From patchwork Fri May 3 06:36:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241207 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-da0-x237.google.com (mail-da0-x237.google.com [IPv6:2607:f8b0:400e:c00::237]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id D44502C00A8 for ; Fri, 3 May 2013 16:36:22 +1000 (EST) Received: by mail-da0-f55.google.com with SMTP id x6sf368042dac.0 for ; Thu, 02 May 2013 23:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=MVEyEQOpz+3qdmLUcpR9scDwSSkX6Nuhf3VnKIGjgHM=; b=LYQ6Swkyx8WvmS29tadx8ibOjeHap+Qdrq0laVGfh479Az5x+eFaDey+Jub4vv1qde juNuVgJ6xmBL/Kshl+oFYA92PsSgm7Sosz7QjWe6ZBugNtdH5eshqR5PH67dh/sodmRP HQkbZHcBZsBfo9DAsiYw8eg4FAa3xLybHI95ufTUi+uZwFVYx0vPexf+g+WmW8xSwoiE Oy5TrCAT8qgekfkMJGjAhowwh38Qci46kXXgCCMgFXsmgEC1g6foP7+5Q/AuOl3RvSUn dnDJvNabWPLu7fT64D4XWYI/gLEHGE+MloGeqR4D/70hoWRda9d+GgwdcKgYKrkmCL1s C8RQ== X-Received: by 10.50.29.13 with SMTP id f13mr114486igh.0.1367562980648; Thu, 02 May 2013 23:36:20 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.151.135 with SMTP id uq7ls199018igb.24.canary; Thu, 02 May 2013 23:36:20 -0700 (PDT) X-Received: by 10.66.13.3 with SMTP id d3mr4068792pac.40.1367562979991; Thu, 02 May 2013 23:36:19 -0700 (PDT) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id xb6si1787951pab.0.2013.05.02.23.36.19 for ; Thu, 02 May 2013 23:36:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM7006H3MAZUZ10@mailout1.samsung.com> for rtc-linux@googlegroups.com; Fri, 03 May 2013 15:36:19 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id B7.61.19350.3EA53815; Fri, 03 May 2013 15:36:19 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-ee-51835ae316cf Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 08.1E.01422.2EA53815; Fri, 03 May 2013 15:36:18 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM700MMSMCIC9L0@mmp1.samsung.com>; Fri, 03 May 2013 15:36:18 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, Jingoo Han Subject: [rtc-linux] [PATCH 32/42] rtc: rtc-sa1100: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:36:18 +0900 Message-id: <002e01ce47c8$84dfbdd0$8e9f3970$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HyIJ4HRR+z2gxQtCwTJ/h8Nl6SA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsVy+t8zY93HUc2BBr82M1ksuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGsVlk5Kak1mW WqRvl8CVceKMakEnd8X29R/ZGhj/cXQxcnJICJhI7HwzmRnCFpO4cG89WxcjF4eQwDJGiU23 f7LCFD2++IgdIrGIUeLA8nlMEM4vRom2qZfAqtgE1CS+fDkMVMXBISKgL9HWogFSwyzQzSjx qHku2AphgWCJWydmsoHYLAKqEqvW3QSzeQUsJZ6vOMwMYQtK/Jh8jwXEZhbQkli/8zgThC0v sXnNW6hTFSR2nH3NCGKLCOhJXJuykw2iRkRi34t3jCCLJQSOsUtM2dTLDrFMQOLb5EMsIMdJ CMhKbDoANUdS4uCKGywTGMVmIVk9C8nqWUhWz0KyYgEjyypG0dSC5ILipPQiU73ixNzi0rx0 veT83E2MkNibuIPx/gHrQ4zJQOsnMkuJJucDYzevJN7Q2MzIwtTE1NjI3NKMNGElcV71FutA IYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYzzJryMtOZJmfNH61j/hNN1LQ/8P/y+9eLufbdN bVlra38Y2v5pqj8VvY7v+uRJRa+SM2YVhtaFzei4kxa3wjPyx/L7Gy72q96ZcyFBIynr5P1L 0o/3pPI1n2rQsfESYTvAuc943plPj5Ys2iaut2rvza37zQ7u3B4qMa/zdHmW09OFK5fOFjrQ q8RSnJFoqMVcVJwIAIrnIPvTAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLKsWRmVeSWpSXmKPExsVy+t9jAd1HUc2BBo8eWlssuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmHHijGpBJ3fF9vUf2RoY/3F0MXJySAiYSDy+ +IgdwhaTuHBvPVsXIxeHkMAiRokDy+cxQTi/GCXapl5iBaliE1CT+PLlMFAHB4eIgL5EW4sG SA2zQDejxKPmucwgNcICwRK3TsxkA7FZBFQlVq27CWbzClhKPF9xmBnCFpT4MfkeC4jNLKAl sX7ncSYIW15i85q3zBAXKUjsOPuaEcQWEdCTuDZlJxtEjYjEvhfvGCcwCsxCMmoWklGzkIya haRlASPLKkbR1ILkguKk9FwjveLE3OLSvHS95PzcTYzgyH4mvYNxVYPFIUYBDkYlHl6FlqZA IdbEsuLK3EOMEhzMSiK8bj+AQrwpiZVVqUX58UWlOanFhxiTgT6dyCwlmpwPTDp5JfGGxiZm RpZGZhZGJubmpAkrifMebLUOFBJITyxJzU5NLUgtgtnCxMEp1cC4UiPPRM7HM8Df2TLpU/VR tavhu01bvvBnyB4I6rkvyHZJ+1Gp2dMJO5ZeZP/5ZEb1dp3697MNCraI681RME955h54qvdF /Jqfmt1lH18eX/zs6s9A3l1O4vP+lssXH/jU8bmQW/eyc3bXMbPZe350Plxz/MfSj5MTpzxX 7BOKUvkl8KBPWG6KEktxRqKhFnNRcSIAmndMbDADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-sa1100.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-sa1100.c b/drivers/rtc/rtc-sa1100.c index 0060560..0f7adeb 100644 --- a/drivers/rtc/rtc-sa1100.c +++ b/drivers/rtc/rtc-sa1100.c @@ -249,7 +249,7 @@ static int sa1100_rtc_probe(struct platform_device *pdev) ret = clk_prepare_enable(info->clk); if (ret) - goto err_enable_clk; + return ret; /* * According to the manual we should be able to let RTTR be zero * and then a default diviser for a 32.768KHz clock is used. @@ -303,8 +303,6 @@ static int sa1100_rtc_probe(struct platform_device *pdev) return 0; err_dev: clk_disable_unprepare(info->clk); -err_enable_clk: - platform_set_drvdata(pdev, NULL); return ret; } @@ -312,10 +310,8 @@ static int sa1100_rtc_remove(struct platform_device *pdev) { struct sa1100_rtc *info = platform_get_drvdata(pdev); - if (info) { + if (info) clk_disable_unprepare(info->clk); - platform_set_drvdata(pdev, NULL); - } return 0; }