From patchwork Fri May 3 06:35:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241206 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gh0-f189.google.com (mail-gh0-f189.google.com [209.85.160.189]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 87B9C2C00A8 for ; Fri, 3 May 2013 16:36:03 +1000 (EST) Received: by mail-gh0-f189.google.com with SMTP id z13sf355651ghb.26 for ; Thu, 02 May 2013 23:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=FejRoAO6DnFEoC+aDecYa3RbLGzO6/7TPga62Ej5tAY=; b=Kk93r6qhVGsCp1f3TKwZgKHX1B6IBdna/nXI3PUKGx3rPZ2lDFB7ZjDelplzmsupg+ S0OcwuSS2m5t5WVGDcYGCBQvdNVUbyGgSP454XpoVP8PngK/Zyj835ivH7GF0+DEE8hT sTXQSnaI7OQ2nImrX67SJVTbdYBg+VUmJ6mSUMm8XtSynk+9SX1zRYVfrWgnpf70/0ce wYfziSVb9h1aVRH4r9UPsSG6PRQS9VAV1ha5xrupCOQlJ5QTPhR7VB8x9HBg45FEHSSZ VBhkMcc5QVpP+rwa49a6DENFGlvathYqB9LwvmQiS84iWR2I2FzgdoFU0ePCanQSOGHX efBw== X-Received: by 10.50.111.230 with SMTP id il6mr1409137igb.14.1367562961116; Thu, 02 May 2013 23:36:01 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.12.106 with SMTP id x10ls236632igb.2.gmail; Thu, 02 May 2013 23:36:00 -0700 (PDT) X-Received: by 10.66.144.98 with SMTP id sl2mr4072123pab.12.1367562960880; Thu, 02 May 2013 23:36:00 -0700 (PDT) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id xb6si1787706pab.0.2013.05.02.23.36.00 for ; Thu, 02 May 2013 23:36:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM700KZVMBYB440@mailout2.samsung.com> for rtc-linux@googlegroups.com; Fri, 03 May 2013 15:36:00 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 3A.C1.13955.FCA53815; Fri, 03 May 2013 15:35:59 +0900 (KST) X-AuditID: cbfee68f-b7f066d000003683-07-51835acff27e Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 4E.9D.08957.FCA53815; Fri, 03 May 2013 15:35:59 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM7000YCMBZP4E0@mmp1.samsung.com>; Fri, 03 May 2013 15:35:59 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, Jingoo Han Subject: [rtc-linux] [PATCH 31/42] rtc: rtc-s3c: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:35:59 +0900 Message-id: <002d01ce47c8$798ae4a0$6ca0ade0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HyHjWtsTIwtj7SOW/jCcWYMcKFw== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsVy+t8zA93zUc2BBj+abCyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DK2NjSy1rwnrvi/ZVjjA2MFzi7GDk5JARMJP6v2MAIYYtJXLi3nq2LkYtDSGAZo8T0 tztZYIo+XGtmhEgsYpSY/f8wC4Tzi1HiXONNsCo2ATWJL18Os3cxcnCICOhLtLVogNQwC3Qz SjxqnssMUiMs4Cfx5es0sHUsAqoSd9YtBuvlFbCUmP1zCiOELSjxY/I9sDizgJbE+p3HmSBs eYnNa94yQ1ykILHj7GuwehEBPYk9Dy5C1YhI7HvxDuxSCYFj7BLHZu9gglgmIPFt8iEWkOMk BGQlNh2AmiMpcXDFDZYJjGKzkKyehWT1LCSrZyFZsYCRZRWjaGpBckFxUnqRsV5xYm5xaV66 XnJ+7iZGSPT172C8e8D6EGMy0PqJzFKiyfnA6M0riTc0NjOyMDUxNTYytzQjTVhJnFetxTpQ SCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA2Obl2phd0R0bFW3Tqgdi/Y7o4iPk94/Psp2hin+ Ypj6pSCV6+EPEw2uiZb0N+rOPj9VPfjfDKeyex+tsv9VXje6qMN4Us332bF/3x9eO+nJ2eTb spkr4NG7thkXlj7fUyFYO/2w/LyjFzmurVThVr38rWSPv9z+bZNeTplzy+P5mnMdvtOuVE9R YinOSDTUYi4qTgQA/+98c9QCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsVy+t9jAd3zUc2BBmdaLSyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjWpgtMlITUxJ LVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB2q6kUJaYUwoUCkgs LlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxjzNjY0sta8J674v2VY4wNjBc4uxg5OSQETCQ+ XGtmhLDFJC7cW8/WxcjFISSwiFFi9v/DLBDOL0aJc403WUCq2ATUJL58OczexcjBISKgL9HW ogFSwyzQzSjxqHkuM0iNsICfxJev08CmsgioStxZtxisl1fAUmL2zymMELagxI/J98DizAJa Eut3HmeCsOUlNq95ywxxkYLEjrOvwepFBPQk9jy4CFUjIrHvxTvGCYwCs5CMmoVk1Cwko2Yh aVnAyLKKUTS1ILmgOCk911CvODG3uDQvXS85P3cTIzi2n0ntYFzZYHGIUYCDUYmHV6GlKVCI NbGsuDL3EKMEB7OSCK/bD6AQb0piZVVqUX58UWlOavEhxmSgTycyS4km5wPTTl5JvKGxiZmR pZGZhZGJuTlpwkrivAdarQOFBNITS1KzU1MLUotgtjBxcEo1MOod4Xu/4b9Z7bSY+DM/8g57 rgjpPql2J7asZZ+G5KXm+LMGJQ9/z7fXOuLI5VfzWY93wvSrtqL7LbRPOD9kVVjcJSXLtc0y wrs2ZnvNgiOdE94XLHIRz1kkdWLSJ/VXb05tcFRIk0n9K/rI8Zr4jx3HdHbonbz/qvDtzSgJ savvVBdVLQo/I6DEUpyRaKjFXFScCABTlI6DMQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-s3c.c | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index 14040b2..4d38c6b 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -421,8 +421,6 @@ static void s3c_rtc_enable(struct platform_device *pdev, int en) static int s3c_rtc_remove(struct platform_device *dev) { - platform_set_drvdata(dev, NULL); - s3c_rtc_setaie(&dev->dev, 0); clk_unprepare(rtc_clk); @@ -554,23 +552,20 @@ static int s3c_rtc_probe(struct platform_device *pdev) 0, "s3c2410-rtc alarm", rtc); if (ret) { dev_err(&pdev->dev, "IRQ%d error %d\n", s3c_rtc_alarmno, ret); - goto err_alarm_irq; + goto err_nortc; } ret = devm_request_irq(&pdev->dev, s3c_rtc_tickno, s3c_rtc_tickirq, 0, "s3c2410-rtc tick", rtc); if (ret) { dev_err(&pdev->dev, "IRQ%d error %d\n", s3c_rtc_tickno, ret); - goto err_alarm_irq; + goto err_nortc; } clk_disable(rtc_clk); return 0; - err_alarm_irq: - platform_set_drvdata(pdev, NULL); - err_nortc: s3c_rtc_enable(pdev, 0); clk_disable_unprepare(rtc_clk);