From patchwork Fri May 3 06:21:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 241197 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vb0-x23a.google.com (mail-vb0-x23a.google.com [IPv6:2607:f8b0:400c:c02::23a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id D1DFA2C00AF for ; Fri, 3 May 2013 16:35:16 +1000 (EST) Received: by mail-vb0-f58.google.com with SMTP id p14sf377177vbm.13 for ; Thu, 02 May 2013 23:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=OSvqNKQU7jqtMUVixe5vGlU8sZVlVIH1cssI2F/PlOA=; b=LfgPsBrasYQhIS2TdMbOxuSHhWudyaMXD34QL01GOFlVKtvfKC6p57IiO5kJyvgbTN 8/ax5JYFkRZYamtbrrgriMrSlhwUyG+wOl+PpUEAl9nOlNp7pIGz6n6++7gvD257lTG3 EPCSkc7YUekUm82OJ2kRxlR1BygXxtYMrdrmt5PgEa/LZnTLFSTWJOwTnNU/kqRrz4JW mUkxGaAg6dp2zFt0SrN1MznPpNS2UexaF0HXIqVtdjY1z3UBf1Pr9479wi30gn92S6oo BLynev15jcN36bVGRwj9B7AOX93o7ec9aJqT0qcPBSXyUdfe0ljWQlt+xXy0kmS5hNgo pRpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=OSvqNKQU7jqtMUVixe5vGlU8sZVlVIH1cssI2F/PlOA=; b=WS507NU7nW18lJ4JTaHB4oxtMx5fYJJSRNOAUnYJagksiX5lliDWfBKekRiMukhsLg rivFExQSbYkNV2NpAeRfG9mcodAX+QWNnhFLCbrTyEWRR+DE64ACdo12Ptcf3L2cQnxi WOejHlVAOeK88p16xBiRbSFGmavpcjnlOkCSmJHWdB9mibxiGg/qnsfTJwSph5v51UQ4 DKsCwVeHywwJMkiBo7Xi8uH4X5rUCbZEeubbhz1ZDhQ8ZuSKsbEc86R06Mcy1LrhMlR5 0pFFcc+TaSpjcueFH072ufslbrY5WNVnJB2qcCmu6i3K+lN2bHAQDfRyARDF+DzYMs7i FCBg== X-Received: by 10.50.39.102 with SMTP id o6mr1413947igk.7.1367562914321; Thu, 02 May 2013 23:35:14 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.50.129 with SMTP id c1ls204545igo.25.canary; Thu, 02 May 2013 23:35:14 -0700 (PDT) X-Received: by 10.66.191.130 with SMTP id gy2mr3886748pac.19.1367562913999; Thu, 02 May 2013 23:35:13 -0700 (PDT) Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by gmr-mx.google.com with ESMTPS id fn10si1783830pab.1.2013.05.02.23.35.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 02 May 2013 23:35:13 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.43 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.43; Received: by mail-pa0-f43.google.com with SMTP id hz10so771954pad.16 for ; Thu, 02 May 2013 23:35:13 -0700 (PDT) X-Received: by 10.68.198.99 with SMTP id jb3mr8094919pbc.195.1367562913933; Thu, 02 May 2013 23:35:13 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id kr7sm11485494pab.23.2013.05.02.23.35.11 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 02 May 2013 23:35:13 -0700 (PDT) From: Sachin Kamat To: rtc-linux@googlegroups.com Cc: a.zummo@towertech.it, akpm@linux-foundation.org, sachin.kamat@linaro.org Subject: [rtc-linux] [PATCH 21/26] drivers/rtc/rtc-pcf8583.c: Move assignment outside if condition Date: Fri, 3 May 2013 11:51:11 +0530 Message-Id: <1367562076-25713-22-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1367562076-25713-1-git-send-email-sachin.kamat@linaro.org> References: <1367562076-25713-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQkZbmHc2vC1pYSvze4e702iG/bqBZhMNcKYLg9+YAM7u1EDG2+jcwQ5XRhkbfErlhfZD+fz X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 209.85.220.43 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Fixes the following checkpatch error: ERROR: do not use assignment in if condition Signed-off-by: Sachin Kamat --- drivers/rtc/rtc-pcf8583.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8583.c b/drivers/rtc/rtc-pcf8583.c index 95886dc..9971f7f 100644 --- a/drivers/rtc/rtc-pcf8583.c +++ b/drivers/rtc/rtc-pcf8583.c @@ -188,7 +188,8 @@ static int pcf8583_rtc_read_time(struct device *dev, struct rtc_time *tm) dev_warn(dev, "resetting control %02x -> %02x\n", ctrl, new_ctrl); - if ((err = pcf8583_set_ctrl(client, &new_ctrl)) < 0) + err = pcf8583_set_ctrl(client, &new_ctrl); + if (err < 0) return err; }