Patchwork [28/42] rtc: rtc-nuc900: remove unnecessary platform_set_drvdata()

login
register
mail settings
Submitter Jingoo Han
Date May 3, 2013, 6:34 a.m.
Message ID <002a01ce47c8$3b993250$b2cb96f0$@samsung.com>
Download mbox | patch
Permalink /patch/241176/
State New
Headers show

Comments

Jingoo Han - May 3, 2013, 6:34 a.m.
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-nuc900.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Wan ZongShun - May 4, 2013, 12:10 p.m.
Thanks


2013/5/3 Jingoo Han <jg1.han@samsung.com>

> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>

Acked-by :Wan Zongshun <mcuos.com@gmail.com> .


> ---
>  drivers/rtc/rtc-nuc900.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-nuc900.c b/drivers/rtc/rtc-nuc900.c
> index f5dfb6e..90ca8aa 100644
> --- a/drivers/rtc/rtc-nuc900.c
> +++ b/drivers/rtc/rtc-nuc900.c
> @@ -267,8 +267,6 @@ static int __init nuc900_rtc_probe(struct
> platform_device *pdev)
>
>  static int __exit nuc900_rtc_remove(struct platform_device *pdev)
>  {
> -       platform_set_drvdata(pdev, NULL);
> -
>         return 0;
>  }
>
> --
> 1.7.2.5
>
>
>

Patch

diff --git a/drivers/rtc/rtc-nuc900.c b/drivers/rtc/rtc-nuc900.c
index f5dfb6e..90ca8aa 100644
--- a/drivers/rtc/rtc-nuc900.c
+++ b/drivers/rtc/rtc-nuc900.c
@@ -267,8 +267,6 @@  static int __init nuc900_rtc_probe(struct platform_device *pdev)
 
 static int __exit nuc900_rtc_remove(struct platform_device *pdev)
 {
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }