From patchwork Fri May 3 06:33:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241174 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pa0-f55.google.com (mail-pa0-f55.google.com [209.85.220.55]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 08F962C007C for ; Fri, 3 May 2013 16:33:11 +1000 (EST) Received: by mail-pa0-f55.google.com with SMTP id kp6sf366742pab.0 for ; Thu, 02 May 2013 23:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=OQSPglSJ/XyAKLvy1xbHSNuELHKz29NceCtza2ZXJOE=; b=SYd4EAd9zsPVVAXYZMxiytcHwXr6SIEiwJdfa8y/JkV3KYThNPrABOL9KntwozxNUe FbbVXjta0nU6DzrK2mQIdPoLaL/ZBle5eGFkFh+jmZdQOwKbQq3iFS6WqFuc4mRKlm0W oXcv5u+bIhBAYNvsyZYGmfYFM6Q8488sjVkg7mF6yG6STbqhTeyHXxjRkD/fdmMTTki9 HmUId5WnZUCLaw+Thzh5feBWubuuk1kggomZJPRlFBl4R8knafO/Mgo9m0AkOGJE81d6 qrtbEjnfrSN+74Fx6lCtQz7lgKqG8vkmIBOjH+mOXlBRJKF9z7UyPIzCoo6lEWYvjJDT pxCg== X-Received: by 10.50.128.105 with SMTP id nn9mr1400261igb.17.1367562790134; Thu, 02 May 2013 23:33:10 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.23.74 with SMTP id k10ls241013igf.38.gmail; Thu, 02 May 2013 23:33:09 -0700 (PDT) X-Received: by 10.66.14.165 with SMTP id q5mr4032175pac.47.1367562789831; Thu, 02 May 2013 23:33:09 -0700 (PDT) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id xq5si1781991pac.2.2013.05.02.23.33.09 for ; Thu, 02 May 2013 23:33:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM700G1EM6CMH70@mailout2.samsung.com> for rtc-linux@googlegroups.com; Fri, 03 May 2013 15:33:08 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 8C.0C.04074.42A53815; Fri, 03 May 2013 15:33:08 +0900 (KST) X-AuditID: cbfee690-b7f136d000000fea-08-51835a247f10 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 22.9C.08957.42A53815; Fri, 03 May 2013 15:33:08 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM7001UPM7813A0@mmp1.samsung.com>; Fri, 03 May 2013 15:33:08 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, Jingoo Han Subject: [rtc-linux] [PATCH 26/42] rtc: rtc-msm6242: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:33:08 +0900 Message-id: <002801ce47c8$1391da00$3ab58e00$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HyBGn9OwxEjdeTbSGcp84aA0keQ== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsVy+t8zY12VqOZAgy+bTSyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKuNC2gb3gBlfF66d3WBsYn3B0MXJySAiYSOyaNI8dwhaTuHBvPVsXIxeHkMAyRokd e2+wwhSt3P2BBSKxiFFi1vzNrBDOL0aJr/vvMIJUsQmoSXz5chhoFAeHiIC+RFuLBkgNs0A3 o8Sj5rnMIDXCAiESPTuXMIHYLAKqEncbF4PFeQUsJRoOvIGyBSV+TL7HAmIzC2hJrN95nAnC lpfYvOYtM8RFChI7zr4G2ysioCcx/dB1dogaEYl9L94xQtQcY5c4srsMYpeAxLfJh1hAbpMQ kJXYdABqjKTEwRU3WCYwis1CsnkWks2zkGyehWTDAkaWVYyiqQXJBcVJ6UUmesWJucWleel6 yfm5mxghsTdhB+O9A9aHGJOB1k9klhJNzgfGbl5JvKGxmZGFqYmpsZG5pRlpwkrivOot1oFC AumJJanZqakFqUXxRaU5qcWHGJk4OKUaGOvs7t4v/RTZLZ8xd930exlHLoVY2V9nzFf9eJH7 ffQkJyGlM3Kr2AoZdh0uLHJK/1ZZorl217wj+j9ryg/lrbXxumvtK7dJ7qnb5VeZz2/942t+ Iyf6+U2+86fF8hV7StK8vB+oLFmTsH63nY++zHvThyrTrEJOczMYRcw42RXh77tt9Yq9L5VY ijMSDbWYi4oTAWiBfBDTAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsVy+t9jAV2VqOZAg667BhZLLl5lt5izfg2b xeWFl1gtLu+aw2axv7OD0YHVY8/Ek2weJ2b8ZvHo27KK0WP6vJ9MHp83yQWwRjUw2mSkJqak Fimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAbVdSKEvMKQUKBSQW Fyvp22GaEBripmsB0xih6xsSBNdjZIAGEtYxZlxo28BecIOr4vXTO6wNjE84uhg5OSQETCRW 7v7AAmGLSVy4t56ti5GLQ0hgEaPErPmbWSGcX4wSX/ffYQSpYhNQk/jy5TB7FyMHh4iAvkRb iwZIDbNAN6PEo+a5zCA1wgIhEj07lzCB2CwCqhJ3GxeDxXkFLCUaDryBsgUlfky+B7aZWUBL Yv3O40wQtrzE5jVvmSEuUpDYcfY12F4RAT2J6Yeus0PUiEjse/GOcQKjwCwko2YhGTULyahZ SFoWMLKsYhRNLUguKE5KzzXUK07MLS7NS9dLzs/dxAiO7WdSOxhXNlgcYhTgYFTi4VVoaQoU Yk0sK67MPcQowcGsJMLr9gMoxJuSWFmVWpQfX1Sak1p8iDEZ6NOJzFKiyfnAtJNXEm9obGJm ZGlkZmFkYm5OmrCSOO+BVutAIYH0xJLU7NTUgtQimC1MHJxSDYwhzNsdX1ROdhW/VChWnVUQ O/FYEKfSbW7XTe4+HQ/XHRecPvN4hqugo9x5tr4ipwYBbt+5s54FvWRzWDfXTaLv00312zLx BzeoPtKJPPtpgeS9WRu/zPvv1bZWfoLwDUmWnmifjS67fP9kP7q27d2m1wWNDI4CUxkWZ/au Xab01Xeh8Zbd874rsRRnJBpqMRcVJwIA7uY6VTEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-msm6242.c | 11 ++--------- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-msm6242.c b/drivers/rtc/rtc-msm6242.c index 771f86a..3b300ec 100644 --- a/drivers/rtc/rtc-msm6242.c +++ b/drivers/rtc/rtc-msm6242.c @@ -199,7 +199,6 @@ static int __init msm6242_rtc_probe(struct platform_device *pdev) struct resource *res; struct msm6242_priv *priv; struct rtc_device *rtc; - int error; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) @@ -216,17 +215,11 @@ static int __init msm6242_rtc_probe(struct platform_device *pdev) rtc = devm_rtc_device_register(&pdev->dev, "rtc-msm6242", &msm6242_rtc_ops, THIS_MODULE); - if (IS_ERR(rtc)) { - error = PTR_ERR(rtc); - goto out_unmap; - } + if (IS_ERR(rtc)) + return PTR_ERR(rtc); priv->rtc = rtc; return 0; - -out_unmap: - platform_set_drvdata(pdev, NULL); - return error; } static int __exit msm6242_rtc_remove(struct platform_device *pdev)