From patchwork Fri May 3 06:31:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241168 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qe0-f62.google.com (mail-qe0-f62.google.com [209.85.128.62]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 2F9A72C00A4 for ; Fri, 3 May 2013 16:31:23 +1000 (EST) Received: by mail-qe0-f62.google.com with SMTP id q19sf379179qeb.27 for ; Thu, 02 May 2013 23:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=RM4J/K+8H19qfVBeu2rTiWotsSsjk9EuRs7xO4wcVws=; b=Bsnsa5C0lmZWjEqthkO9qhoQBy8lvj8IXkemqan8FYB6ZvrwyxbObcNhJRAHWeS4BZ muVC3GZLYc2s/2vZTeN+lN4eEgHpZm99qyaTsbQbXu1xO3H0LAn8I+HqUJrqqv/k8RvE 3q8ZFotkkJMXZUD01n+qW0b/fneTWwXdt/eMjUjLAvz76Wj2XMnZt/+SwBRXNsxW82IB DYpn+uHz5r/5HKs3R0HHWl8byGw/zue6fNT/AP5E+pdS9AEjEK6Zu7HDsUpPB+/Nd3h4 WO+oMOQLwygcpjOa3aiYQkKaFDZBOwh5SN+hlAlO8GBKP5p0hVV/1UaRLflZz8E+0LhL 4Ukg== X-Received: by 10.50.112.105 with SMTP id ip9mr1420223igb.1.1367562680927; Thu, 02 May 2013 23:31:20 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.149.138 with SMTP id ua10ls191947igb.41.canary; Thu, 02 May 2013 23:31:20 -0700 (PDT) X-Received: by 10.66.121.4 with SMTP id lg4mr4062471pab.41.1367562680133; Thu, 02 May 2013 23:31:20 -0700 (PDT) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id xq5si1782040pac.2.2013.05.02.23.31.19 for ; Thu, 02 May 2013 23:31:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM700GYFM47MH60@mailout2.samsung.com> for rtc-linux@googlegroups.com; Fri, 03 May 2013 15:31:19 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id C7.1B.04074.7B953815; Fri, 03 May 2013 15:31:19 +0900 (KST) X-AuditID: cbfee690-b7f136d000000fea-50-518359b7fb64 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 77.CB.01422.7B953815; Fri, 03 May 2013 15:31:19 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM700MQ8M46HDW0@mmp2.samsung.com>; Fri, 03 May 2013 15:31:18 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, Jingoo Han Subject: [rtc-linux] [PATCH 20/42] rtc: rtc-lpc32xx: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:31:18 +0900 Message-id: <002201ce47c7$d226b860$76742920$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5Hx9FMbiiI9x4DQ4SO12OWWZQZ2w== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t8zA93tkc2BBms6eS2WXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKuNLwnbVgD0fFvelcDYy/2boYOTkkBEwkHs3bzQxhi0lcuLceKM7FISSwjFFiYds/ dpiiK+8vskAkpjNKnG/ZCdYhJPCLUeJddyKIzSagJvHly2GgBg4OEQF9ibYWDZB6ZoFuRolH zXPB6oUFQiTubNoKNpRFQFXiz59nTCA2r4ClRNvnU8wQtqDEj8n3WEBsZgEtifU7jzNB2PIS m9e8hbpUQWLH2deMILaIgJ7ExS+PGSFqRCT2vXjHCLJYQuAYu8SFOV+YIZYJSHybfIgF5DgJ AVmJTQeg5khKHFxxg2UCo9gsJKtnIVk9C8nqWUhWLGBkWcUomlqQXFCclF5kolecmFtcmpeu l5yfu4kREnkTdjDeO2B9iDEZaP1EZinR5Hxg5OaVxBsamxlZmJqYGhuZW5qRJqwkzqveYh0o JJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgZFJpTDQPzRdcXfS3xNvrayWrvUW1ezcf+ikLOfx uvVRFz8/yG9VUJsf5zrh7dWyRft/f7/wOPRuG7tYevCV1RLewRE6HEZH3nKxHGG9pLb3ff/z zTMLyyWUfoYdfeZptOF3zYQzldemn/7b7i9mU3qEwdrKLrnisXZw0YbZ2gt2HZxTnH/mU6QS S3FGoqEWc1FxIgBC/aIl0gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jQd3tkc2BBrvmcVosuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmHGl4TtrwR6OinvTuRoYf7N1MXJySAiYSFx5 f5EFwhaTuHBvPVCci0NIYDqjxPmWncwgCSGBX4wS77oTQWw2ATWJL18Os3cxcnCICOhLtLVo gNQzC3QzSjxqngtWLywQInFn01Z2EJtFQFXiz59nTCA2r4ClRNvnU8wQtqDEj8n3wBYzC2hJ rN95nAnClpfYvOYtM8RBChI7zr5mBLFFBPQkLn55zAhRIyKx78U7xgmMArOQjJqFZNQsJKNm IWlZwMiyilE0tSC5oDgpPddIrzgxt7g0L10vOT93EyM4rp9J72Bc1WBxiFGAg1GJh1ehpSlQ iDWxrLgy9xCjBAezkgiv2w+gEG9KYmVValF+fFFpTmrxIcZkoE8nMkuJJucDU05eSbyhsYmZ kaWRmYWRibk5acJK4rwHW60DhQTSE0tSs1NTC1KLYLYwcXBKNTByMxdyNPbs9+P0TJqnfUmu qDnit912lZaDr3j2K4ubP1O3trtqHXnJanfc9rduN53Tw9fo/AmZGd7zKPOAh4B4XmNYYsyJ doZ7R/R+v7yxgjWok+FN3NlTP7pLTizPO7byjnkw/zLBbDXWqcn7P0UoTNiZ7d4RbVT2LclY vvHx8V3uL4OCJiqxFGckGmoxFxUnAgCHhzwPLwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-lpc32xx.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-lpc32xx.c b/drivers/rtc/rtc-lpc32xx.c index 787550d..8276ae9 100644 --- a/drivers/rtc/rtc-lpc32xx.c +++ b/drivers/rtc/rtc-lpc32xx.c @@ -277,7 +277,6 @@ static int lpc32xx_rtc_probe(struct platform_device *pdev) &lpc32xx_rtc_ops, THIS_MODULE); if (IS_ERR(rtc->rtc)) { dev_err(&pdev->dev, "Can't get RTC\n"); - platform_set_drvdata(pdev, NULL); return PTR_ERR(rtc->rtc); } @@ -306,8 +305,6 @@ static int lpc32xx_rtc_remove(struct platform_device *pdev) if (rtc->irq >= 0) device_init_wakeup(&pdev->dev, 0); - platform_set_drvdata(pdev, NULL); - return 0; }