| Submitter | Jingoo Han |
|---|---|
| Date | May 3, 2013, 6:30 a.m. |
| Message ID | <002001ce47c7$be5e05e0$3b1a11a0$@samsung.com> |
| Download | mbox | patch |
| Permalink | /patch/241166/ |
| State | New |
| Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBIFTRWGAKGQEDXE4BWY@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gh0-f188.google.com (mail-gh0-f188.google.com [209.85.160.188]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 80A662C00A4 for <incoming@patchwork.ozlabs.org>; Fri, 3 May 2013 16:30:59 +1000 (EST) Received: by mail-gh0-f188.google.com with SMTP id r11sf363321ghr.15 for <incoming@patchwork.ozlabs.org>; Thu, 02 May 2013 23:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=08jd60sjJEdmdrMP4j2yi6NUNBe4z4oEf7zxNY15sJM=; b=daEI/zXnKBQTlTLJSigPTPjsVcD9tqAG67mJMecrnifrbfWQ460OFe6puxbNlacmrw G97nx8+jq+TX5Vk/jDmsHV8RIsqWT0gwQTfhowiRPEOFYBO1gmHnTisM9npH/NMrKnM6 LdxHZOU2Zs+pN5wfOJC2++Vu6hGN5di5gQM0YruCFilydNv53phTF2agKvPaNGprpS85 6vzxZnLNdEbQX9iRgovT8Fm0isXJhhjQSkGJCrp7kvC5uv2AIymLR1GCaMwOUKW8e58J yRCFz/lnItg/3v8AtHExSx1SrmeeIQBgT4ZjHSSyh1Y/aVAVH+wZsr+bPfVgBoN3VAOH vxOQ== X-Received: by 10.50.111.230 with SMTP id il6mr1408319igb.14.1367562656777; Thu, 02 May 2013 23:30:56 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.7.38 with SMTP id g6ls243146iga.26.canary; Thu, 02 May 2013 23:30:56 -0700 (PDT) X-Received: by 10.66.26.226 with SMTP id o2mr4074247pag.1.1367562656376; Thu, 02 May 2013 23:30:56 -0700 (PDT) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id gk5si1701470pbc.0.2013.05.02.23.30.56 for <rtc-linux@googlegroups.com>; Thu, 02 May 2013 23:30:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM7003D1M2XT660@mailout3.samsung.com> for rtc-linux@googlegroups.com; Fri, 03 May 2013 15:30:45 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id CE.0F.19350.59953815; Fri, 03 May 2013 15:30:45 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-11-51835995c5b0 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 21.EB.08957.59953815; Fri, 03 May 2013 15:30:45 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM700M5GM391Y01@mmp2.samsung.com>; Fri, 03 May 2013 15:30:45 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, Jingoo Han <jg1.han@samsung.com> Subject: [rtc-linux] [PATCH 18/42] rtc: rtc-jz4740: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:30:45 +0900 Message-id: <002001ce47c7$be5e05e0$3b1a11a0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5Hx72sLj2/LOXUQM2GsgfzaxuMFQ== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsVy+t8zY92pkc2BBuvbLSyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKmLL+H2tBK0fFh5+vmBsY77J1MXJySAiYSNw8u5YFwhaTuHBvPVCci0NIYBmjxN3r p9lhig5dO8YKkZjOKLFy7n9GCOcXo8TEA78YQarYBNQkvnw5DNTBwSEioC/R1qIBUsMs0M0o 8ah5LjNIjbBAsMTVh+/AprIIqEr8+vUSzOYVsJS43j2NBcIWlPgx+R6YzSygJbF+53EmCFte YvOat8wQFylI7Dj7GmyviICeROOzP1D1IhL7XrwDO05C4BC7xIndPcwQywQkvk0+xAJynISA rMSmA1BzJCUOrrjBMoFRbBaS1bOQrJ6FZPUsJCsWMLKsYhRNLUguKE5KLzLVK07MLS7NS9dL zs/dxAiJvok7GO8fsD7EmAy0fiKzlGhyPjB680riDY3NjCxMTUyNjcwtzUgTVhLnVW+xDhQS SE8sSc1OTS1ILYovKs1JLT7EyMTBKdXA6HG1OS7kcOa7dwd/3Fn8/nHjM3N9n8mcacsnb1f4 sL2Vv2JmSeZCq2Vy4fxbtY5ds0u4sPLvoeAvnr/j+ktLGz8IODCpuRZpFpxV+rZk1yLnupm9 c59yTNjz+aCBwv8bT0+dFYxKUFKwOF/i01udwLRlSi7Pz7qX/1tm5shUhf5L1Xz4/M9VXiWW 4oxEQy3mouJEAD+2GXLUAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsVy+t9jQd2pkc2BBvPnmFgsuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmDFl/T/WglaOig8/XzE3MN5l62Lk5JAQMJE4 dO0YK4QtJnHh3nqgOBeHkMB0RomVc/8zQji/GCUmHvjFCFLFJqAm8eXLYfYuRg4OEQF9ibYW DZAaZoFuRolHzXOZQWqEBYIlrj58xw5iswioSvz69RLM5hWwlLjePY0FwhaU+DH5HpjNLKAl sX7ncSYIW15i85q3zBAXKUjsOPsabK+IgJ5E47M/UPUiEvtevGOcwCgwC8moWUhGzUIyahaS lgWMLKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLzczcxgmP7mdQOxpUNFocYBTgYlXh4FVqaAoVY E8uKK3MPMUpwMCuJ8Lr9AArxpiRWVqUW5ccXleakFh9iTAb6dCKzlGhyPjDt5JXEGxqbmBlZ GplZGJmYm5MmrCTOe6DVOlBIID2xJDU7NbUgtQhmCxMHp1QDI5+PpF9VjFrop6PHtecauq88 99DsyeIl2sF8TFbXXzmmsNtYcD9ZqKWjEHr3QNOJ7ZI3jXVWWYTIcV/bcyPo+OeTGefkcwMC 4pdHPOacc9rp6NywG6uirr9M3bLFq9r78OJ5b/xXJwdXM5xvORPDzr4r+bLOheiYLEPJCFPv aX1y/q9PC742UWIpzkg01GIuKk4EAPzXmywxAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
Comments
Patch
diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c index 1e48686..c6573585 100644 --- a/drivers/rtc/rtc-jz4740.c +++ b/drivers/rtc/rtc-jz4740.c @@ -287,7 +287,6 @@ err_free_irq: err_unregister_rtc: rtc_device_unregister(rtc->rtc); err_iounmap: - platform_set_drvdata(pdev, NULL); iounmap(rtc->base); err_release_mem_region: release_mem_region(rtc->mem->start, resource_size(rtc->mem)); @@ -310,8 +309,6 @@ static int jz4740_rtc_remove(struct platform_device *pdev) kfree(rtc); - platform_set_drvdata(pdev, NULL); - return 0; }
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/rtc/rtc-jz4740.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)