From patchwork Fri May 3 06:24:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241153 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qc0-x23e.google.com (mail-qc0-x23e.google.com [IPv6:2607:f8b0:400d:c01::23e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 614AD2C00B1 for ; Fri, 3 May 2013 16:24:57 +1000 (EST) Received: by mail-qc0-f190.google.com with SMTP id j2sf367221qch.7 for ; Thu, 02 May 2013 23:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=bR8JkN30R2jnME3yfmSJaF4SWKQlDRQZ44lU8Not/gI=; b=jAcLWTJthZHc6XAaysDQ6CvjKzO+BRoXaeNWzWk/pJBIsbYgITG0/2gyQKTfegEIKU 6jAIf/Bp6CKfCIUEfxY4EAxpdd1BXG5eey29yA0o39ASckmkFzH9FJEmalhkhoQCoyaz CH29CrW62P53Tkrjlo3iLZXY4tCgKxKIN9UtQpQkbFQTaBFwm2Qz1FoJLmL7jgO0jOX1 raqSUi1weFnfEPechaw5v1niSIxsKSnGS5t5LC1RoXdKtMkDfimroqRZGfzKDz05sQR2 u5AJTAMCDhxkMOBrZl16Tp25fDuaynmd5Mv6vj7FHgai7oh7VNcE/AG9nwBe/S2gXm5N ujLg== X-Received: by 10.50.111.230 with SMTP id il6mr1407594igb.14.1367562294549; Thu, 02 May 2013 23:24:54 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.130.37 with SMTP id ob5ls231745igb.2.canary; Thu, 02 May 2013 23:24:54 -0700 (PDT) X-Received: by 10.68.108.165 with SMTP id hl5mr3128668pbb.4.1367562294143; Thu, 02 May 2013 23:24:54 -0700 (PDT) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id gi6si1693573pbc.2.2013.05.02.23.24.53 for ; Thu, 02 May 2013 23:24:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM7006MBLT7UZ00@mailout1.samsung.com> for rtc-linux@googlegroups.com; Fri, 03 May 2013 15:24:53 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 91.97.31024.43853815; Fri, 03 May 2013 15:24:52 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-0f-51835834c8e6 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 22.B9.01422.43853815; Fri, 03 May 2013 15:24:52 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM700M4CLTG1YY0@mmp2.samsung.com>; Fri, 03 May 2013 15:24:52 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, Jingoo Han Subject: [rtc-linux] [PATCH 05/42] rtc: rtc-at32ap700x: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:24:52 +0900 Message-id: <001301ce47c6$ebd1b950$c3752bf0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5Hxuh/KnvOERtGQZOPSGL/Y1aO2g== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsVy+t8zQ12TiOZAg87V2hZLLl5lt5izfg2b xeWFl1gtLu+aw2axv7OD0YHVY8/Ek2weJ2b8ZvHo27KK0WP6vJ9MHp83yQWwRnHZpKTmZJal FunbJXBlbG07zF7QIFSxaGsfYwPjZr4uRk4OCQETiQXXlrBB2GISF+6tB7K5OIQEljFKrOm6 zg5T1H7iBztEYjqjxJ+GTVBVvxglWt4/AqtiE1CT+PLlMJDNwSEioC/R1qIBUsMs0M0o8ah5 LjNIjbBAuMSkaQvA1rEIqEpM334HzOYVsJTYe3YpM4QtKPFj8j0WEJtZQEti/c7jTBC2vMTm NW+ZIS5SkNhx9jUjiC0ioCfx6sN+ZogaEYl9L94xgiyWEDjELtF+7TsrxDIBiW+TD7GAHCch ICux6QDUHEmJgytusExgFJuFZPUsJKtnIVk9C8mKBYwsqxhFUwuSC4qT0osM9YoTc4tL89L1 kvNzNzFCoq93B+PtA9aHGJOB1k9klhJNzgdGb15JvKGxmZGFqYmpsZG5pRlpwkrivGot1oFC AumJJanZqakFqUXxRaU5qcWHGJk4OKUaGLMjBD9ePLNkV0t2qdPxu20c7MlrbDbfWfTtjcSM +aapsy61bOpd9OYI7zxzxeStTHeXtUXJC33fcdxfbp3vF4W5DK/ees12j+SZZOD0LNFqiqZJ gfkFpzTe1vuPBWO0WIUynr4oL+OQu8t5/a/7SQY7ifbW0ti58ytTgq/8Til5btj9baqNlhJL cUaioRZzUXEiAEwozaPUAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsVy+t9jQV2TiOZAgzPb1S2WXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjWpgtMlITUxJ LVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB2q6kUJaYUwoUCkgs LlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxjzNjadpi9oEGoYtHWPsYGxs18XYycHBICJhLt J36wQ9hiEhfurWfrYuTiEBKYzijxp2ETlPOLUaLl/SOwKjYBNYkvXw4D2RwcIgL6Em0tGiA1 zALdjBKPmucyg9QIC4RLTJq2gA3EZhFQlZi+/Q6YzStgKbH37FJmCFtQ4sfkeywgNrOAlsT6 nceZIGx5ic1r3jJDXKQgsePsa0YQW0RAT+LVh/3MEDUiEvtevGOcwCgwC8moWUhGzUIyahaS lgWMLKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxgmP7mfQOxlUNFocYBTgYlXh4FVqaAoVY E8uKK3MPMUpwMCuJ8Lr9AArxpiRWVqUW5ccXleakFh9iTAb6dCKzlGhyPjDt5JXEGxqbmBlZ GplZGJmYm5MmrCTOe7DVOlBIID2xJDU7NbUgtQhmCxMHp1QDo/IG6YziqbNMtn+femnbPQXu sj1/cib8E2/dmrt68SOBIqHD580ecUzR3njkyJODXJu+XS+Y5XVoyU1dHQuff8wKV3Wn19V6 SYn86y2//dTy58F0hdRrXF+artm+jeqO1fiUY9y8bd6nrjlH3IwWW1U2GehliWyVFjzQIzCx bPGF1bGOuUq21kosxRmJhlrMRcWJAJgftOIxAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-at32ap700x.c | 20 +++++--------------- 1 files changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/rtc/rtc-at32ap700x.c b/drivers/rtc/rtc-at32ap700x.c index f47fbb5..4a5ccf1 100644 --- a/drivers/rtc/rtc-at32ap700x.c +++ b/drivers/rtc/rtc-at32ap700x.c @@ -212,23 +212,20 @@ static int __init at32_rtc_probe(struct platform_device *pdev) regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!regs) { dev_dbg(&pdev->dev, "no mmio resource defined\n"); - ret = -ENXIO; - goto out; + return -ENXIO; } irq = platform_get_irq(pdev, 0); if (irq <= 0) { dev_dbg(&pdev->dev, "could not get irq\n"); - ret = -ENXIO; - goto out; + return -ENXIO; } rtc->irq = irq; rtc->regs = devm_ioremap(&pdev->dev, regs->start, resource_size(regs)); if (!rtc->regs) { - ret = -ENOMEM; dev_dbg(&pdev->dev, "could not map I/O memory\n"); - goto out; + return -ENOMEM; } spin_lock_init(&rtc->lock); @@ -249,7 +246,7 @@ static int __init at32_rtc_probe(struct platform_device *pdev) "rtc", rtc); if (ret) { dev_dbg(&pdev->dev, "could not request irq %d\n", irq); - goto out; + return ret; } platform_set_drvdata(pdev, rtc); @@ -258,8 +255,7 @@ static int __init at32_rtc_probe(struct platform_device *pdev) &at32_rtc_ops, THIS_MODULE); if (IS_ERR(rtc->rtc)) { dev_dbg(&pdev->dev, "could not register rtc device\n"); - ret = PTR_ERR(rtc->rtc); - goto out; + return PTR_ERR(rtc->rtc); } device_init_wakeup(&pdev->dev, 1); @@ -268,18 +264,12 @@ static int __init at32_rtc_probe(struct platform_device *pdev) (unsigned long)rtc->regs, rtc->irq); return 0; - -out: - platform_set_drvdata(pdev, NULL); - return ret; } static int __exit at32_rtc_remove(struct platform_device *pdev) { device_init_wakeup(&pdev->dev, 0); - platform_set_drvdata(pdev, NULL); - return 0; }