diff mbox

[v4,09/12] toolchain/gcc: Only enable --with-float when it makes sense

Message ID 1367524293-32081-10-git-send-email-mjonker@synopsys.com
State Accepted
Headers show

Commit Message

Mischa Jonker May 2, 2013, 7:51 p.m. UTC
According to gcc/config.gcc, only ARM, MIPS and SPARC have the
"--with-float" option when configuring gcc.

Signed-off-by: Mischa Jonker <mjonker@synopsys.com>
---
 toolchain/gcc/gcc-uclibc-4.x.mk |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Comments

Peter Korsgaard May 4, 2013, 9:22 p.m. UTC | #1
>>>>> "Mischa" == Mischa Jonker <Mischa.Jonker@synopsys.com> writes:

 Mischa> According to gcc/config.gcc, only ARM, MIPS and SPARC have the
 Mischa> "--with-float" option when configuring gcc.

 Mischa> Signed-off-by: Mischa Jonker <mjonker@synopsys.com>
 Mischa> ---
 Mischa>  toolchain/gcc/gcc-uclibc-4.x.mk |    3 +++
 Mischa>  1 files changed, 3 insertions(+), 0 deletions(-)

 Mischa> diff --git a/toolchain/gcc/gcc-uclibc-4.x.mk b/toolchain/gcc/gcc-uclibc-4.x.mk
 Mischa> index 2993697..7b77fb0 100644
 Mischa> --- a/toolchain/gcc/gcc-uclibc-4.x.mk
 Mischa> +++ b/toolchain/gcc/gcc-uclibc-4.x.mk
 Mischa> @@ -65,7 +65,10 @@ endif
 
 Mischa>  # Determine soft-float options
 Mischa>  ifeq ($(BR2_SOFT_FLOAT),y)
 Mischa> +# only mips*-*-*, arm*-*-* and sparc*-*-* accept --with-float
 Mischa> +ifeq ($(BR2_arm)$(BR2_armeb)$(BR2_mips)$(BR2_mipsel)$(BR2_sparc)$(BR2_mips64)$(BR2_mips64el),y)

sparc should come after all the mips* options. Committed with that
fixed, thanks.
diff mbox

Patch

diff --git a/toolchain/gcc/gcc-uclibc-4.x.mk b/toolchain/gcc/gcc-uclibc-4.x.mk
index 2993697..7b77fb0 100644
--- a/toolchain/gcc/gcc-uclibc-4.x.mk
+++ b/toolchain/gcc/gcc-uclibc-4.x.mk
@@ -65,7 +65,10 @@  endif
 
 # Determine soft-float options
 ifeq ($(BR2_SOFT_FLOAT),y)
+# only mips*-*-*, arm*-*-* and sparc*-*-* accept --with-float
+ifeq ($(BR2_arm)$(BR2_armeb)$(BR2_mips)$(BR2_mipsel)$(BR2_sparc)$(BR2_mips64)$(BR2_mips64el),y)
 SOFT_FLOAT_CONFIG_OPTION:=--with-float=soft
+endif
 ifeq ($(BR2_arm)$(BR2_armeb),y) # only set float-abi for arm
 TARGET_SOFT_FLOAT:=-mfloat-abi=soft
 else