From patchwork Thu May 2 17:20:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 241041 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4C0122C00F2 for ; Fri, 3 May 2013 03:21:33 +1000 (EST) Received: from localhost ([::1]:54836 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXxCF-0002SI-A1 for incoming@patchwork.ozlabs.org; Thu, 02 May 2013 13:21:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXxBr-0002LU-MH for qemu-devel@nongnu.org; Thu, 02 May 2013 13:21:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXxBo-00066c-VY for qemu-devel@nongnu.org; Thu, 02 May 2013 13:21:07 -0400 Received: from mail-gg0-x232.google.com ([2607:f8b0:4002:c02::232]:56043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXxBo-00066V-Q3 for qemu-devel@nongnu.org; Thu, 02 May 2013 13:21:04 -0400 Received: by mail-gg0-f178.google.com with SMTP id l2so121549ggn.9 for ; Thu, 02 May 2013 10:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=mjsTGsg6KwKYwWIDM6VBiSblz5oymhWNYwkK281Psuw=; b=KPe7Pzy5ctpsolyNfVJAHFNrZ0si7EoeJAKizeSVFtgVzo9iFwv2aPppUwALN0/Hl8 b4HGK1Iv4UZVw3geY9xYVz4CW7EekUhLDrkZwUphC4gd8JWzY5i/+5WeyqDijewBAC/f xiQF0fiRXRIX7B7a2pBz8wysS+IQgUZEO308cT8sDm2qinntDQALzkh8RC37F3QFW5sL lBTsdvIgUUG/x1AjdJazlcipdQxitE5eb9nR5KG6CEd3YIcZCQZ4i/wSrTgGN1lESuG2 vUGsXrUl9iCp/ff3YsF5XW2h85L3kel4PioKFaigqX0VonkfwThNlWxb5mwjp8fy7XtF +eDw== X-Received: by 10.236.34.130 with SMTP id s2mr5612036yha.98.1367515264440; Thu, 02 May 2013 10:21:04 -0700 (PDT) Received: from yakj.usersys.redhat.com (93-34-176-20.ip50.fastwebnet.it. [93.34.176.20]) by mx.google.com with ESMTPSA id o49sm14340243yhj.3.2013.05.02.10.21.01 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 02 May 2013 10:21:03 -0700 (PDT) Message-ID: <5182A07A.30705@redhat.com> Date: Thu, 02 May 2013 19:20:58 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Claudio Bley References: <87li8nn8xy.wl%cbley@av-test.de> <517E97BD.7050309@redhat.com> <874neop42m.wl%cbley@av-test.de> In-Reply-To: <874neop42m.wl%cbley@av-test.de> X-Enigmail-Version: 1.5.1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4002:c02::232 Cc: Jan Kiszka , qemu-devel@nongnu.org Subject: Re: [Qemu-devel] lsi_soft_reset: Assertion `!s->current' failed with Windows XP setup X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Il 30/04/2013 14:59, Claudio Bley ha scritto: > At Mon, 29 Apr 2013 17:54:37 +0200, > Paolo Bonzini wrote: >> >> Il 12/04/2013 16:02, Claudio Bley ha scritto: >>> Hi. >>> >>> I'm using the latest qemu release 1.4.0 and libvirt 1.0.4. >>> >>> The host system is a Ubuntu 12.04 LTS system, Intel Xeon processor, >>> 4GB RAM. >>> >>> When trying to install Windows XP I constantly receive this error >>> (usually right before the graphical Setup is started). Once, I've seen >>> this error too: >>> >>> hw/lsi53c895a.c:351: lsi_soft_reset: Assertion `((&s->queue)->tqh_first == ((void *)0))' failed. >>> >>> I found the thread here >>> http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg00518.html but >>> it didn't led me nowhere. >>> >>> I recompiled with DEBUG_SCSI and DEBUG_LSI enabled. Here's the command >>> libvirt put together and the last few lines of output. I can provide >>> the complete log if you need it. >> >> Hi, sorry---I just read this now. >> >> Can you please try the patches at >> http://cache.gmane.org//gmane/comp/emulators/qemu/208057-001.bin? > > I gave it a shot and this fixed the bug for me. > > I've applied the patches to git tag v1.4.1 with minor modifications: > > - skipped patch 1 and 2 since they already had been applied upstream > in the meantime, AFAICS > > - s/vists/visits/ in subject line of patch 3 > > - updated patch 3 and 4 in order to adjust for moved-around files and > some code changes since 1.3.0 > > Thanks! > > Here are the updated patches: Thanks. These will have to wait for 1.6 though. This should work for all current releases. Paolo diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index c601b29..0648c77 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -348,6 +348,7 @@ static void lsi_soft_reset(LSIState *s) s->sbc = 0; s->csbc = 0; s->sbr = 0; + qbus_reset_all(&s->bus.qbus); assert(QTAILQ_EMPTY(&s->queue)); assert(!s->current); }