From patchwork Thu May 2 15:05:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 241030 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A98552C00A1 for ; Fri, 3 May 2013 01:05:59 +1000 (EST) Received: from localhost ([::1]:45191 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXv53-0008Mg-RA for incoming@patchwork.ozlabs.org; Thu, 02 May 2013 11:05:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXv4Z-0008Cu-PU for qemu-devel@nongnu.org; Thu, 02 May 2013 11:05:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXv4X-0002VH-2W for qemu-devel@nongnu.org; Thu, 02 May 2013 11:05:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXv4W-0002VB-QI for qemu-devel@nongnu.org; Thu, 02 May 2013 11:05:25 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r42F5OK1008140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 2 May 2013 11:05:24 -0400 Received: from localhost (ovpn-112-17.ams2.redhat.com [10.36.112.17]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r42F5NRh004496; Thu, 2 May 2013 11:05:23 -0400 Date: Thu, 2 May 2013 17:05:22 +0200 From: Stefan Hajnoczi To: Fam Zheng Message-ID: <20130502150522.GB989@stefanha-thinkpad.redhat.com> References: <1367461527-9789-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1367461527-9789-1-git-send-email-famz@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id r42F5OK1008140 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH v5 0/6] vmdk: zeroed-grain GTE support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Thu, May 02, 2013 at 10:25:21AM +0800, Fam Zheng wrote: > Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1]. > > [1] Virtual Disk Format 5.0 - VMware, > http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk > > Changes since v4: > - 6/6: Correct endianess: *m_data->l2_cache_entry = offset; > > > Changes since v3: > - 5/6: Remove tmp > - 6/6: Update L2 Cache > Remove redundant assignment to m_data > Simplify l2_offset assignment to m_data > Fix m_data.offset endian. > > Changes since v2: > - all: Added 5/6 (vmdk: store fields of VmdkMetaData in cpu endian) > - 6/6: Avoid side-effect of vmdk_L2update. > Change function comment to gtkdoc stype. > Fix VMDK4_FLAG_ZG. > > Changes since v1: > - all: fix From: field > - 1/5: squash one line of ret code macro change from 2/5 > - 2/5: change VMDK4_FLAG_ZG to VMDK4_FLAG_ZERO_GRAIN > - 3/5: move BLOCK_OPT_ZEROED_GRAIN defination from block_int.h to vmdk.c > - 5/5: fix metadata update issue, unit test with cases 033 034 > > Fam Zheng (6): > vmdk: named return code. > vmdk: add support for “zeroed‐grain” GTE > vmdk: Add option to create zeroed-grain image > vmdk: change magic number to macro > vmdk: store fields of VmdkMetaData in cpu endian > vmdk: add bdrv_co_write_zeroes > > block/vmdk.c | 208 +++++++++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 145 insertions(+), 63 deletions(-) Patches look fine now. The new option breaks qemu-iotests though: $ cd tests/qemu-iotests $ QEMU_PROG=$HOME/qemu/x86_64-softmmu/qemu-system-x86_64 \ PATH=$HOME/qemu:$PATH \ ./check -vmdk [...] 001 1s ... - output mismatch (see 001.out.bad) do this for other options. Please send a patch to fix qemu-iotests so that I can apply this series. Thanks, Stefan --- 001.out 2013-04-04 13:26:21.394050764 +0200 +++ 001.out.bad 2013-05-02 16:52:55.685803943 +0200 @@ -1,5 +1,5 @@ QA output created by 001 -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 zeroed_grain=off You'll need to filter out zeroed_grain from qemu-img output. We already