Patchwork ARM: sun4i: cubieboard: Enable the i2c controllers

login
register
mail settings
Submitter Emilio López
Date May 2, 2013, 12:37 p.m.
Message ID <1367498266-1246-1-git-send-email-emilio@elopez.com.ar>
Download mbox | patch
Permalink /patch/240952/
State New
Headers show

Comments

Emilio López - May 2, 2013, 12:37 p.m.
The Cubieboard makes use of the first two i2c controllers found on the
Allwinner A10; i2c-0 is used internally for the PMIC, while i2c-1
is exposed on the board headers. This patch enables them in the device
tree.

Signed-off-by: Emilio López <emilio@elopez.com.ar>
---
 arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Arnd Bergmann - May 2, 2013, 1:43 p.m.
On Thursday 02 May 2013 09:37:46 Emilio López wrote:
> The Cubieboard makes use of the first two i2c controllers found on the
> Allwinner A10; i2c-0 is used internally for the PMIC, while i2c-1
> is exposed on the board headers. This patch enables them in the device
> tree.
> 
> Signed-off-by: Emilio López <emilio@elopez.com.ar>

Shouldn't you list the attached devices in the same patch?

What is the point of enabling the I2C bus if there are no devices
to be found?

	Arnd
Emilio López - May 2, 2013, 2:03 p.m.
Hi Arnd,

El 02/05/13 10:43, Arnd Bergmann escribió:
> On Thursday 02 May 2013 09:37:46 Emilio López wrote:
>> The Cubieboard makes use of the first two i2c controllers found on the
>> Allwinner A10; i2c-0 is used internally for the PMIC, while i2c-1
>> is exposed on the board headers. This patch enables them in the device
>> tree.
>>
>> Signed-off-by: Emilio López <emilio@elopez.com.ar>
> 
> Shouldn't you list the attached devices in the same patch?
> 
> What is the point of enabling the I2C bus if there are no devices
> to be found?

This is complementary to the series titled "Add I2C support for
Allwinner SoCs" sent by Maxime today. We have no driver for the AXP20
PMIC yet, and the external header is left for the user to connect, so I
haven't added any device. This is still useful though, as it lets you
use I2C from userspace (i2cdetect, i2cdump, etc).

Regards,

Emilio
Arnd Bergmann - May 2, 2013, 3:06 p.m.
On Thursday 02 May 2013, Emilio López wrote:
> This is complementary to the series titled "Add I2C support for
> Allwinner SoCs" sent by Maxime today. We have no driver for the AXP20
> PMIC yet, and the external header is left for the user to connect, so I
> haven't added any device. This is still useful though, as it lets you
> use I2C from userspace (i2cdetect, i2cdump, etc).

Right, that makes sense. Thanks,

	Arnd
Maxime Ripard - May 3, 2013, 2:01 p.m.
Hi Emilio,

Le 02/05/2013 14:37, Emilio López a écrit :
> The Cubieboard makes use of the first two i2c controllers found on the
> Allwinner A10; i2c-0 is used internally for the PMIC, while i2c-1
> is exposed on the board headers. This patch enables them in the device
> tree.
> 
> Signed-off-by: Emilio López <emilio@elopez.com.ar>

Thanks for this patch.

I'll merge it in my i2c patchset, so that every thing stays together.

Maxime

Patch

diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
index b70fe0d..0e22a28 100644
--- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
+++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts
@@ -41,6 +41,18 @@ 
 			pinctrl-0 = <&uart0_pins_a>;
 			status = "okay";
 		};
+
+		i2c0: i2c@01c2ac00 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c0_pins_a>;
+			status = "okay";
+		};
+
+		i2c1: i2c@01c2b000 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c1_pins_a>;
+			status = "okay";
+		};
 	};
 
 	leds {