Patchwork nand_base: fix for ONFI chips that do not support GET/SET FEATURES

login
register
mail settings
Submitter David Mosberger-Tang
Date May 2, 2013, 2:34 a.m.
Message ID <CACwUX0M_CGStWih0qcR_8na-yMmvHrAaHxpYe4Y_Q5mx+jno+g@mail.gmail.com>
Download mbox | patch
Permalink /patch/240887/
State New
Headers show

Comments

David Mosberger-Tang - May 2, 2013, 2:34 a.m.
Sure.  C99-style comments replaced with old-style comments...

  --david


On Wed, May 1, 2013 at 8:28 PM, Huang Shijie <b32955@freescale.com> wrote:
> 于 2013年05月01日 07:39, David Mosberger-Tang 写道:
>
>> The attached patch is relative to linux-mtd.  It fixes a problem with
>> NAND-chips that are ONFI-compliant but don't support the SET/GET
>> FEATURES commands (such as Spansion S34Mx).
>>
> good catch.
>
> but could you check your patch with scripts/checkpatch.pl , and then
> send out this patch?
>
> thanks
> Huang Shijie
>
>
mtd: nand_base: Only use GET/SET FEATURES command on chips that support them.

Spansion's S34MLx chips support ONFI but not the GET/SET FEATURES calls.

Signed-off-by: David Mosberger <dmosberger@gmail.com>
Huang Shijie - May 2, 2013, 2:41 a.m.
于 2013年05月02日 10:34, David Mosberger-Tang 写道:
> +	    !(le16_to_cpu(chip->onfi_params.opt_cmd) & 4))
it's better to add a macro to replace the hardcore '4', such as

#define ONFI_OPT_CMD_SET_GET_FEAT (1 << 2)

Just a suggestion. :)

thanks
Huang Shijie

Patch

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index dfcd0a5..13c8043 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2720,7 +2720,9 @@  static int nand_onfi_set_features(struct mtd_info *mtd, struct nand_chip *chip,
 {
 	int status;
 
-	if (!chip->onfi_version)
+	if (!chip->onfi_version ||
+	    /* supports GET/SET FEATURES? */
+	    !(le16_to_cpu(chip->onfi_params.opt_cmd) & 4))
 		return -EINVAL;
 
 	chip->cmdfunc(mtd, NAND_CMD_SET_FEATURES, addr, -1);
@@ -2741,7 +2743,9 @@  static int nand_onfi_set_features(struct mtd_info *mtd, struct nand_chip *chip,
 static int nand_onfi_get_features(struct mtd_info *mtd, struct nand_chip *chip,
 			int addr, uint8_t *subfeature_param)
 {
-	if (!chip->onfi_version)
+	if (!chip->onfi_version ||
+	    /* supports GET/SET FEATURES? */
+	    !(le16_to_cpu(chip->onfi_params.opt_cmd) & 4))
 		return -EINVAL;
 
 	/* clear the sub feature parameters */