Patchwork Fix node weight updates during ipa-cp (issue7812053)

login
register
mail settings
Submitter H.J. Lu
Date April 30, 2013, 3:50 p.m.
Message ID <CAMe9rOod5eKXfnttc1LM64y69fG5QRSF-1fP3GOy8+Nmi2E3WQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/240653/
State New
Headers show

Comments

H.J. Lu - April 30, 2013, 3:50 p.m.
On Tue, Apr 30, 2013 at 7:02 AM, Teresa Johnson <tejohnson@google.com> wrote:
> On Mon, Apr 29, 2013 at 12:35 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Mon, Apr 29, 2013 at 10:31 AM, Teresa Johnson <tejohnson@google.com> wrote:
>>> FYI, Fixed in r198416.
>>>
>>> Thanks,
>>> Teresa
>>>
>>
>> I noticed that sometimes GCC generates:
>>
>> _8 = memcpy (ret_6, s_2(D), len_4);
>> _8 = memcpy (ret_6, s_2(D), len_4);
>> memcpy (_17, buffer_12(D), add_16);
>> memcpy (_17, buffer_12(D), add_16);
>> memcpy (_25, _28, _27);
>> memcpy (_25, _28, _27);
>> memcpy (_39, buffer_2, len_4);
>> memcpy (_39, buffer_2, len_4);
>> memcpy (_16, &fillbuf, pad_1);
>> memcpy (_16, &fillbuf, pad_1);
>
> I am getting this too with a profiledbootstrap with LTO. However, this
> isn't due to my changes. I had confirmed that after reverting my
> changes (r197595 and now the follow-on fix r198416) this problem still
> occurs.
>
> Teresa

There is a strayed debug_gimple_stmt.  I am checking in this
patch to fix it.

--
H.J.
---
       else

Patch

diff --git a/gcc/value-prof.c b/gcc/value-prof.c
index 3348d7f..b665b1c 100644
--- a/gcc/value-prof.c
+++ b/gcc/value-prof.c
@@ -416,7 +416,6 @@  stream_in_histogram_value (struct lto_input_block
*ib, gimple stmt)
       new_val->n_counters = ncounters;
       for (i = 0; i < ncounters; i++)
     new_val->hvalue.counters[i] = streamer_read_gcov_count (ib);
-      debug_gimple_stmt (stmt);
       if (!next_p)
     gimple_add_histogram_value (cfun, stmt, new_val);