| Message ID | 1367307199-10577-1-git-send-email-gerlando.falauto@keymile.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 30-04-2013 11:33, Gerlando Falauto wrote: > Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com> > --- > Changes from v2: > * Split cosmetic from functional changes > net/tipc/bcast.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c > index 2655c9f..8438e01 100644 > --- a/net/tipc/bcast.c > +++ b/net/tipc/bcast.c > @@ -584,8 +584,7 @@ static int tipc_bcbearer_send(struct sk_buff *buf, > { > int bp_index; > > - /* > - * Prepare broadcast link message for reliable transmission, > + /* Prepare broadcast link message for reliable transmission, > * if first time trying to send it; > * preparation is skipped for broadcast link protocol messages > * since they are sent in an unreliable manner and don't need it > @@ -613,11 +612,12 @@ static int tipc_bcbearer_send(struct sk_buff *buf, > struct tipc_bearer *s = bcbearer->bpairs[bp_index].secondary; > > if (!p) > - break; /* no more bearers to try */ > + break; /* No more bearers to try */ > > - tipc_nmap_diff(&bcbearer->remains, &p->nodes, &bcbearer->remains_new); > + tipc_nmap_diff(&bcbearer->remains, &p->nodes, > + &bcbearer->remains_new); It apeears you nopt only cleaning up comments in this patch but you don't mention this change in the changelog... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Date: Tue, 30 Apr 2013 15:54:01 +0400 > It apeears you nopt only cleaning up comments in this patch but you > don't mention this change in the changelog... Agreed. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sergei, On 04/30/2013 01:54 PM, Sergei Shtylyov wrote: > Hello. > > On 30-04-2013 11:33, Gerlando Falauto wrote: > >> Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com> >> --- >> Changes from v2: >> * Split cosmetic from functional changes > >> net/tipc/bcast.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) > >> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c >> index 2655c9f..8438e01 100644 >> --- a/net/tipc/bcast.c >> +++ b/net/tipc/bcast.c >> @@ -584,8 +584,7 @@ static int tipc_bcbearer_send(struct sk_buff *buf, >> { >> int bp_index; >> >> - /* >> - * Prepare broadcast link message for reliable transmission, >> + /* Prepare broadcast link message for reliable transmission, >> * if first time trying to send it; >> * preparation is skipped for broadcast link protocol messages >> * since they are sent in an unreliable manner and don't need it >> @@ -613,11 +612,12 @@ static int tipc_bcbearer_send(struct sk_buff *buf, >> struct tipc_bearer *s = bcbearer->bpairs[bp_index].secondary; >> >> if (!p) >> - break; /* no more bearers to try */ >> + break; /* No more bearers to try */ >> >> - tipc_nmap_diff(&bcbearer->remains, &p->nodes, &bcbearer->remains_new); >> + tipc_nmap_diff(&bcbearer->remains, &p->nodes, >> + &bcbearer->remains_new); > > It apeears you nopt only cleaning up comments in this patch but you don't > mention this change in the changelog... That's just adding a line break to split a long line. Come on, seriously, is that *really* worth mentioning? How about "tipc: cosmetic: clean up comments and break a long line"? Thanks, Gerlando -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 01-05-2013 11:37, Gerlando Falauto wrote: >>> Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com> >>> --- >>> Changes from v2: >>> * Split cosmetic from functional changes >>> net/tipc/bcast.c | 13 +++++++------ >>> 1 file changed, 7 insertions(+), 6 deletions(-) >>> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c >>> index 2655c9f..8438e01 100644 >>> --- a/net/tipc/bcast.c >>> +++ b/net/tipc/bcast.c >>> @@ -584,8 +584,7 @@ static int tipc_bcbearer_send(struct sk_buff *buf, >>> { >>> int bp_index; >>> >>> - /* >>> - * Prepare broadcast link message for reliable transmission, >>> + /* Prepare broadcast link message for reliable transmission, >>> * if first time trying to send it; >>> * preparation is skipped for broadcast link protocol messages >>> * since they are sent in an unreliable manner and don't need it >>> @@ -613,11 +612,12 @@ static int tipc_bcbearer_send(struct sk_buff *buf, >>> struct tipc_bearer *s = bcbearer->bpairs[bp_index].secondary; >>> >>> if (!p) >>> - break; /* no more bearers to try */ >>> + break; /* No more bearers to try */ >>> >>> - tipc_nmap_diff(&bcbearer->remains, &p->nodes, >>> &bcbearer->remains_new); >>> + tipc_nmap_diff(&bcbearer->remains, &p->nodes, >>> + &bcbearer->remains_new); >> It apeears you nopt only cleaning up comments in this patch but you don't >> mention this change in the changelog... > That's just adding a line break to split a long line. > Come on, seriously, is that *really* worth mentioning? Yes, it is. Otherwise it's an unrelated change. > How about "tipc: cosmetic: clean up comments and break a long line"? Sounds good. > Thanks, > Gerlando WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index 2655c9f..8438e01 100644 --- a/net/tipc/bcast.c +++ b/net/tipc/bcast.c @@ -584,8 +584,7 @@ static int tipc_bcbearer_send(struct sk_buff *buf, { int bp_index; - /* - * Prepare broadcast link message for reliable transmission, + /* Prepare broadcast link message for reliable transmission, * if first time trying to send it; * preparation is skipped for broadcast link protocol messages * since they are sent in an unreliable manner and don't need it @@ -613,11 +612,12 @@ static int tipc_bcbearer_send(struct sk_buff *buf, struct tipc_bearer *s = bcbearer->bpairs[bp_index].secondary; if (!p) - break; /* no more bearers to try */ + break; /* No more bearers to try */ - tipc_nmap_diff(&bcbearer->remains, &p->nodes, &bcbearer->remains_new); + tipc_nmap_diff(&bcbearer->remains, &p->nodes, + &bcbearer->remains_new); if (bcbearer->remains_new.count == bcbearer->remains.count) - continue; /* bearer pair doesn't add anything */ + continue; /* Nothing added by bearer pair */ if (!tipc_bearer_blocked(p)) tipc_bearer_send(p, buf, &p->media->bcast_addr); @@ -628,13 +628,14 @@ static int tipc_bcbearer_send(struct sk_buff *buf, /* unable to send on either bearer */ continue; + /* Swap bearers for next packet */ if (s) { bcbearer->bpairs[bp_index].primary = s; bcbearer->bpairs[bp_index].secondary = p; } if (bcbearer->remains_new.count == 0) - break; /* all targets reached */ + break; /* All targets reached */ bcbearer->remains = bcbearer->remains_new; }
Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com> --- Changes from v2: * Split cosmetic from functional changes net/tipc/bcast.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)