From patchwork Mon Apr 29 13:33:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dunrong huang X-Patchwork-Id: 240372 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3EE402C04AF for ; Mon, 29 Apr 2013 23:46:32 +1000 (EST) Received: from localhost ([::1]:42909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWoPW-0008HV-GT for incoming@patchwork.ozlabs.org; Mon, 29 Apr 2013 09:46:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWoPD-0008FQ-Cg for qemu-devel@nongnu.org; Mon, 29 Apr 2013 09:46:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWoPB-0005Pd-No for qemu-devel@nongnu.org; Mon, 29 Apr 2013 09:46:11 -0400 Received: from mail-qe0-f47.google.com ([209.85.128.47]:56330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWoD3-0000yX-Kq for qemu-devel@nongnu.org; Mon, 29 Apr 2013 09:33:37 -0400 Received: by mail-qe0-f47.google.com with SMTP id x7so3218068qeu.34 for ; Mon, 29 Apr 2013 06:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=gylE8qr27Oc2QdJtefaJ/8a+nyJ4gfavETZRKB+KbDs=; b=z3ISHBkmxGFh/vtH7iMss/EAIKZ9eHroLpjyQEgXJOqgGaMc2RxCtc974lW7+XRqZc FJ4tzNXYTutvTSpJIOHMMZU09+TeTeGJEqLHvOIc8C1pe8YG5LFp2PCN63VfYjomaJi3 UEQjuCDVSYs6QEvAfQ43BdvmCX3TbYSYVO/le/7CF3VYRjk6FyGmpWF9BwR4n2Hrllxh GQr5j6GWKSwjB16F5kJ4NLIWGpK8FOs/3u1LraSrPtPxdlJJ0+fQrrfK7CCrHf2uytD4 xMXFvNVAQ857FGzFuVL/IGSV3muU2/4pqesNj9A7my43BiyUhJZQuqKeVcObrCsfdYz9 fv+A== MIME-Version: 1.0 X-Received: by 10.224.80.70 with SMTP id s6mr8429313qak.27.1367242417206; Mon, 29 Apr 2013 06:33:37 -0700 (PDT) Received: by 10.49.38.9 with HTTP; Mon, 29 Apr 2013 06:33:37 -0700 (PDT) In-Reply-To: <517E2D17.4020401@redhat.com> References: <1367172276-23293-1-git-send-email-riegamaths@gmail.com> <517E2D17.4020401@redhat.com> Date: Mon, 29 Apr 2013 21:33:37 +0800 Message-ID: From: Dunrong Huang To: Paolo Bonzini X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.128.47 Cc: Blue Swirl , Peter Crosthwaite , qemu-devel Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix build breakage X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Mon, Apr 29, 2013 at 4:19 PM, Paolo Bonzini wrote: > Il 28/04/2013 20:04, Dunrong Huang ha scritto: > > The following error occurs when building dtc module: > > > > CHK version_gen.h > > CC libfdt/fdt.o > > cc1: error: dtc: No such file or directory [-Werror] > > cc1: all warnings being treated as errors > > make[1]: *** [libfdt/fdt.o] Error 1 > > make: *** [subdir-dtc] Error 2 > > > > In rules.mak, "-I$( > building submodule dct. Due to the using of "-Wmissing-include-dirs, > > a warning would be rarsed. To avoid it, use dtc as the first prerequisite > > so that "$(^D)" was expanded to "." > > > > Cc: Peter Crosthwaite > > Cc: Blue Swirl > > Signed-off-by: Dunrong Huang > > --- > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index 8aca92f..64b0b1b 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -148,7 +148,7 @@ $(SRC_PATH)/pixman/configure: > > DTC_MAKE_ARGS=-I$(SRC_PATH)/dtc VPATH=$(SRC_PATH)/dtc -C dtc V="$(V)" > LIBFDT_srcdir=$(SRC_PATH)/dtc/libfdt > > DTC_CFLAGS=$(CFLAGS) $(QEMU_CFLAGS) -I$(BUILD_DIR)/dtc > -I$(SRC_PATH)/dtc -I$(SRC_PATH)/dtc/libfdt > > > > -subdir-dtc:dtc/libfdt dtc/tests > > +subdir-dtc:dtc dtc/libfdt dtc/tests > > $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) > CFLAGS="$(DTC_CFLAGS)" LDFLAGS="$(LDFLAGS)" ARFLAGS="$(ARFLAGS)" CC="$(CC)" > AR="$(AR)" LD="$(LD)" $(SUBDIR_MAKEFLAGS) libfdt/libfdt.a,) > > > > dtc/%: > > > > Does it work if the "-I$( of QEMU_CFLAGS? > Yes, this way works for me. > > Paolo > diff --git a/rules.mak b/rules.mak index 292a422..2572070 100644 --- a/rules.mak +++ b/rules.mak @@ -15,7 +15,7 @@ MAKEFLAGS += -rR QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d # Same as -I$(SRC_PATH) -I., but for the nested source/object directories -QEMU_CFLAGS += -I$(