Patchwork [PULL,1.5,v6,0/4] fix win32 compilation

login
register
mail settings
Submitter Paolo Bonzini
Date April 29, 2013, 10:11 a.m.
Message ID <1367230284-24612-1-git-send-email-pbonzini@redhat.com>
Download mbox
Permalink /patch/240353/
State New
Headers show

Pull-request

git://github.com/bonzini/qemu.git migration-writev

Comments

Paolo Bonzini - April 29, 2013, 10:11 a.m.
Here is a fix for the Win32 compilation problem that Blue reported,
and another two nits I found while testing.  After these patches, a
cross libtool is not needed anymore to build on Win32.

The following changes since commit 75f6e8b0f121beeee6a95eb9e35d88ec1f01824f:

  virtio-rng-s390: add properties. (2013-04-26 20:18:25 +0200)

are available in the git repository at:

  git://github.com/bonzini/qemu.git migration-writev

for you to fetch changes up to 9adea5f7f7a23ef4a1231289a36a94c52347b142:

  win32: add readv/writev emulation (2013-04-29 10:52:36 +0200)

v5->v6: just include config-host.h in osdep.h [Peter]

----------------------------------------------------------------
Paolo Bonzini (4):
      win32: add generic RC rules to rules.mak
      win32: move Makefile dependencies on version-obj-y to rules.mak
      win32: generate console executable again
      win32: add readv/writev emulation

 Makefile              |  5 +----
 Makefile.target       |  2 +-
 include/qemu-common.h | 22 ++--------------------
 include/qemu/osdep.h  | 17 +++++++++++++++++
 rules.mak             |  7 +++++++
 util/iov.c            |  2 +-
 util/osdep.c          | 43 +++++++++++++++++++++++++++++++++++++++++++
 7 files changed, 72 insertions(+), 26 deletions(-)
Stefan Weil - May 3, 2013, 5:04 p.m.
Am 29.04.2013 12:11, schrieb Paolo Bonzini:
> Here is a fix for the Win32 compilation problem that Blue reported,
> and another two nits I found while testing.  After these patches, a
> cross libtool is not needed anymore to build on Win32.
>
> The following changes since commit 75f6e8b0f121beeee6a95eb9e35d88ec1f01824f:
>
>   virtio-rng-s390: add properties. (2013-04-26 20:18:25 +0200)
>
> are available in the git repository at:
>
>   git://github.com/bonzini/qemu.git migration-writev
>
> for you to fetch changes up to 9adea5f7f7a23ef4a1231289a36a94c52347b142:
>
>   win32: add readv/writev emulation (2013-04-29 10:52:36 +0200)
>
> v5->v6: just include config-host.h in osdep.h [Peter]
>
> ----------------------------------------------------------------
> Paolo Bonzini (4):
>       win32: add generic RC rules to rules.mak
>       win32: move Makefile dependencies on version-obj-y to rules.mak
>       win32: generate console executable again
>       win32: add readv/writev emulation
>
>  Makefile              |  5 +----
>  Makefile.target       |  2 +-
>  include/qemu-common.h | 22 ++--------------------
>  include/qemu/osdep.h  | 17 +++++++++++++++++
>  rules.mak             |  7 +++++++
>  util/iov.c            |  2 +-
>  util/osdep.c          | 43 +++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 72 insertions(+), 26 deletions(-)


Hi Paolo,

these patches need to be rebased for the latest QEMU.
Could you please send an update?

Anthony, the patches fix the currently broken build for
w32/w64 hosts, so please apply them soon when they
are available.

Thanks,
Stefan
Anthony Liguori - May 3, 2013, 6:54 p.m.
Stefan Weil <sw@weilnetz.de> writes:

> Am 29.04.2013 12:11, schrieb Paolo Bonzini:
>> Here is a fix for the Win32 compilation problem that Blue reported,
>> and another two nits I found while testing.  After these patches, a
>> cross libtool is not needed anymore to build on Win32.
>>
>> The following changes since commit 75f6e8b0f121beeee6a95eb9e35d88ec1f01824f:
>>
>>   virtio-rng-s390: add properties. (2013-04-26 20:18:25 +0200)
>>
>> are available in the git repository at:
>>
>>   git://github.com/bonzini/qemu.git migration-writev
>>
>> for you to fetch changes up to 9adea5f7f7a23ef4a1231289a36a94c52347b142:
>>
>>   win32: add readv/writev emulation (2013-04-29 10:52:36 +0200)
>>
>> v5->v6: just include config-host.h in osdep.h [Peter]
>>
>> ----------------------------------------------------------------
>> Paolo Bonzini (4):
>>       win32: add generic RC rules to rules.mak
>>       win32: move Makefile dependencies on version-obj-y to rules.mak
>>       win32: generate console executable again
>>       win32: add readv/writev emulation
>>
>>  Makefile              |  5 +----
>>  Makefile.target       |  2 +-
>>  include/qemu-common.h | 22 ++--------------------
>>  include/qemu/osdep.h  | 17 +++++++++++++++++
>>  rules.mak             |  7 +++++++
>>  util/iov.c            |  2 +-
>>  util/osdep.c          | 43 +++++++++++++++++++++++++++++++++++++++++++
>>  7 files changed, 72 insertions(+), 26 deletions(-)
>
>
> Hi Paolo,
>
> these patches need to be rebased for the latest QEMU.
> Could you please send an update?

This pull request was already merged.

commit b48df71c916478ff658d143d0742e85c78348fad
Merge: 45dddd9 9adea5f
Author: Anthony Liguori <aliguori@us.ibm.com>
Date:   Mon Apr 29 08:26:47 2013 -0500

    Merge remote-tracking branch 'bonzini/migration-writev' into staging
    
    # By Paolo Bonzini
    # Via Paolo Bonzini
    * bonzini/migration-writev:
      win32: add readv/writev emulation
      win32: generate console executable again
      win32: move Makefile dependencies on version-obj-y to rules.mak
      win32: add generic RC rules to rules.mak
    
    Message-id: 1367230284-24612-1-git-send-email-pbonzini@redhat.com
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

>
> Anthony, the patches fix the currently broken build for
> w32/w64 hosts, so please apply them soon when they
> are available.
>
> Thanks,
> Stefan