Patchwork [1/2] acpi: s3: increase delays to match user scanerio and to reduce false non-firmware-related failures.

login
register
mail settings
Submitter Alex Hung
Date April 29, 2013, 7:31 a.m.
Message ID <1367220676-940-2-git-send-email-alex.hung@canonical.com>
Download mbox | patch
Permalink /patch/240330/
State Rejected
Headers show

Comments

Alex Hung - April 29, 2013, 7:31 a.m.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/s3/s3.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Keng-Yu Lin - May 20, 2013, 8:03 a.m.
Do we have an example of the "scenario" ?

On Mon, Apr 29, 2013 at 3:31 PM, Alex Hung <alex.hung@canonical.com> wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/s3/s3.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c
> index ae89423..f544f03 100644
> --- a/src/acpi/s3/s3.c
> +++ b/src/acpi/s3/s3.c
> @@ -32,10 +32,10 @@
>  #define PM_SUSPEND "pm-suspend"
>
>  static int  s3_multiple = 1;           /* number of s3 multiple tests to run */
> -static int  s3_min_delay = 0;          /* min time between resume and next suspend */
> -static int  s3_max_delay = 30;         /* max time between resume and next suspend */
> +static int  s3_min_delay = 60;         /* min time between resume and next suspend */
> +static int  s3_max_delay = 90;         /* max time between resume and next suspend */
>  static float s3_delay_delta = 0.5;     /* amount to add to delay between each S3 tests */
> -static int  s3_sleep_delay = 30;       /* time between start of suspend and wakeup */
> +static int  s3_sleep_delay = 60;       /* time between start of suspend and wakeup */
>  static bool s3_device_check = false;   /* check for device config changes */
>  static char *s3_quirks = NULL;         /* Quirks to be passed to pm-suspend */
>  static int  s3_device_check_delay = 15;        /* Time to sleep after waking up and then running device check */
> --
> 1.7.9.5
>
>
> --
> fwts-devel mailing list
> fwts-devel@lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel

Patch

diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c
index ae89423..f544f03 100644
--- a/src/acpi/s3/s3.c
+++ b/src/acpi/s3/s3.c
@@ -32,10 +32,10 @@ 
 #define PM_SUSPEND "pm-suspend"
 
 static int  s3_multiple = 1;		/* number of s3 multiple tests to run */
-static int  s3_min_delay = 0;		/* min time between resume and next suspend */
-static int  s3_max_delay = 30;		/* max time between resume and next suspend */
+static int  s3_min_delay = 60;		/* min time between resume and next suspend */
+static int  s3_max_delay = 90;		/* max time between resume and next suspend */
 static float s3_delay_delta = 0.5;	/* amount to add to delay between each S3 tests */
-static int  s3_sleep_delay = 30;	/* time between start of suspend and wakeup */
+static int  s3_sleep_delay = 60;	/* time between start of suspend and wakeup */
 static bool s3_device_check = false;	/* check for device config changes */
 static char *s3_quirks = NULL;		/* Quirks to be passed to pm-suspend */
 static int  s3_device_check_delay = 15;	/* Time to sleep after waking up and then running device check */