Patchwork [net-next,1/2] vxlan: do not set SKB_GSO_UDP

login
register
mail settings
Submitter Dmitry Kravkov
Date April 28, 2013, 6:16 p.m.
Message ID <1367172962-17369-2-git-send-email-dmitry@broadcom.com>
Download mbox | patch
Permalink /patch/240268/
State Accepted
Delegated to: David Miller
Headers show

Comments

Dmitry Kravkov - April 28, 2013, 6:16 p.m.
Since SKB_GSO_* flags are set by appropriate gso_segment callback
in TCP/UDP layer.

CC: Pravin B Shelar <pshelar@nicira.com> 
Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
 drivers/net/vxlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Pravin B Shelar - April 29, 2013, 4:35 p.m.
On Sun, Apr 28, 2013 at 11:16 AM, Dmitry Kravkov <dmitry@broadcom.com> wrote:
> Since SKB_GSO_* flags are set by appropriate gso_segment callback
> in TCP/UDP layer.
>
> CC: Pravin B Shelar <pshelar@nicira.com>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> ---

udp flag was set since we are using udp offload handler for vxlan gso.
But I think it forces to have udp offload for tunnel offloading.
Therefore the change looks right.

Acked-by: Pravin B Shelar <pshelar@nicira.com>

>  drivers/net/vxlan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index a7fd9a0..b92c6a0 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -913,7 +913,7 @@ static int handle_offloads(struct sk_buff *skb)
>                 if (unlikely(err))
>                         return err;
>
> -               skb_shinfo(skb)->gso_type |= (SKB_GSO_UDP_TUNNEL | SKB_GSO_UDP);
> +               skb_shinfo(skb)->gso_type |= SKB_GSO_UDP_TUNNEL;
>         } else if (skb->ip_summed != CHECKSUM_PARTIAL)
>                 skb->ip_summed = CHECKSUM_NONE;
>
> --
> 1.8.1.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index a7fd9a0..b92c6a0 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -913,7 +913,7 @@  static int handle_offloads(struct sk_buff *skb)
 		if (unlikely(err))
 			return err;
 
-		skb_shinfo(skb)->gso_type |= (SKB_GSO_UDP_TUNNEL | SKB_GSO_UDP);
+		skb_shinfo(skb)->gso_type |= SKB_GSO_UDP_TUNNEL;
 	} else if (skb->ip_summed != CHECKSUM_PARTIAL)
 		skb->ip_summed = CHECKSUM_NONE;