From patchwork Sat Apr 27 06:12:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amar X-Patchwork-Id: 240086 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 311DB2C0085 for ; Sat, 27 Apr 2013 16:10:46 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D3C9A4A136; Sat, 27 Apr 2013 08:10:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qE91scybBMmK; Sat, 27 Apr 2013 08:10:40 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9B8B94A169; Sat, 27 Apr 2013 08:09:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 876364A121 for ; Sat, 27 Apr 2013 08:09:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qhQNPKJNmvit for ; Sat, 27 Apr 2013 08:09:19 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by theia.denx.de (Postfix) with ESMTP id B69604A112 for ; Sat, 27 Apr 2013 08:09:16 +0200 (CEST) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MLW003ZEH3DLXA0@mailout4.samsung.com> for u-boot@lists.denx.de; Sat, 27 Apr 2013 15:09:14 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.122]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id E1.29.31024.A8B6B715; Sat, 27 Apr 2013 15:09:14 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-7c-517b6b8af03e Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 3E.18.08957.A8B6B715; Sat, 27 Apr 2013 15:09:14 +0900 (KST) Received: from amarendra-desktop.sisodomain.com ([107.108.73.18]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MLW00DPDH2TOT50@mmp2.samsung.com>; Sat, 27 Apr 2013 15:09:14 +0900 (KST) From: amar_g To: u-boot@lists.denx.de, jh80.chung@samsung.com Date: Sat, 27 Apr 2013 11:42:56 +0530 Message-id: <1367043180-6756-6-git-send-email-amarendra.xt@samsung.com> X-Mailer: git-send-email 1.7.3.rc2 In-reply-to: <1367043180-6756-1-git-send-email-amarendra.xt@samsung.com> References: <1367043180-6756-1-git-send-email-amarendra.xt@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42JZI2JSpduVXR1o0HdSwuLG9Z9sFl8WdLJb PFx/k8Vix537zBY3frWxWnQcaWG0mHL4C4vFty3bGC3e7u1kd+D0mN1wkcVj3qwTLB47Z91l 97hzbQ+bx9k7Oxg9+rasYgxgi+KySUnNySxLLdK3S+DKuLTmBWvBIoGK9Ue3MDUwruHtYuTk kBAwkZjVcYEZwhaTuHBvPVsXIxeHkMBSRonVD66wdjFygBVdvCIBEZ/OKLH/8RomkAYhgQlM Eqd2J4DYbALqEk8+rWUFsUUEDCSmP9nOCtLALDCfUWLxt0fsIAlhgSSJlUd2gw1lEVCVWP7G CcTkFXCXmNvOBXGDksT5ja/BxnAKeEj8u/GZGWKVu8S+aVPBRkoI7GKX6L3SyQaSYBEQkPg2 +RALxJ2yEpsOQP0iKXFwxQ2WCYzCCxgZVjGKphYkFxQnpRcZ6hUn5haX5qXrJefnbmIExsDp f896dzDePmB9iDEZaNxEZinR5HxgDOWVxBsamxlZmJqYGhuZW5qRJqwkzqvWYh0oJJCeWJKa nZpakFoUX1Sak1p8iJGJg1OqgVG9iE9X7mkFp9T7T43L2+vaFi2X85Gbk7ftz0fVq0bH5gSu an/uI7BEJ2Fjiu0Wwce5q76+mPe6UWhRUOhb+ULpP5krszu410/kP73/VtQRx/KTomILm6sW s7sGlGksi7u8ctbedtHXzXGTfHU/+xrOej6jTIfzzX8WrdvSxx2uLm+7f6Wza4ISS3FGoqEW c1FxIgAlRsyFlwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jQd2u7OpAg4NT+CxuXP/JZvFlQSe7 xcP1N1ksdty5z2xx41cbq0XHkRZGiymHv7BYfNuyjdHi7d5OdgdOj9kNF1k85s06weKxc9Zd do871/aweZy9s4PRo2/LKsYAtqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtz JYW8xNxUWyUXnwBdt8wcoLuUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmggYQ1 jBmX1rxgLVgkULH+6BamBsY1vF2MHBwSAiYSF69IdDFyApliEhfurWfrYuTiEBKYziix//Ea JpCEkMAEJolTuxNAbDYBdYknn9aygtgiAgYS059sZwVpYBaYzyix+NsjdpCEsECSxMoju1lB FrAIqEosf+MEYvIKuEvMbeeC2KUkcX7ja7AxnAIeEv9ufGaGWOUusW/aVNYJjLwLGBlWMYqm FiQXFCel5xrqFSfmFpfmpesl5+duYgRH2DOpHYwrGywOMQpwMCrx8GosqgoUYk0sK67MPcQo wcGsJMKrmFodKMSbklhZlVqUH19UmpNafIgxGeimicxSosn5wOjPK4k3NDYxNzU2tTSxMDGz JE1YSZz3QKt1oJBAemJJanZqakFqEcwWJg5OqQZG5XqJ3xP+WHS/iD0aJbtxw6SOqjNKl8xD bT3F9m1c2hmx2/pycK+39cx9/bnJNw9KpLw4+T6f4xHbJ67AxZvyypayTG0rCpMI+37oxJuy tuijDj6fVE10kn53vZf3mjfN7AnbS0nvYKsJ91KchRPZalXVnZ+V+5Ze/6f7loFtbu+VjP2C DmuVWIozEg21mIuKEwFb6kTy9AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: patches@linaro.org, afleming@gmail.com, hs@denx.de Subject: [U-Boot] [PATCH V9 5/9] EXYNOS5: DWMMC: Initialise the local variable to avoid unwanted results. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Amar This patch initialises the local variable 'shift' to zero. The uninitialised local variable 'shift' had garbage value and was resulting in unwnated results in the functions exynos5_get_mmc_clk() and exynos4_get_mmc_clk(). Signed-off-by: Amar Acked-by: Simon Glass Acked-by: Jaehoon Chung --- Changes since V1: 1)Updated the function exynos5_mmc_set_clk_div() to receive 'device_i'd as input parameter instead of 'index'. Changes since V2: 1)Updation of commit message and resubmition of proper patch set. Changes since V3: 1)Removed the new API exynos5_mmc_set_clk_div() from clock.c, because existing API set_mmc_clk() can be used to set mmc clock. Changes since V4: 1)Updated the subject line to reflect the changes present in this patch. 2)Changes of the file arch/arm/include/asm/arch-exynos/clk.h which were present in this patch, have been moved out of this patch. Changes since V5: No change. Changes since V6: No change. Changes since V7: No change. Changes since V8: No change. arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c index 223660a..cf3247a 100644 --- a/arch/arm/cpu/armv7/exynos/clock.c +++ b/arch/arm/cpu/armv7/exynos/clock.c @@ -613,7 +613,7 @@ static unsigned long exynos4_get_mmc_clk(int dev_index) (struct exynos4_clock *)samsung_get_base_clock(); unsigned long uclk, sclk; unsigned int sel, ratio, pre_ratio; - int shift; + int shift = 0; sel = readl(&clk->src_fsys); sel = (sel >> (dev_index << 2)) & 0xf; @@ -662,7 +662,7 @@ static unsigned long exynos5_get_mmc_clk(int dev_index) (struct exynos5_clock *)samsung_get_base_clock(); unsigned long uclk, sclk; unsigned int sel, ratio, pre_ratio; - int shift; + int shift = 0; sel = readl(&clk->src_fsys); sel = (sel >> (dev_index << 2)) & 0xf;