From patchwork Tue Mar 3 18:42:14 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: powerpc/spufs: negative size in spufs_{regs/fpcr}_write Date: Tue, 03 Mar 2009 08:42:14 -0000 From: roel kluin X-Patchwork-Id: 24007 Message-Id: <49AD7A06.2090401@gmail.com> To: jk@ozlabs.org Cc: linuxppc-dev@ozlabs.org, Andrew Morton , cbe-oss-dev@ozlabs.org When stored in size_t size, the test 'size <= 0' does no longer work. Signed-off-by: Roel Kluin --- diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c index 0da7f2b..05dba47 100644 --- a/arch/powerpc/platforms/cell/spufs/file.c +++ b/arch/powerpc/platforms/cell/spufs/file.c @@ -569,7 +569,7 @@ spufs_regs_write(struct file *file, const char __user *buffer, int ret; size = min_t(ssize_t, sizeof lscsa->gprs - *pos, size); - if (size <= 0) + if ((ssize_t)size <= 0) return -EFBIG; *pos += size; @@ -624,7 +624,7 @@ spufs_fpcr_write(struct file *file, const char __user * buffer, int ret; size = min_t(ssize_t, sizeof(lscsa->fpcr) - *pos, size); - if (size <= 0) + if ((ssize_t)size <= 0) return -EFBIG; ret = spu_acquire_saved(ctx);