diff mbox

[net-next] vxlan: restore source compatibility

Message ID 20130426165444.317d4aad@nehalam.linuxnetplumber.net
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Stephen Hemminger April 26, 2013, 11:54 p.m. UTC
The commit:
    vxlan: Allow setting destination to unicast address.

Broke source compatibility with exported user headers.
Compile fails with older iproute2 source fails since IFLA_VXLAN_REMOTE not defined.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller April 27, 2013, 3:27 a.m. UTC | #1
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 26 Apr 2013 16:54:44 -0700

> The commit:
>     vxlan: Allow setting destination to unicast address.

Please reference commits both by SHA1 ID and the commit header line text,
in this format:

	commit ${SHA1_ID} ("Commit header line text.")

> Broke source compatibility with exported user headers.
> Compile fails with older iproute2 source fails since IFLA_VXLAN_REMOTE not defined.

Judging by your patch, the problem is that IFLA_VXLAN_GROUP is not defined,
not IFLA_VXLAN_REMOTE.

Are the semantic change issues here as well?  Just wondering.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/include/uapi/linux/if_link.h	2013-04-22 15:44:00.970002724 -0700
+++ b/include/uapi/linux/if_link.h	2013-04-26 16:49:41.709698816 -0700
@@ -298,6 +298,7 @@  enum {
 	IFLA_VXLAN_UNSPEC,
 	IFLA_VXLAN_ID,
 	IFLA_VXLAN_REMOTE,
+#define IFLA_VXLAN_GROUP IFLA_VXLAN_REMOTE
 	IFLA_VXLAN_LINK,
 	IFLA_VXLAN_LOCAL,
 	IFLA_VXLAN_TTL,