Patchwork [net,1/1] r8169: fix 8168evl frame padding.

login
register
mail settings
Submitter fran├žois romieu
Date April 26, 2013, 11:49 p.m.
Message ID <20130426234932.GA20296@electric-eye.fr.zoreil.com>
Download mbox | patch
Permalink /patch/240061/
State Accepted
Delegated to: David Miller
Headers show

Comments

fran├žois romieu - April 26, 2013, 11:49 p.m.
From: Stefan Bader <stefan.bader@canonical.com>

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Cc: hayeswang <hayeswang@realtek.com>
---

Stefan reported that Realtek's driver solves his problem as well.
It works differently though: skb_checksum_help vs skb_pad here.

 drivers/net/ethernet/realtek/r8169.c | 9 +++++++++
 1 file changed, 9 insertions(+)
David Miller - April 29, 2013, 6:11 p.m.
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Sat, 27 Apr 2013 01:49:32 +0200

> From: Stefan Bader <stefan.bader@canonical.com>
> 
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
> Cc: hayeswang <hayeswang@realtek.com>

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 4ecbe64..15ba8c4 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -5787,6 +5787,14 @@  static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
 		goto err_stop_0;
 	}
 
+	/* 8168evl does not automatically pad to minimum length. */
+	if (unlikely(tp->mac_version == RTL_GIGA_MAC_VER_34 &&
+		     skb->len < ETH_ZLEN)) {
+		if (skb_padto(skb, ETH_ZLEN))
+			goto err_update_stats;
+		skb_put(skb, ETH_ZLEN - skb->len);
+	}
+
 	if (unlikely(le32_to_cpu(txd->opts1) & DescOwn))
 		goto err_stop_0;
 
@@ -5858,6 +5866,7 @@  err_dma_1:
 	rtl8169_unmap_tx_skb(d, tp->tx_skb + entry, txd);
 err_dma_0:
 	dev_kfree_skb(skb);
+err_update_stats:
 	dev->stats.tx_dropped++;
 	return NETDEV_TX_OK;