Patchwork [04/30] target-ppc: fix nego and subf*o instructions

mail settings
Submitter Alexander Graf
Date April 26, 2013, 6:21 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/239909/
State New
Headers show


Alexander Graf - April 26, 2013, 6:21 p.m.
From: Aurelien Jarno <>

The overflow computation of nego and subf*o instructions has been broken
in commit ffe30937. Contrary to other targets, the instruction is subtract
from an not subtract on PowerPC.

This patch fixes the issue by using the correct argument in the xor
computation. Thanks to Peter Maydell for the hint.

With this change the PPC emulation passes the Gwenole Beauchesne
testsuite again.

Signed-off-by: Aurelien Jarno <>
Reviewed-by: Richard Henderson <>
Signed-off-by: Alexander Graf <>
 target-ppc/translate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 5e741d1..294ab58 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -746,7 +746,7 @@  static inline void gen_op_arith_compute_ov(DisasContext *ctx, TCGv arg0,
     TCGv t0 = tcg_temp_new();
-    tcg_gen_xor_tl(cpu_ov, arg0, arg1);
+    tcg_gen_xor_tl(cpu_ov, arg0, arg2);
     tcg_gen_xor_tl(t0, arg1, arg2);
     if (sub) {
         tcg_gen_and_tl(cpu_ov, cpu_ov, t0);