From patchwork Fri Apr 26 13:10:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 239863 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id E28F12C0112 for ; Fri, 26 Apr 2013 23:10:28 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E4F9F4A09F; Fri, 26 Apr 2013 15:10:25 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hExWoWKBe4Vq; Fri, 26 Apr 2013 15:10:25 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2A2264A090; Fri, 26 Apr 2013 15:10:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0B3914A090 for ; Fri, 26 Apr 2013 15:10:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pAKuEkjkSopz for ; Fri, 26 Apr 2013 15:10:19 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by theia.denx.de (Postfix) with ESMTPS id 1B3574A08F for ; Fri, 26 Apr 2013 15:10:17 +0200 (CEST) Received: by mail-ob0-f178.google.com with SMTP id 16so3447886obc.23 for ; Fri, 26 Apr 2013 06:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=g1Ezp7AGXw3m5gdhdLNiwmrTT8y7j1qRLM7okOgdrZ4=; b=ONLKhkikaiey5QTgXvpuJOPG3ak0hKEBEBOFwHymH11zIcsB+wz2fvbLAKHqlIqR9m EhXvJwhe46S9nHO0MPEbMu+rTmYNMhxyfoCpMcuHcQkaqxsKGkKUU+RrjjKc6mGJpAlW vwSAeeO2L8jmbZmbw/sK81ff1sEO8KxZ7tmqbshHn+ZPaHhGl4FI69TCVVw/svIVqDAW y9Kc51LWHuRKNjy+I/8zQUlWOH4+JR4qXgJu0L26+INw72HwpY+We3ZgzklHXvS6HdJb vRJjnl5dZMtYtEXIASmoXO08Sqo4QXvtIgZDeRVuAnFCyPKP+N4XvHJR2eRCFm9AYVHY JefQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=g1Ezp7AGXw3m5gdhdLNiwmrTT8y7j1qRLM7okOgdrZ4=; b=DKi3laz7IexZ/irKKPs9cP/xRkVdsIyFaV1OkzS73+Tj0g8P6hqfESY9vOuQtgEm+F WfmQTOZKdPE9PzwRMOkQYsgyNh4VmAZG6usYa/JoE5rRP00oigNC5RkW9BlAcE6kd6PG mjuAcxQ+EddPv3dX9DtALlMQff7sYgEhPw0Mg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=g1Ezp7AGXw3m5gdhdLNiwmrTT8y7j1qRLM7okOgdrZ4=; b=mnHAtcuTKrzscEyM3Og+MuAtgSbZmmxTuvnXaMUn6BIb1/XA+G4guRkExY1HgEmo5W 1UiU7a0L3MyybUYF7svdidE99Zotpd7aaBVJB/6C6wFfBOiyCKmU3Yh0i8mjf/9BCL9F CWB2auYoLLItBCAYMnn4dU22Ya8q+TInKPA4YrVffUBU3HvWdJd3xwhmIq9FjuJWmfgF FHyB9ORpY/tKKEVB3wMmVwKB16NpqpO7sncA28z4VA0MHOZpyFMIWafKetYpXQWoyXiG InKCTa9ptKhm1F9XcVlZroiw3oTRpSiBSU9SYQ1k030zvmVUtxQTh1l1tdVNJ0q1A16N vffQ== MIME-Version: 1.0 X-Received: by 10.60.121.33 with SMTP id lh1mr17864371oeb.98.1366981815457; Fri, 26 Apr 2013 06:10:15 -0700 (PDT) Received: by 10.182.146.47 with HTTP; Fri, 26 Apr 2013 06:10:15 -0700 (PDT) In-Reply-To: References: <1366483372-16523-1-git-send-email-sjg@chromium.org> <20130422151833.GQ14952@bill-the-cat> Date: Fri, 26 Apr 2013 06:10:15 -0700 X-Google-Sender-Auth: EfJb4UTLJpMoQKWk9nwjAMAMFRI Message-ID: From: Simon Glass To: Tom Rini X-Gm-Message-State: ALoCoQmNTkL81X1OCmk8766oliiSY3y40GkFyqC2BZDkipDf2A47O4ZutGyjVms8EYZiS3l3za6p9ZxGRTkA05YB0Ec2ElMU82fd+Omw4pOOKAnC4YaHClVSPpM1fyTcWfFd3eNXefAW/chTkM7OjkmW+MliuXPKPFVlTgrpj1jDXBDmRxiWYYS2+LySiLfJVLHpG6HOvpDY Cc: U-Boot Mailing List , Jerry Van Baren , u-boot-review Subject: Re: [U-Boot] [PATCH v3 0/17] sandbox: Generic board support and other improvements X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Hi Tom, On Mon, Apr 22, 2013 at 9:08 AM, Simon Glass wrote: > Hi Tom, > > On Mon, Apr 22, 2013 at 8:18 AM, Tom Rini wrote: >> On Sat, Apr 20, 2013 at 11:42:35AM -0700, Simon Glass wrote: >> >>> This series adds generic board support to sandbox and switches to use this >>> always. >>> >>> With sandbox it was noticed that turning CONFIG_SYS_GENERIC_BOARD off >>> can cause a build failure if a previous autoconf.mk exists which indicates >>> that generic board is not supported, so a patch is provided to fix this. >>> >>> It is useful to convert a pointer into an 'address' in the sandbox RAM >>> buffer - the opposite of map_sysmem(). This is added in this series and >>> used in several places. >>> >>> With sandbox it is easier to read a file from the host than to use the >>> CONFIG_OF_SEPARATE option, since this option requires knowledge of the >>> executable image structure which is not really appropriate on the host >>> system. A new CONFIG_OF_HOSTFILE provides this. >>> >>> A few related FDT changes are included in this series also. >>> >>> The -c option is enhanced to support passing entire scripts to sandbox. >>> This is useful when writing non-trivial test code. >>> >>> Most of these patches were previously submitted as part of the verified >>> boot effort. This series collects the independent sandbox-related patches >>> together to make it easier to review. THe whole series is marked as >>> version 3 for this reason. >> >> For the series, >> Reviewed-by: Tom Rini >> >> And I'd say 3/4/5 should be squashed into one patch, but it's your arch >> so I'l defer if you think it adds bisect value or similar to do it in >> that manner. > > I did that so that it could be kind-of an example of how this can be > done for an arch, given that I am not planning to convert the rest. By > removing the dead code in a separate step it seemed a bit clearer to > me. > > But it's fine either way - I will squash it and resend. I have put this series in patchwork as: http://patchwork.ozlabs.org/bundle/sjg/sandbox/ and below is a pull request if you want to take that instead. I did not go through and add your Reviewed-by to each patch. Am I supposed to do that? The following changes since commit d10f68ae47b67acab8b110b5c605dde4197a1820: Prepare v2013.04 (2013-04-19 10:25:43 -0400) are available in the git repository at: git://git.denx.de/u-boot-x86.git sandbox for you to fetch changes up to 3a95570c609a35f60d4c798948f83f8427544ff2: sandbox: config: Enable CONFIG_FIT and CONFIG_CMD_FIT (2013-04-26 06:00:06 -0700) ---------------------------------------------------------------- Simon Glass (15): Trigger generic board error only when building sandbox: Provide a way to map from host RAM to U-Boot RAM sandbox: Switch over to generic board sandbox: Add CONFIG_OF_HOSTFILE to read FDT from host file fdt: Add a parameter to fdt_valid() Add getenv_hex() to return an environment variable as hex fdt: Allow fdt command to check and update control FDT sandbox: fdt: Support fdt command for sandbox fdt: Skip checking FDT if the pointer is NULL Revert "fdt- Tell the FDT library where the device tree is" sandbox: Allow -c argument to provide a command list sandbox: Support 'source' command fs: Add support for saving data to filesystems sandbox: fs: Add support for saving files to host filesystem sandbox: config: Enable CONFIG_FIT and CONFIG_CMD_FIT Makefile | 10 ++ arch/sandbox/config.mk | 5 +- arch/sandbox/cpu/cpu.c | 5 + arch/sandbox/cpu/start.c | 9 +- arch/sandbox/include/asm/io.h | 8 ++ arch/sandbox/include/asm/state.h | 1 + arch/sandbox/include/asm/u-boot.h | 22 +-- arch/sandbox/lib/Makefile | 1 - arch/sandbox/lib/board.c | 285 -------------------------------------- board/sandbox/sandbox/sandbox.c | 2 +- common/board_f.c | 106 ++++++++++++-- common/board_r.c | 8 +- common/cmd_fdt.c | 87 ++++++++---- common/cmd_nvedit.c | 15 ++ common/cmd_sandbox.c | 18 ++- common/cmd_source.c | 11 +- common/main.c | 8 -- config.mk | 4 +- doc/README.fdt-control | 6 +- fs/fs.c | 75 ++++++++++ fs/sandbox/sandboxfs.c | 33 +++++ include/asm-generic/sections.h | 2 +- include/common.h | 18 +++ include/configs/sandbox.h | 11 +- include/fs.h | 2 + include/sandboxfs.h | 1 + lib/fdtdec.c | 5 +- 27 files changed, 383 insertions(+), 375 deletions(-) delete mode 100644 arch/sandbox/lib/board.c Regards, Simon