From patchwork Thu Apr 25 19:52:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Dangaard Brouer X-Patchwork-Id: 239589 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 65E172C011D for ; Fri, 26 Apr 2013 05:52:23 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759139Ab3DYTwT (ORCPT ); Thu, 25 Apr 2013 15:52:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28597 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759025Ab3DYTwS (ORCPT ); Thu, 25 Apr 2013 15:52:18 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3PJqDcl014032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 25 Apr 2013 15:52:13 -0400 Received: from dragon.localdomain (ovpn-116-38.ams2.redhat.com [10.36.116.38]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3PJqCM6019345; Thu, 25 Apr 2013 15:52:12 -0400 Received: from [127.0.0.1] (localhost [IPv6:::1]) by dragon.localdomain (Postfix) with ESMTP id D2863E40409; Thu, 25 Apr 2013 21:52:25 +0200 (CEST) From: Jesper Dangaard Brouer Subject: [net-next PATCH V2] net: increase frag hash size To: "David S. Miller" , Hannes Frederic Sowa Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, Eric Dumazet , sergei.shtylyov@cogentembedded.com Date: Thu, 25 Apr 2013 21:52:25 +0200 Message-ID: <20130425194850.25609.46664.stgit@dragon> In-Reply-To: <20130424154822.16883.93014.stgit@dragon> References: <20130424154822.16883.93014.stgit@dragon> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Increase fragmentation hash bucket size to 1024 from old 64 elems. After we increased the frag mem limits commit c2a93660 (net: increase fragment memory usage limits) the hash size of 64 elements is simply too small. Also considering the mem limit is per netns and the hash table is shared for all netns. For the embedded people, note that this increase will change the hash table/array from using approx 1 Kbytes to 16 Kbytes. Signed-off-by: Jesper Dangaard Brouer Acked-by: Hannes Frederic Sowa Acked-by: Eric Dumazet --- V2: - Fix commit message, correct formatted commit IDs - Added prevous acked-by to (hopfully) easy DaveM's work include/net/inet_frag.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h index eb1d6ee..4e15856 100644 --- a/include/net/inet_frag.h +++ b/include/net/inet_frag.h @@ -41,7 +41,7 @@ struct inet_frag_queue { struct netns_frags *net; }; -#define INETFRAGS_HASHSZ 64 +#define INETFRAGS_HASHSZ 1024 struct inet_frag_bucket { struct hlist_head chain;