| Message ID | 20130425.152431.1753713368050789406.davem@davemloft.net |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 04/25/2013 12:24 PM, David Miller wrote: > From: Alexander Duyck <alexander.h.duyck@intel.com> > Date: Thu, 25 Apr 2013 11:29:04 -0700 > >> I did a bit of digging and it looks like the issue is that the >> ext_filter_mask is not being found in the message received in >> rtnl_dump_ifinfo. I'm still trying to figure out why the kernel isn't >> finding the flag when it was finding it previously, but I'm not much of >> a netlink expert. > I wonder if this has something to do with this commit: > > ==================== > From 88c5b5ce5cb57af6ca2a7cf4d5715fa320448ff9 Mon Sep 17 00:00:00 2001 > From: Michael Riesch <michael.riesch@omicron.at> > Date: Mon, 8 Apr 2013 05:45:26 +0000 > Subject: [PATCH] rtnetlink: Call nlmsg_parse() with correct header length > > Signed-off-by: Michael Riesch <michael.riesch@omicron.at> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Benc <jbenc@redhat.com> > Cc: "Theodore Ts'o" <tytso@mit.edu> > Cc: linux-kernel@vger.kernel.org > Acked-by: Mark Rustad <mark.d.rustad@intel.com> > Signed-off-by: David S. Miller <davem@davemloft.net> > --- > net/core/rtnetlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c > index b65441d..23854b5 100644 > --- a/net/core/rtnetlink.c > +++ b/net/core/rtnetlink.c > @@ -1072,7 +1072,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb) > rcu_read_lock(); > cb->seq = net->dev_base_seq; > > - if (nlmsg_parse(cb->nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, > + if (nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, > ifla_policy) >= 0) { > > if (tb[IFLA_EXT_MASK]) > @@ -1922,7 +1922,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct nlmsghdr *nlh) > u32 ext_filter_mask = 0; > u16 min_ifinfo_dump_size = 0; > > - if (nlmsg_parse(nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, > + if (nlmsg_parse(nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, > ifla_policy) >= 0) { > if (tb[IFLA_EXT_MASK]) > ext_filter_mask = nla_get_u32(tb[IFLA_EXT_MASK]); I thought that as well. I tried reverting it and the issue is still there. However, I do think this may be part of the issue since I added a printk to dump nlmsg_attrlen before going into the nlmsg_parse and with ifinfomsg the attrlen is -12, with rtgenmsg it is 0. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Alexander Duyck <alexander.h.duyck@intel.com> Date: Thu, 25 Apr 2013 13:20:24 -0700 > On 04/25/2013 12:24 PM, David Miller wrote: >> From: Alexander Duyck <alexander.h.duyck@intel.com> >> Date: Thu, 25 Apr 2013 11:29:04 -0700 >> >> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >> index b65441d..23854b5 100644 >> --- a/net/core/rtnetlink.c >> +++ b/net/core/rtnetlink.c >> @@ -1072,7 +1072,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb) >> rcu_read_lock(); >> cb->seq = net->dev_base_seq; >> >> - if (nlmsg_parse(cb->nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, >> + if (nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, >> ifla_policy) >= 0) { >> >> if (tb[IFLA_EXT_MASK]) >> @@ -1922,7 +1922,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct nlmsghdr *nlh) >> u32 ext_filter_mask = 0; >> u16 min_ifinfo_dump_size = 0; >> >> - if (nlmsg_parse(nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, >> + if (nlmsg_parse(nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, >> ifla_policy) >= 0) { >> if (tb[IFLA_EXT_MASK]) >> ext_filter_mask = nla_get_u32(tb[IFLA_EXT_MASK]); > > I thought that as well. I tried reverting it and the issue is still there. > > However, I do think this may be part of the issue since I added a printk > to dump nlmsg_attrlen before going into the nlmsg_parse and with > ifinfomsg the attrlen is -12, with rtgenmsg it is 0. I wonder if we are seeing two ways tools are making these calls, some are passing rtgenmsg and some are passing ifinfomsg. The latter, I am mostly convinced, is what we must see here from properly written applications. That would be really unfortunate, but seeing a nlmsg_attrlen() of -12 would seem to confirm that a rtgenmsg was used. I guess you're using iproute2? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/25/2013 01:25 PM, David Miller wrote: > From: Alexander Duyck <alexander.h.duyck@intel.com> > Date: Thu, 25 Apr 2013 13:20:24 -0700 > >> On 04/25/2013 12:24 PM, David Miller wrote: >>> From: Alexander Duyck <alexander.h.duyck@intel.com> >>> Date: Thu, 25 Apr 2013 11:29:04 -0700 >>> >>> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >>> index b65441d..23854b5 100644 >>> --- a/net/core/rtnetlink.c >>> +++ b/net/core/rtnetlink.c >>> @@ -1072,7 +1072,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb) >>> rcu_read_lock(); >>> cb->seq = net->dev_base_seq; >>> >>> - if (nlmsg_parse(cb->nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, >>> + if (nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, >>> ifla_policy) >= 0) { >>> >>> if (tb[IFLA_EXT_MASK]) >>> @@ -1922,7 +1922,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct nlmsghdr *nlh) >>> u32 ext_filter_mask = 0; >>> u16 min_ifinfo_dump_size = 0; >>> >>> - if (nlmsg_parse(nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, >>> + if (nlmsg_parse(nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, >>> ifla_policy) >= 0) { >>> if (tb[IFLA_EXT_MASK]) >>> ext_filter_mask = nla_get_u32(tb[IFLA_EXT_MASK]); >> I thought that as well. I tried reverting it and the issue is still there. >> >> However, I do think this may be part of the issue since I added a printk >> to dump nlmsg_attrlen before going into the nlmsg_parse and with >> ifinfomsg the attrlen is -12, with rtgenmsg it is 0. > I wonder if we are seeing two ways tools are making these calls, some are > passing rtgenmsg and some are passing ifinfomsg. The latter, I am mostly > convinced, is what we must see here from properly written applications. > > That would be really unfortunate, but seeing a nlmsg_attrlen() of -12 would > seem to confirm that a rtgenmsg was used. > > I guess you're using iproute2? Yes. All I am doing is ip link show and previously this would display VF info as well as PF. Now the VF info is not there. From what I can tell the problem call is rtnl_wilddump_req_filter since it is only passing a rtgenmsg and asking us to dump the link with the RTEXT_FILTER_VF filter mask. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 25 Apr 2013 13:36:06 -0700 Alexander Duyck <alexander.h.duyck@intel.com> wrote: > On 04/25/2013 01:25 PM, David Miller wrote: > > From: Alexander Duyck <alexander.h.duyck@intel.com> > > Date: Thu, 25 Apr 2013 13:20:24 -0700 > > > >> On 04/25/2013 12:24 PM, David Miller wrote: > >>> From: Alexander Duyck <alexander.h.duyck@intel.com> > >>> Date: Thu, 25 Apr 2013 11:29:04 -0700 > >>> > >>> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c > >>> index b65441d..23854b5 100644 > >>> --- a/net/core/rtnetlink.c > >>> +++ b/net/core/rtnetlink.c > >>> @@ -1072,7 +1072,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb) > >>> rcu_read_lock(); > >>> cb->seq = net->dev_base_seq; > >>> > >>> - if (nlmsg_parse(cb->nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, > >>> + if (nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, > >>> ifla_policy) >= 0) { > >>> > >>> if (tb[IFLA_EXT_MASK]) > >>> @@ -1922,7 +1922,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct nlmsghdr *nlh) > >>> u32 ext_filter_mask = 0; > >>> u16 min_ifinfo_dump_size = 0; > >>> > >>> - if (nlmsg_parse(nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, > >>> + if (nlmsg_parse(nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, > >>> ifla_policy) >= 0) { > >>> if (tb[IFLA_EXT_MASK]) > >>> ext_filter_mask = nla_get_u32(tb[IFLA_EXT_MASK]); > >> I thought that as well. I tried reverting it and the issue is still there. > >> > >> However, I do think this may be part of the issue since I added a printk > >> to dump nlmsg_attrlen before going into the nlmsg_parse and with > >> ifinfomsg the attrlen is -12, with rtgenmsg it is 0. > > I wonder if we are seeing two ways tools are making these calls, some are > > passing rtgenmsg and some are passing ifinfomsg. The latter, I am mostly > > convinced, is what we must see here from properly written applications. > > > > That would be really unfortunate, but seeing a nlmsg_attrlen() of -12 would > > seem to confirm that a rtgenmsg was used. > > > > I guess you're using iproute2? > > Yes. All I am doing is ip link show and previously this would display > VF info as well as PF. Now the VF info is not there. > > From what I can tell the problem call is rtnl_wilddump_req_filter since > it is only passing a rtgenmsg and asking us to dump the link with the > RTEXT_FILTER_VF filter mask. It looks like a bug in the initial code for filter. in this case, it calls: ip_list_flush_or_save rtnl_wilddump_req_filter which sends 'struct rtgenmsg' This was probably a mistake in the original flags addition, not sure if we can fix it now that ABI is set. Probably have to revert the kernel change. commit bd886ebb1ffd84301caa2341b671df9a9e2db4c9 Author: Rose, Gregory V <gregory.v.rose@intel.com> Date: Tue Feb 21 10:43:09 2012 +0000 iproute2: Add netlink attribute to filter dump requests Add a new netlink attribute type to the dump request to allow filtering of the information returned for the respective matching interfaces. At this time the only filter defined is to request virtual function (VF) device info for interfaces that attached VFs. It will also be possible to extend the request with other yet to be defined netlink attributes in the future. Signed-off-by: Greg Rose <gregory.v.rose@intel.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Stephen Hemminger <stephen@networkplumber.org> Date: Thu, 25 Apr 2013 13:45:13 -0700 > On Thu, 25 Apr 2013 13:36:06 -0700 > Alexander Duyck <alexander.h.duyck@intel.com> wrote: > >> On 04/25/2013 01:25 PM, David Miller wrote: >> > From: Alexander Duyck <alexander.h.duyck@intel.com> >> > Date: Thu, 25 Apr 2013 13:20:24 -0700 >> > >> >> On 04/25/2013 12:24 PM, David Miller wrote: >> >>> From: Alexander Duyck <alexander.h.duyck@intel.com> >> >>> Date: Thu, 25 Apr 2013 11:29:04 -0700 >> >>> >> >>> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >> >>> index b65441d..23854b5 100644 >> >>> --- a/net/core/rtnetlink.c >> >>> +++ b/net/core/rtnetlink.c >> >>> @@ -1072,7 +1072,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb) >> >>> rcu_read_lock(); >> >>> cb->seq = net->dev_base_seq; >> >>> >> >>> - if (nlmsg_parse(cb->nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, >> >>> + if (nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, >> >>> ifla_policy) >= 0) { >> >>> >> >>> if (tb[IFLA_EXT_MASK]) >> >>> @@ -1922,7 +1922,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct nlmsghdr *nlh) >> >>> u32 ext_filter_mask = 0; >> >>> u16 min_ifinfo_dump_size = 0; >> >>> >> >>> - if (nlmsg_parse(nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, >> >>> + if (nlmsg_parse(nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, >> >>> ifla_policy) >= 0) { >> >>> if (tb[IFLA_EXT_MASK]) >> >>> ext_filter_mask = nla_get_u32(tb[IFLA_EXT_MASK]); >> >> I thought that as well. I tried reverting it and the issue is still there. >> >> >> >> However, I do think this may be part of the issue since I added a printk >> >> to dump nlmsg_attrlen before going into the nlmsg_parse and with >> >> ifinfomsg the attrlen is -12, with rtgenmsg it is 0. >> > I wonder if we are seeing two ways tools are making these calls, some are >> > passing rtgenmsg and some are passing ifinfomsg. The latter, I am mostly >> > convinced, is what we must see here from properly written applications. >> > >> > That would be really unfortunate, but seeing a nlmsg_attrlen() of -12 would >> > seem to confirm that a rtgenmsg was used. >> > >> > I guess you're using iproute2? >> >> Yes. All I am doing is ip link show and previously this would display >> VF info as well as PF. Now the VF info is not there. >> >> From what I can tell the problem call is rtnl_wilddump_req_filter since >> it is only passing a rtgenmsg and asking us to dump the link with the >> RTEXT_FILTER_VF filter mask. > > It looks like a bug in the initial code for filter. in this case, it calls: > ip_list_flush_or_save > rtnl_wilddump_req_filter > which sends 'struct rtgenmsg' > > This was probably a mistake in the original flags addition, not sure if we can > fix it now that ABI is set. Probably have to revert the kernel change. But we know there are tools, just as widely deployed, passing in ifinfomsg. That's what trigged inclusion of the patch above in the first place. Let's just declare this an iproute2 bug, fix iproute2 to pass ifinfomsg too, and keep an eye out for when other folks run into this problem. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/25/2013 01:49 PM, David Miller wrote: > From: Stephen Hemminger <stephen@networkplumber.org> > Date: Thu, 25 Apr 2013 13:45:13 -0700 > >> On Thu, 25 Apr 2013 13:36:06 -0700 >> Alexander Duyck <alexander.h.duyck@intel.com> wrote: >> >>> On 04/25/2013 01:25 PM, David Miller wrote: >>>> From: Alexander Duyck <alexander.h.duyck@intel.com> >>>> Date: Thu, 25 Apr 2013 13:20:24 -0700 >>>> >>>>> On 04/25/2013 12:24 PM, David Miller wrote: >>>>>> From: Alexander Duyck <alexander.h.duyck@intel.com> >>>>>> Date: Thu, 25 Apr 2013 11:29:04 -0700 >>>>>> >>>>>> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >>>>>> index b65441d..23854b5 100644 >>>>>> --- a/net/core/rtnetlink.c >>>>>> +++ b/net/core/rtnetlink.c >>>>>> @@ -1072,7 +1072,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb) >>>>>> rcu_read_lock(); >>>>>> cb->seq = net->dev_base_seq; >>>>>> >>>>>> - if (nlmsg_parse(cb->nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, >>>>>> + if (nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, >>>>>> ifla_policy) >= 0) { >>>>>> >>>>>> if (tb[IFLA_EXT_MASK]) >>>>>> @@ -1922,7 +1922,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct nlmsghdr *nlh) >>>>>> u32 ext_filter_mask = 0; >>>>>> u16 min_ifinfo_dump_size = 0; >>>>>> >>>>>> - if (nlmsg_parse(nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, >>>>>> + if (nlmsg_parse(nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, >>>>>> ifla_policy) >= 0) { >>>>>> if (tb[IFLA_EXT_MASK]) >>>>>> ext_filter_mask = nla_get_u32(tb[IFLA_EXT_MASK]); >>>>> I thought that as well. I tried reverting it and the issue is still there. >>>>> >>>>> However, I do think this may be part of the issue since I added a printk >>>>> to dump nlmsg_attrlen before going into the nlmsg_parse and with >>>>> ifinfomsg the attrlen is -12, with rtgenmsg it is 0. >>>> I wonder if we are seeing two ways tools are making these calls, some are >>>> passing rtgenmsg and some are passing ifinfomsg. The latter, I am mostly >>>> convinced, is what we must see here from properly written applications. >>>> >>>> That would be really unfortunate, but seeing a nlmsg_attrlen() of -12 would >>>> seem to confirm that a rtgenmsg was used. >>>> >>>> I guess you're using iproute2? >>> Yes. All I am doing is ip link show and previously this would display >>> VF info as well as PF. Now the VF info is not there. >>> >>> From what I can tell the problem call is rtnl_wilddump_req_filter since >>> it is only passing a rtgenmsg and asking us to dump the link with the >>> RTEXT_FILTER_VF filter mask. >> It looks like a bug in the initial code for filter. in this case, it calls: >> ip_list_flush_or_save >> rtnl_wilddump_req_filter >> which sends 'struct rtgenmsg' >> >> This was probably a mistake in the original flags addition, not sure if we can >> fix it now that ABI is set. Probably have to revert the kernel change. > But we know there are tools, just as widely deployed, passing in ifinfomsg. > That's what trigged inclusion of the patch above in the first place. > > Let's just declare this an iproute2 bug, fix iproute2 to pass > ifinfomsg too, and keep an eye out for when other folks run into this > problem. With the earlier patch reverted and the latest version iproute the problem is resolved. I'm suspecting the other issue may have been a 64/32 bit alignment issue since it seems like that was addressed recently. Odds are the message format for updated iproute will be incompatible with legacy API anyway. I will undo the revert and try tweaking the iproute2 call so that it makes use of the ifinfomsg. If that works okay I can send a patch. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
==================== From 88c5b5ce5cb57af6ca2a7cf4d5715fa320448ff9 Mon Sep 17 00:00:00 2001 From: Michael Riesch <michael.riesch@omicron.at> Date: Mon, 8 Apr 2013 05:45:26 +0000 Subject: [PATCH] rtnetlink: Call nlmsg_parse() with correct header length Signed-off-by: Michael Riesch <michael.riesch@omicron.at> Cc: "David S. Miller" <davem@davemloft.net> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Benc <jbenc@redhat.com> Cc: "Theodore Ts'o" <tytso@mit.edu> Cc: linux-kernel@vger.kernel.org Acked-by: Mark Rustad <mark.d.rustad@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> --- net/core/rtnetlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index b65441d..23854b5 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1072,7 +1072,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb) rcu_read_lock(); cb->seq = net->dev_base_seq; - if (nlmsg_parse(cb->nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, + if (nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, ifla_policy) >= 0) { if (tb[IFLA_EXT_MASK]) @@ -1922,7 +1922,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct nlmsghdr *nlh) u32 ext_filter_mask = 0; u16 min_ifinfo_dump_size = 0; - if (nlmsg_parse(nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX, + if (nlmsg_parse(nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX, ifla_policy) >= 0) { if (tb[IFLA_EXT_MASK]) ext_filter_mask = nla_get_u32(tb[IFLA_EXT_MASK]);