Patchwork [08/15] target-i386: kvmvapic: make expilict dependency on sysbus.h

login
register
mail settings
Submitter Igor Mammedov
Date April 25, 2013, 2:05 p.m.
Message ID <1366898737-6201-9-git-send-email-imammedo@redhat.com>
Download mbox | patch
Permalink /patch/239532/
State New
Headers show

Comments

Igor Mammedov - April 25, 2013, 2:05 p.m.
Allows kvmvapic to compile if sysbus.h is removed from apic_internal.h,
from which it is indirectly included.
sysbus.h will be removed from apic_internal.h after converting
APICs to ICCDevice.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
Note:
  split it in separate patch from "move APIC to ICC bus" patch to
  simplify review. Feel free to squash it back.
---
 hw/i386/kvmvapic.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Andreas Färber - April 28, 2013, 12:46 a.m.
Am 25.04.2013 16:05, schrieb Igor Mammedov:
> Allows kvmvapic to compile if sysbus.h is removed from apic_internal.h,
> from which it is indirectly included.
> sysbus.h will be removed from apic_internal.h after converting
> APICs to ICCDevice.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> Note:
>   split it in separate patch from "move APIC to ICC bus" patch to
>   simplify review. Feel free to squash it back.
> ---
>  hw/i386/kvmvapic.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Making header dependencies less accidental is a good deed, and APIC
conversion seems still blocked by MemoryRegion discussions ATM.

Andreas

Patch

diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c
index 3a10c07..5b558aa 100644
--- a/hw/i386/kvmvapic.c
+++ b/hw/i386/kvmvapic.c
@@ -12,6 +12,7 @@ 
 #include "sysemu/cpus.h"
 #include "sysemu/kvm.h"
 #include "hw/i386/apic_internal.h"
+#include "hw/sysbus.h"
 
 #define VAPIC_IO_PORT           0x7e