Patchwork [-next] rtc: rtc-pcf2123: fix error return code in pcf2123_probe()

login
register
mail settings
Submitter Wei Yongjun
Date April 25, 2013, 9:34 a.m.
Message ID <CAPgLHd-LgvQ_rka+tFHxufUThBZ6z6q1g8Cp8GKcyYa=Dp5-ZQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/239441/
State New
Headers show

Comments

Wei Yongjun - April 25, 2013, 9:34 a.m.
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Fix to return -ENODEV in the chip not found error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/rtc/rtc-pcf2123.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c
index 6a3f329..796a6c5 100644
--- a/drivers/rtc/rtc-pcf2123.c
+++ b/drivers/rtc/rtc-pcf2123.c
@@ -266,6 +266,7 @@  static int pcf2123_probe(struct spi_device *spi)
 
 	if (!(rxbuf[0] & 0x20)) {
 		dev_err(&spi->dev, "chip not found\n");
+		ret = -ENODEV;
 		goto kfree_exit;
 	}