Patchwork [1/4] powerpc/85xx: Add SEC6.0 device tree

login
register
mail settings
Submitter Po Liu
Date April 25, 2013, 1:54 a.m.
Message ID <1366854857-22791-1-git-send-email-Po.Liu@freescale.com>
Download mbox | patch
Permalink /patch/239377/
State Superseded
Headers show

Comments

Po Liu - April 25, 2013, 1:54 a.m.
From: Mingkai Hu <Mingkai.Hu@freescale.com>

Add device tree for SEC 6.0 used on C29x silicon.

Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
Singed-off-by: Po Liu <Po.Liu@freescale.com>
---
Base on git://git.am.freescale.net/gitolite/mirrors/linux-2.6.git
 arch/powerpc/boot/dts/fsl/qoriq-sec6.0-0.dtsi | 58 +++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 arch/powerpc/boot/dts/fsl/qoriq-sec6.0-0.dtsi
Scott Wood - July 22, 2013, 10:41 p.m.
On Thu, Apr 25, 2013 at 09:54:14AM +0800, Po Liu wrote:
> From: Mingkai Hu <Mingkai.Hu@freescale.com>
> 
> Add device tree for SEC 6.0 used on C29x silicon.
> 
> Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
> Singed-off-by: Po Liu <Po.Liu@freescale.com>

I've heard of patches being flamed, but here we want signing, not
singeing. :-)

Don't forget that you can use the -s option to have git add the signoff
for you.

> ---
> Base on git://git.am.freescale.net/gitolite/mirrors/linux-2.6.git

This URL is not accessible outside Freescale, so don't reference it when
posting patches publicly.

If your patch is against the latest upstream code, you don't need to say
anything special about that.  You only need to make a note when it's
against some other yet-to-be-merged tree or patch.

> +	compatible = "fsl,sec-v6.0", "fsl,sec-v5.2",
> +		     "fsl,sec-v5.0", "fsl,sec-v4.4",
> +		     "fsl,sec-v4.0";
> +	fsl,sec-era = <6>;
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +
> +	jr@1000 {
> +		compatible = "fsl,sec-v6.0-job-ring",
> +			     "fsl,sec-v5.2-job-ring",
> +			     "fsl,sec-v5.0-job-ring",
> +			     "fsl,sec-v4.4-job-ring",
> +			     "fsl,sec-v4.0-job-ring";
> +		reg	   = <0x1000 0x1000>;
> +	};
> +
> +	jr@2000 {
> +		compatible = "fsl,sec-v6.0-job-ring",
> +			     "fsl,sec-v5.2-job-ring",
> +			     "fsl,sec-v5.0-job-ring",
> +			     "fsl,sec-v4.4-job-ring",
> +			     "fsl,sec-v4.0-job-ring";
> +		reg	   = <0x2000 0x1000>;
> +	};

You claim compatibility with a bunch of prior SECs, but sec-v5.2 has four
job rings and an rtic node.  Likewise for the previous compatibles
listed.  This has two job rings and no rtic.

Can you point to where in the SEC v4.0 binding (I don't see a binding for
the subsequent versions), it says that these are optional?

-Scott
Liu Po-B43644 - July 23, 2013, 8:01 a.m.
>  -----Original Message-----
>  From: Wood Scott-B07421
>  Sent: Tuesday, July 23, 2013 6:41 AM
>  To: Liu Po-B43644
>  Cc: linuxppc-dev@ozlabs.org; Hu Mingkai-B21284
>  Subject: Re: [1/4] powerpc/85xx: Add SEC6.0 device tree
>  
>  On Thu, Apr 25, 2013 at 09:54:14AM +0800, Po Liu wrote:
>  > From: Mingkai Hu <Mingkai.Hu@freescale.com>
>  >
>  > Add device tree for SEC 6.0 used on C29x silicon.
>  >
>  > Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
>  > Singed-off-by: Po Liu <Po.Liu@freescale.com>
>  
>  I've heard of patches being flamed, but here we want signing, not
>  singeing. :-)
>  
>  Don't forget that you can use the -s option to have git add the signoff
>  for you.
>  
>  > ---
>  > Base on git://git.am.freescale.net/gitolite/mirrors/linux-2.6.git
>  
>  This URL is not accessible outside Freescale, so don't reference it when
>  posting patches publicly.
>  
>  If your patch is against the latest upstream code, you don't need to say
>  anything special about that.  You only need to make a note when it's
>  against some other yet-to-be-merged tree or patch.
>  
>  > +	compatible = "fsl,sec-v6.0", "fsl,sec-v5.2",
>  > +		     "fsl,sec-v5.0", "fsl,sec-v4.4",
>  > +		     "fsl,sec-v4.0";
>  > +	fsl,sec-era = <6>;
>  > +	#address-cells = <1>;
>  > +	#size-cells = <1>;
>  > +
>  > +	jr@1000 {
>  > +		compatible = "fsl,sec-v6.0-job-ring",
>  > +			     "fsl,sec-v5.2-job-ring",
>  > +			     "fsl,sec-v5.0-job-ring",
>  > +			     "fsl,sec-v4.4-job-ring",
>  > +			     "fsl,sec-v4.0-job-ring";
>  > +		reg	   = <0x1000 0x1000>;
>  > +	};
>  > +
>  > +	jr@2000 {
>  > +		compatible = "fsl,sec-v6.0-job-ring",
>  > +			     "fsl,sec-v5.2-job-ring",
>  > +			     "fsl,sec-v5.0-job-ring",
>  > +			     "fsl,sec-v4.4-job-ring",
>  > +			     "fsl,sec-v4.0-job-ring";
>  > +		reg	   = <0x2000 0x1000>;
>  > +	};
>  
>  You claim compatibility with a bunch of prior SECs, but sec-v5.2 has four
>  job rings and an rtic node.  Likewise for the previous compatibles listed.
>  This has two job rings and no rtic.
So, shall I remove "fsl,sec-v5.2","fsl,sec-v5.0", "fsl,sec-v4.4", "fsl,sec-v4.0" since all other SEC with 4 job rings? and only leave "fsl,sec-v6.0"?
>  
>  Can you point to where in the SEC v4.0 binding (I don't see a binding for
>  the subsequent versions), it says that these are optional?
I found SEC V4.0 in file qoriq-sec4.0-0.dtsi. If "fsl,sec-v4.0" not in the compatible list, it is no use in this compatible list. But seems keep the "fsl,sec-v4.0-job-ring" job ring compatible is ok. Is that what you were ask?
>  
>  -Scott
Scott Wood - July 23, 2013, 11:24 p.m.
On 07/23/2013 03:01:17 AM, Liu Po-B43644 wrote:
> 
> >  -----Original Message-----
> >  From: Wood Scott-B07421
> >  Sent: Tuesday, July 23, 2013 6:41 AM
> >  To: Liu Po-B43644
> >  Cc: linuxppc-dev@ozlabs.org; Hu Mingkai-B21284
> >  Subject: Re: [1/4] powerpc/85xx: Add SEC6.0 device tree
> >
> >  On Thu, Apr 25, 2013 at 09:54:14AM +0800, Po Liu wrote:
> >  > From: Mingkai Hu <Mingkai.Hu@freescale.com>
> >  >
> >  > Add device tree for SEC 6.0 used on C29x silicon.
> >  >
> >  > Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
> >  > Singed-off-by: Po Liu <Po.Liu@freescale.com>
> >
> >  I've heard of patches being flamed, but here we want signing, not
> >  singeing. :-)
> >
> >  Don't forget that you can use the -s option to have git add the  
> signoff
> >  for you.
> >
> >  > ---
> >  > Base on git://git.am.freescale.net/gitolite/mirrors/linux-2.6.git
> >
> >  This URL is not accessible outside Freescale, so don't reference  
> it when
> >  posting patches publicly.
> >
> >  If your patch is against the latest upstream code, you don't need  
> to say
> >  anything special about that.  You only need to make a note when  
> it's
> >  against some other yet-to-be-merged tree or patch.
> >
> >  > +	compatible = "fsl,sec-v6.0", "fsl,sec-v5.2",
> >  > +		     "fsl,sec-v5.0", "fsl,sec-v4.4",
> >  > +		     "fsl,sec-v4.0";
> >  > +	fsl,sec-era = <6>;
> >  > +	#address-cells = <1>;
> >  > +	#size-cells = <1>;
> >  > +
> >  > +	jr@1000 {
> >  > +		compatible = "fsl,sec-v6.0-job-ring",
> >  > +			     "fsl,sec-v5.2-job-ring",
> >  > +			     "fsl,sec-v5.0-job-ring",
> >  > +			     "fsl,sec-v4.4-job-ring",
> >  > +			     "fsl,sec-v4.0-job-ring";
> >  > +		reg	   = <0x1000 0x1000>;
> >  > +	};
> >  > +
> >  > +	jr@2000 {
> >  > +		compatible = "fsl,sec-v6.0-job-ring",
> >  > +			     "fsl,sec-v5.2-job-ring",
> >  > +			     "fsl,sec-v5.0-job-ring",
> >  > +			     "fsl,sec-v4.4-job-ring",
> >  > +			     "fsl,sec-v4.0-job-ring";
> >  > +		reg	   = <0x2000 0x1000>;
> >  > +	};
> >
> >  You claim compatibility with a bunch of prior SECs, but sec-v5.2  
> has four
> >  job rings and an rtic node.  Likewise for the previous compatibles  
> listed.
> >  This has two job rings and no rtic.
> So, shall I remove "fsl,sec-v5.2","fsl,sec-v5.0", "fsl,sec-v4.4",  
> "fsl,sec-v4.0" since all other SEC with 4 job rings? and only leave  
> "fsl,sec-v6.0"?

Yes, I think so.

> >  Can you point to where in the SEC v4.0 binding (I don't see a  
> binding for
> >  the subsequent versions), it says that these are optional?
> I found SEC V4.0 in file qoriq-sec4.0-0.dtsi. If "fsl,sec-v4.0" not  
> in the compatible list, it is no use in this compatible list. But  
> seems keep the "fsl,sec-v4.0-job-ring" job ring compatible is ok. Is  
> that what you were ask?

No, I was talking about binding documents:
Documentation/devicetree/bindings/crypto/

-Scott

Patch

diff --git a/arch/powerpc/boot/dts/fsl/qoriq-sec6.0-0.dtsi b/arch/powerpc/boot/dts/fsl/qoriq-sec6.0-0.dtsi
new file mode 100644
index 0000000..eb99a46
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/qoriq-sec6.0-0.dtsi
@@ -0,0 +1,58 @@ 
+/*
+ * QorIQ Sec/Crypto 6.0 device tree stub
+ *
+ * Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in the
+ *       documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ *       names of its contributors may be used to endorse or promote products
+ *       derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+	compatible = "fsl,sec-v6.0", "fsl,sec-v5.2",
+		     "fsl,sec-v5.0", "fsl,sec-v4.4",
+		     "fsl,sec-v4.0";
+	fsl,sec-era = <6>;
+	#address-cells = <1>;
+	#size-cells = <1>;
+
+	jr@1000 {
+		compatible = "fsl,sec-v6.0-job-ring",
+			     "fsl,sec-v5.2-job-ring",
+			     "fsl,sec-v5.0-job-ring",
+			     "fsl,sec-v4.4-job-ring",
+			     "fsl,sec-v4.0-job-ring";
+		reg	   = <0x1000 0x1000>;
+	};
+
+	jr@2000 {
+		compatible = "fsl,sec-v6.0-job-ring",
+			     "fsl,sec-v5.2-job-ring",
+			     "fsl,sec-v5.0-job-ring",
+			     "fsl,sec-v4.4-job-ring",
+			     "fsl,sec-v4.0-job-ring";
+		reg	   = <0x2000 0x1000>;
+	};