Message ID | 49ABD014.3010006@gmail.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Roel Kluin <roel.kluin@gmail.com> Date: Mon, 02 Mar 2009 13:24:52 +0100 > David Miller wrote: > > From: Herbert Xu <herbert@gondor.apana.org.au> > > Date: Mon, 2 Mar 2009 12:30:56 +0800 > > > >> Either cnt needs to be promoted, or you need to limit len to INT_MAX. > > > > Right, since the positive range of 'size_t' can exceed that of 'int' > > like this then? > ------------------------------>8-------------8<--------------------------------- > promote 'cnt' to size_t, to match 'len'. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c index 25524d4..59f5b5e 100644 --- a/net/ipv4/tcp_probe.c +++ b/net/ipv4/tcp_probe.c @@ -165,9 +165,10 @@ static int tcpprobe_sprint(char *tbuf, int n) static ssize_t tcpprobe_read(struct file *file, char __user *buf, size_t len, loff_t *ppos) { - int error = 0, cnt = 0; + int error = 0; + size_t cnt = 0; - if (!buf || len < 0) + if (!buf) return -EINVAL; while (cnt < len) {