Patchwork [PATCH-e2fsprogs] Allow tune2fs -I if only one group per flex

login
register
mail settings
Submitter Peng Tao
Date March 2, 2009, 8:29 a.m.
Message ID <1235982560-7725-1-git-send-email-bergwolf@gmail.com>
Download mbox | patch
Permalink /patch/23927/
State New
Headers show

Comments

Peng Tao - March 2, 2009, 8:29 a.m.
This can be caused by tune2fs -O flex_bg.
And tune2fs -I should work okay for such partitions.

Signed-off-by: Peng Tao <bergwolf@gmail.com>
---
 misc/tune2fs.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Theodore Ts'o - March 2, 2009, 12:40 p.m.
On Mon, Mar 02, 2009 at 04:29:20PM +0800, Peng Tao wrote:
> This can be caused by tune2fs -O flex_bg.
> And tune2fs -I should work okay for such partitions.

It will *probably* work, but again, it would be better to check to
make sure it really was caused by an accidental "tune2fs -O flex_bg".

     	     	    	       	     - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/misc/tune2fs.c b/misc/tune2fs.c
index 887a702..ee982e5 100644
--- a/misc/tune2fs.c
+++ b/misc/tune2fs.c
@@ -1715,7 +1715,8 @@  retry_open:
 			exit(1);
 		}
 		if (fs->super->s_feature_incompat &
-		    EXT4_FEATURE_INCOMPAT_FLEX_BG) {
+		    EXT4_FEATURE_INCOMPAT_FLEX_BG &&
+		    fs->super->s_log_groups_per_flex) {
 			fputs(_("Changing the inode size not supported for "
 				"filesystems with the flex_bg\n"
 				"feature enabled.\n"),