From patchwork Mon Mar 2 06:41:28 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Katiyar X-Patchwork-Id: 23924 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 9FFBFDDF34 for ; Mon, 2 Mar 2009 17:41:39 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755440AbZCBGli (ORCPT ); Mon, 2 Mar 2009 01:41:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755535AbZCBGli (ORCPT ); Mon, 2 Mar 2009 01:41:38 -0500 Received: from ti-out-0910.google.com ([209.85.142.184]:2955 "EHLO ti-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755440AbZCBGlh (ORCPT ); Mon, 2 Mar 2009 01:41:37 -0500 Received: by ti-out-0910.google.com with SMTP id d10so2723280tib.23 for ; Sun, 01 Mar 2009 22:41:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=wswL7TAzKTW+Rm4nIAua6cwXu/k+rftVYdPch8zT9D0=; b=qbY9UtmJ5kiB/ALCXgRrmjpr+mCZH//H2o4/xd1qINfVEv40LSIaod1MqLgRqs0Ha2 lAk25xenuuOU6N7hz/E09SCFDRuEqqULVNARWNr3Hk2LFz5TUlhbZPkz0Cnn/12LK1fD OVFuXHP3TuwI0qqjJPu0gi1JbSKoiFTXm8mlo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=JHd/Bel2Eyfzs0XxwRthEbCUnOrKJGvoe5cBsJZb4tchY9qW+r1LpsRySuy9/6+Ji8 qV7nAGkW6K7BCJ1PfhBRXWvaE2G5s3hD1ZAAMOn7WJiwRkEkOozImXQxAufi/LwlmbOB bzpUBUedpA9P2iNEr8vdL+NrmKWaNxU8iSiZc= MIME-Version: 1.0 Received: by 10.110.40.8 with SMTP id n8mr8217676tin.28.1235976088844; Sun, 01 Mar 2009 22:41:28 -0800 (PST) Date: Mon, 2 Mar 2009 12:11:28 +0530 Message-ID: Subject: [PATCH] jbd2: Remove unnecessary check for NULL after calling kzalloc with __GFP_NOFAIL From: Manish Katiyar To: ext4 Cc: mkatiyar@gmail.com Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Since new_transaction is allocated with __GFP_NOFAIL flags, NULL check for the returned value is not needed. Signed-off-by: Manish Katiyar --- fs/jbd2/transaction.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c index 46b4e34..e22f993 100644 --- a/fs/jbd2/transaction.c +++ b/fs/jbd2/transaction.c @@ -101,14 +101,9 @@ static int start_this_handle(journal_t *journal, handle_t *handle) } alloc_transaction: - if (!journal->j_running_transaction) { + if (!journal->j_running_transaction) new_transaction = kzalloc(sizeof(*new_transaction), GFP_NOFS|__GFP_NOFAIL); - if (!new_transaction) { - ret = -ENOMEM; - goto out; - } - } jbd_debug(3, "New handle %p going live.\n", handle);