Patchwork jbd2: Remove unnecessary check for NULL after calling kzalloc with __GFP_NOFAIL

login
register
mail settings
Submitter Manish Katiyar
Date March 2, 2009, 6:41 a.m.
Message ID <ea11fea30903012241u44d31e6aw6c18af7c06f60734@mail.gmail.com>
Download mbox | patch
Permalink /patch/23924/
State Superseded
Headers show

Comments

Manish Katiyar - March 2, 2009, 6:41 a.m.
Since new_transaction is allocated with __GFP_NOFAIL flags, NULL check
for the returned value is
not needed.

Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
---
 fs/jbd2/transaction.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

Patch

diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 46b4e34..e22f993 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -101,14 +101,9 @@  static int start_this_handle(journal_t *journal,
handle_t *handle)
 	}

 alloc_transaction:
-	if (!journal->j_running_transaction) {
+	if (!journal->j_running_transaction)
 		new_transaction = kzalloc(sizeof(*new_transaction),
 						GFP_NOFS|__GFP_NOFAIL);
-		if (!new_transaction) {
-			ret = -ENOMEM;
-			goto out;
-		}
-	}

 	jbd_debug(3, "New handle %p going live.\n", handle);