Patchwork [2/2] libxml++: new package

login
register
mail settings
Submitter nmenegale
Date April 24, 2013, 3:11 p.m.
Message ID <1366816283-11363-2-git-send-email-nicolas.menegale@openwide.fr>
Download mbox | patch
Permalink /patch/239228/
State Accepted
Headers show

Comments

nmenegale - April 24, 2013, 3:11 p.m.
Signed-off-by: Nicolas Ménégale <nicolas.menegale@openwide.fr>
---
v2: minor modifications: empty lines between headers and variable, license,
tar.xz instead of tar.bz2
libxml++ is a C++ wrapper for libxml2 it has glibmm as dependency
Signed-off-by: nmenegale <nicolas.menegale@openwide.fr>
---
 package/Config.in            |  1 +
 package/libxmlpp/Config.in   | 13 +++++++++++++
 package/libxmlpp/libxmlpp.mk | 17 +++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/libxmlpp/Config.in
 create mode 100644 package/libxmlpp/libxmlpp.mk
Peter Korsgaard - April 24, 2013, 7:49 p.m.
>>>>> "nmenegale" == nmenegale  <nicolas.menegale@openwide.fr> writes:

 nmenegale> Signed-off-by: Nicolas Ménégale <nicolas.menegale@openwide.fr>
 nmenegale> ---
 nmenegale> v2: minor modifications: empty lines between headers and variable, license,
 nmenegale> tar.xz instead of tar.bz2
 nmenegale> libxml++ is a C++ wrapper for libxml2 it has glibmm as dependency

This line should imho have been part of the commit message.

 nmenegale> Signed-off-by: nmenegale <nicolas.menegale@openwide.fr>
 nmenegale> ---
 nmenegale>  package/Config.in            |  1 +
 nmenegale>  package/libxmlpp/Config.in   | 13 +++++++++++++
 nmenegale>  package/libxmlpp/libxmlpp.mk | 17 +++++++++++++++++
 nmenegale>  3 files changed, 31 insertions(+)
 nmenegale>  create mode 100644 package/libxmlpp/Config.in
 nmenegale>  create mode 100644 package/libxmlpp/libxmlpp.mk

 nmenegale> diff --git a/package/Config.in b/package/Config.in
 nmenegale> index ca947d9..ede0ba0 100644
 nmenegale> --- a/package/Config.in
 nmenegale> +++ b/package/Config.in
 nmenegale> @@ -623,6 +623,7 @@ source "package/json-glib/Config.in"
 nmenegale>  source "package/libroxml/Config.in"
 nmenegale>  source "package/libxml-parser-perl/Config.in"
 nmenegale>  source "package/libxml2/Config.in"
 nmenegale> +source "package/libxmlpp/Config.in"
 nmenegale>  source "package/libxslt/Config.in"
 nmenegale>  source "package/libyaml/Config.in"
 nmenegale>  source "package/mxml/Config.in"
 nmenegale> diff --git a/package/libxmlpp/Config.in b/package/libxmlpp/Config.in
 nmenegale> new file mode 100644
 nmenegale> index 0000000..3c9845c
 nmenegale> --- /dev/null
 nmenegale> +++ b/package/libxmlpp/Config.in
 nmenegale> @@ -0,0 +1,13 @@
 nmenegale> +config BR2_PACKAGE_LIBXMLPP
 nmenegale> +	bool "libxmlpp"
 nmenegale> +	select BR2_PACKAGE_LIBXML2
 nmenegale> +	select BR2_PACKAGE_GLIBMM
 nmenegale> +	depends on BR2_INSTALL_LIBSTDCPP
 nmenegale> +	depends on BR2_USE_WCHAR
 nmenegale> +	help
 nmenegale> +	  libxml++ is a C++ wrapper for the libxml XML parser library.	
 nmenegale> +	  

Trailing spaces.

 nmenegale> +	  http://libxmlplusplus.sourceforge.net/
 nmenegale> +
 nmenegale> +comment "LibXML++ requires a toolchain with C++ & WCHAR support enabled"

You have a mix of libxmlpp / libxml++ and LibXML++. I've changed them
all to be libxml++.

Committed with those issues fixed, thanks.

Patch

diff --git a/package/Config.in b/package/Config.in
index ca947d9..ede0ba0 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -623,6 +623,7 @@  source "package/json-glib/Config.in"
 source "package/libroxml/Config.in"
 source "package/libxml-parser-perl/Config.in"
 source "package/libxml2/Config.in"
+source "package/libxmlpp/Config.in"
 source "package/libxslt/Config.in"
 source "package/libyaml/Config.in"
 source "package/mxml/Config.in"
diff --git a/package/libxmlpp/Config.in b/package/libxmlpp/Config.in
new file mode 100644
index 0000000..3c9845c
--- /dev/null
+++ b/package/libxmlpp/Config.in
@@ -0,0 +1,13 @@ 
+config BR2_PACKAGE_LIBXMLPP
+	bool "libxmlpp"
+	select BR2_PACKAGE_LIBXML2
+	select BR2_PACKAGE_GLIBMM
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_USE_WCHAR
+	help
+	  libxml++ is a C++ wrapper for the libxml XML parser library.	
+	  
+	  http://libxmlplusplus.sourceforge.net/
+
+comment "LibXML++ requires a toolchain with C++ & WCHAR support enabled"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
diff --git a/package/libxmlpp/libxmlpp.mk b/package/libxmlpp/libxmlpp.mk
new file mode 100644
index 0000000..1ed60de
--- /dev/null
+++ b/package/libxmlpp/libxmlpp.mk
@@ -0,0 +1,17 @@ 
+#############################################################
+#
+# LibXML++
+#
+#############################################################
+
+LIBXMLPP_VERSION_MAJOR = 2.34
+LIBXMLPP_VERSION_MINOR = 2
+LIBXMLPP_VERSION = $(LIBXMLPP_VERSION_MAJOR).$(LIBXMLPP_VERSION_MINOR)
+LIBXMLPP_LICENSE = LGPLv2.1 (library), LGPLv2+ (examples)
+LIBXMLPP_LICENSE_FILE = COPYING
+LIBXMLPP_SOURCE = libxml++-$(LIBXMLPP_VERSION).tar.xz
+LIBXMLPP_SITE = http://ftp.gnome.org/pub/GNOME/sources/libxml++/$(LIBXMLPP_VERSION_MAJOR)
+LIBXMLPP_INSTALL_STAGING = YES
+LIBXMLPP_DEPENDENCIES = libxml2 glibmm host-pkgconf
+
+$(eval $(autotools-package))