From patchwork Wed Apr 24 12:08:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 239175 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 26A872C00C8 for ; Wed, 24 Apr 2013 22:09:14 +1000 (EST) Received: from localhost ([::1]:47061 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUyVc-00030V-9K for incoming@patchwork.ozlabs.org; Wed, 24 Apr 2013 08:09:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUyVM-0002y1-Lu for qemu-devel@nongnu.org; Wed, 24 Apr 2013 08:08:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUyVH-00027H-RU for qemu-devel@nongnu.org; Wed, 24 Apr 2013 08:08:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39034 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUyVH-000276-Kt for qemu-devel@nongnu.org; Wed, 24 Apr 2013 08:08:51 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 13CAEA3A49; Wed, 24 Apr 2013 14:08:49 +0200 (CEST) Message-ID: <5177CB4D.8040705@suse.de> Date: Wed, 24 Apr 2013 14:08:45 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Igor Mammedov References: <1366705795-24732-1-git-send-email-imammedo@redhat.com> <1366705795-24732-3-git-send-email-imammedo@redhat.com> <5176AFDA.1050700@suse.de> In-Reply-To: <5176AFDA.1050700@suse.de> X-Enigmail-Version: 1.6a1pre X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 195.135.220.15 Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, gleb@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, quintela@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, blauwirbel@gmail.com, yang.z.zhang@intel.com, alex.williamson@redhat.com, kraxel@redhat.com, anthony.perard@citrix.com, pbonzini@redhat.com, armbru@redhat.com, stefano.stabellini@eu.citrix.com, rth@twiddle.net Subject: Re: [Qemu-devel] [PATCH 02/21] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Am 23.04.2013 17:59, schrieb Andreas Färber: > Am 23.04.2013 10:29, schrieb Igor Mammedov: >> ... to synchronize CPU state to KVM >> >> Signed-off-by: Igor Mammedov >> Reviewed-by: Eduardo Habkost >> --- >> v2: >> * linking kvm-stub.o to *-user target moved in separate patch > > Thanks, applied to qom-cpu: > https://github.com/afaerber/qemu-cpu/commits/qom-cpu To facilitate conflict resolution for future patches, I have modified this to match other functions in there and to spare refactorings: Andreas diff --git a/qom/cpu.c b/qom/cpu.c index 0c76712..66f7c00 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -58,8 +58,10 @@ static ObjectClass *cpu_common_class_by_name(const char *cpu_model) static void cpu_common_realizefn(DeviceState *dev, Error **errp) { + CPUState *cpu = CPU(dev); + if (dev->hotplugged) { - cpu_synchronize_post_init(CPU(dev)); + cpu_synchronize_post_init(cpu); } }