Patchwork RFA: Fix declaration of default value of TARGET_NARROW_VOLATILE_BITFIELD

login
register
mail settings
Submitter Nick Clifton
Date April 24, 2013, 11:01 a.m.
Message ID <87ip3cchut.fsf@redhat.com>
Download mbox | patch
Permalink /patch/239159/
State New
Headers show

Comments

Nick Clifton - April 24, 2013, 11:01 a.m.
Hi Guys,

  The TARGET_NARROW_VOLATILE_BITFIELD target macro defaults to false:

    DEFHOOK
    (narrow_volatile_bitfield,
     "",
     bool, (void),
     hook_bool_void_false)
  
  but the documentation currently states that it defaults to
  !TARGET_STRICT_ALIGN.  The patch below corrects this, and also fixes a
  small typo in the description of TARGET_CANONICALIZE_COMPARISON.

  Ok to apply ?

Cheers
  Nick

gcc/ChangeLog
2013-04-24  Nick Clifton  <nickc@redhat.com>

	* doc/tm.texi.in (TARGET_NARROW_VOLATILE_BITFIELD): Change the
	default to false.
	(TARGET_CANONICALIZE_COMPARISON); Correct typo.
	* doc/tm.texi: Regenerate.
Gerald Pfeifer - Aug. 18, 2013, 7:04 p.m.
Hi Nick,

it looks this patch did not get applied.  Is this because you
failed to get approval?

With a patch Joseph did recently, this would now be in gcc/target.def,
and from what I can see both parts of the patch are fine.

Unless anyone objects, can you please ago ahead and commit an
update patch?

Thanks,
Gerald

On Wed, 24 Apr 2013, Nick Clifton wrote:
>   The TARGET_NARROW_VOLATILE_BITFIELD target macro defaults to false:
> 
>     DEFHOOK
>     (narrow_volatile_bitfield,
>      "",
>      bool, (void),
>      hook_bool_void_false)
>   
>   but the documentation currently states that it defaults to
>   !TARGET_STRICT_ALIGN.  The patch below corrects this, and also fixes a
>   small typo in the description of TARGET_CANONICALIZE_COMPARISON.
> 
>   Ok to apply ?
> 
> Cheers
>   Nick
> 
> gcc/ChangeLog
> 2013-04-24  Nick Clifton  <nickc@redhat.com>
> 
> 	* doc/tm.texi.in (TARGET_NARROW_VOLATILE_BITFIELD): Change the
> 	default to false.
> 	(TARGET_CANONICALIZE_COMPARISON); Correct typo.
> 	* doc/tm.texi: Regenerate.
> 
> Index: gcc/doc/tm.texi.in
> ===================================================================
> --- gcc/doc/tm.texi.in	(revision 198216)
> +++ gcc/doc/tm.texi.in	(working copy)
> @@ -1236,7 +1236,7 @@
>  should use the narrowest mode possible.  It should return @code{false} if
>  these accesses should use the bitfield container type.
>  
> -The default is @code{!TARGET_STRICT_ALIGN}.
> +The default is @code{false}.
>  @end deftypefn
>  
>  @hook TARGET_MEMBER_TYPE_FORCES_BLK
> @@ -5947,7 +5947,7 @@
>  valid but will see if the resulting insn matches a pattern in the
>  @file{md} file.
>  
> -You need not to implement this hook if it would never change the
> +You need not implement this hook if it would never change the
>  comparison code or operands.
>  @end deftypefn

Patch

Index: gcc/doc/tm.texi.in
===================================================================
--- gcc/doc/tm.texi.in	(revision 198216)
+++ gcc/doc/tm.texi.in	(working copy)
@@ -1236,7 +1236,7 @@ 
 should use the narrowest mode possible.  It should return @code{false} if
 these accesses should use the bitfield container type.
 
-The default is @code{!TARGET_STRICT_ALIGN}.
+The default is @code{false}.
 @end deftypefn
 
 @hook TARGET_MEMBER_TYPE_FORCES_BLK
@@ -5947,7 +5947,7 @@ 
 valid but will see if the resulting insn matches a pattern in the
 @file{md} file.
 
-You need not to implement this hook if it would never change the
+You need not implement this hook if it would never change the
 comparison code or operands.
 @end deftypefn