Patchwork [0/4] Wayland/weston packages

login
register
mail settings
Submitter Thomas Petazzoni
Date April 24, 2013, 2:27 a.m.
Message ID <20130424042732.2cbfdc43@skate>
Download mbox | patch
Permalink /patch/239033/
State Changes Requested
Headers show

Comments

Thomas Petazzoni - April 24, 2013, 2:27 a.m.
Dear Arnout Vandecappelle,

On Mon, 22 Apr 2013 23:33:44 +0200, Arnout Vandecappelle wrote:

>   Maybe moving it into "X libraries and helper libraries" is more 
> relevant? I expect that other packages (mesa3d?) may also move there.

Good idea. However, it means that we have from package/Config.in an
include to a Config.in in package/x11r7/<foo>/Config.in:


Best regards,

Thomas
Arnout Vandecappelle - April 24, 2013, 12:44 p.m.
On 24/04/13 04:27, Thomas Petazzoni wrote:
> Dear Arnout Vandecappelle,
>
> On Mon, 22 Apr 2013 23:33:44 +0200, Arnout Vandecappelle wrote:
>
>>    Maybe moving it into "X libraries and helper libraries" is more
>> relevant? I expect that other packages (mesa3d?) may also move there.
>
> Good idea. However, it means that we have from package/Config.in an
> include to a Config.in in package/x11r7/<foo>/Config.in:
>
> diff --git a/package/Config.in b/package/Config.in
> index ab514c7..3a19243 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -155,6 +155,7 @@ source "package/x11r7/Config.in"
>   comment "X libraries and helper libraries"
>   source "package/liberation/Config.in"
>   source "package/libsexy/Config.in"
> +source "package/x11r7/xkeyboard-config/Config.in"
>
> Does it matter, or should I also move the xkeyboard-config directory
> outside of package/x11r7/ ?

  If it no longer depends on xorg7, I would vote to move it out.

  Regards,
  Arnout
Thomas Petazzoni - April 24, 2013, 2:23 p.m.
Dear Arnout Vandecappelle,

On Wed, 24 Apr 2013 14:44:56 +0200, Arnout Vandecappelle wrote:

> > Does it matter, or should I also move the xkeyboard-config directory
> > outside of package/x11r7/ ?
> 
>   If it no longer depends on xorg7, I would vote to move it out.

It still depends on host-xapp_xkbcomp, but since it's a host package,
it can be used even if BR2_PACKAGE_XORG7 is not enabled, which is why I
could move the xkeyboard-config/Config.in inclusion outside of the
BR2_PACKAGE_XORG7. The other dependencies are runtime dependencies that
are only needed in a X.org context.

Best regards,

Thomas
Peter Korsgaard - April 24, 2013, 8:09 p.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 >> If it no longer depends on xorg7, I would vote to move it out.

 Thomas> It still depends on host-xapp_xkbcomp, but since it's a host
 Thomas> package, it can be used even if BR2_PACKAGE_XORG7 is not
 Thomas> enabled, which is why I could move the
 Thomas> xkeyboard-config/Config.in inclusion outside of the
 Thomas> BR2_PACKAGE_XORG7. The other dependencies are runtime
 Thomas> dependencies that are only needed in a X.org context.

Ok, sounds good.

Patch

diff --git a/package/Config.in b/package/Config.in
index ab514c7..3a19243 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -155,6 +155,7 @@  source "package/x11r7/Config.in"
 comment "X libraries and helper libraries"
 source "package/liberation/Config.in"
 source "package/libsexy/Config.in"
+source "package/x11r7/xkeyboard-config/Config.in"

Does it matter, or should I also move the xkeyboard-config directory
outside of package/x11r7/ ?