From patchwork Sat Feb 28 14:44:42 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 23893 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 68702DDE06 for ; Sun, 1 Mar 2009 01:45:54 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752737AbZB1Op1 (ORCPT ); Sat, 28 Feb 2009 09:45:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753753AbZB1OpX (ORCPT ); Sat, 28 Feb 2009 09:45:23 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:53706 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752971AbZB1Oo4 (ORCPT ); Sat, 28 Feb 2009 09:44:56 -0500 Received: from wrl-59.cs.helsinki.fi (wrl-59.cs.helsinki.fi [128.214.166.179]) (AUTH: PLAIN cs-relay, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by mail.cs.helsinki.fi with esmtp; Sat, 28 Feb 2009 16:44:43 +0200 id 0008C1FE.49A94DDB.00003B7B Received: by wrl-59.cs.helsinki.fi (Postfix, from userid 50795) id 84A3216B16C; Sat, 28 Feb 2009 16:44:43 +0200 (EET) From: "=?ISO-8859-1?Q?Ilpo_J=E4rvinen?=" To: David Miller Cc: netdev@vger.kernel.org, "=?utf-8?q?Ilpo=20J=C3=A4rvinen?=" Subject: [PATCH net-next 17/17] tcp: get rid of two unnecessary u16s in TCP skb flags copying Date: Sat, 28 Feb 2009 16:44:42 +0200 Message-Id: <12358322832837-git-send-email-ilpo.jarvinen@helsinki.fi> X-Mailer: git-send-email 1.5.2.2 In-Reply-To: <12358322833023-git-send-email-ilpo.jarvinen@helsinki.fi> References: <12358322821815-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322821434-git-send-email-ilpo.jarvinen@helsinki.fi> <1235832282317-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322823783-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322821182-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322832831-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322831953-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322831147-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322833102-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322832711-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322834113-git-send-email-ilpo.jarvinen@helsinki.fi> <1235832283214-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322831599-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322832879-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322831019-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322831223-git-send-email-ilpo.jarvinen@helsinki.fi> <12358322833023-git-send-email-ilpo.jarvinen@helsinki.fi> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ilpo Järvinen I guess these fields were one day 16-bit in the struct but nowadays they're just using 8 bits anyway. This is just a precaution, didn't result any change in my case but who knows what all those varying gcc versions & options do. I've been told that 16-bit is not so nice with some cpus. Signed-off-by: Ilpo Järvinen --- net/ipv4/tcp_output.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index d5c7245..274110e 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -766,7 +766,7 @@ int tcp_fragment(struct sock *sk, struct sk_buff *skb, u32 len, struct sk_buff *buff; int nsize, old_factor; int nlen; - u16 flags; + u8 flags; BUG_ON(len > skb->len); @@ -1281,7 +1281,7 @@ static int tso_fragment(struct sock *sk, struct sk_buff *skb, unsigned int len, { struct sk_buff *buff; int nlen = skb->len - len; - u16 flags; + u8 flags; /* All of a TSO frame must be composed of paged data. */ if (skb->len != skb->data_len)