diff mbox

[1/2] glibmm: new package

Message ID 1366726167-3396-1-git-send-email-nicolas.menegale@openwide.fr
State Superseded
Headers show

Commit Message

nmenegale April 23, 2013, 2:09 p.m. UTC 
Signed-off-by: Nicolas Ménégale  <nicolas.menegale@openwide.fr>
---
v0: initial commit
glibmm is also a dependency of libxml++ (the libxml2 c++ wrapper)
Signed-off-by: nmenegale <nicolas.menegale@openwide.fr>
---
 package/Config.in        |  1 +
 package/glibmm/Config.in |  8 ++++++++
 package/glibmm/glibmm.mk | 13 +++++++++++++
 3 files changed, 22 insertions(+)
 create mode 100644 package/glibmm/Config.in
 create mode 100644 package/glibmm/glibmm.mk

Comments

Gustavo Zacarias April 23, 2013, 2:20 p.m. UTC | #1 
On 04/23/2013 11:09 AM, nmenegale wrote:

> +++ b/package/glibmm/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_GLIBMM
> +	bool "glibmm"
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_LIBSIGC
> +	help
> +	  The GLibmm package is a set of C++ bindings for GLib. 
> +	  	
> +	  http://www.gtkmm.org/

This should depend on BR2_INSTALL_LIBSTDCPP since it requires a
toolchain with C++ support, with a comment otherwise like other packages
do (look at package/protobuf/Config.in for an example).
Same case with libxml++.

> +++ b/package/glibmm/glibmm.mk
> @@ -0,0 +1,13 @@
> +#############################################################
> +#
> +# Glibmm
> +#
> +#############################################################
> +GLIBMM_VERSION = 2.30.1
> +GLIBMM_LICENSE = LGPLv2.1
> +GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
> +GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30
> +GLIBMM_INSTALL_STAGING = YES
> +GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
> +
> +$(eval $(autotools-package))

You define GLIBMM_LICENSE but no GLIBMM_LICENSE_FILES, could you fix
that since glibmm ships them?
libglib2 depends on BR2_USE_WCHAR, you should add that too as a depend
in Config.in
Otherwise it's looking good, thanks.
Regards.
Thomas Petazzoni April 23, 2013, 2:31 p.m. UTC | #2 
Dear Gustavo Zacarias,

On Tue, 23 Apr 2013 11:20:39 -0300, Gustavo Zacarias wrote:

> libglib2 depends on BR2_USE_WCHAR, you should add that too as a depend
> in Config.in

And therefore the libxml++ should also carry this dependency as a
consequence.

Thomas
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 06bcdef..c75c3ec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -558,6 +558,7 @@  source "package/fftw/Config.in"
 source "package/libargtable2/Config.in"
 source "package/argp-standalone/Config.in"
 source "package/boost/Config.in"
+source "package/glibmm/Config.in"
 source "package/gmp/Config.in"
 source "package/gsl/Config.in"
 source "package/gtest/Config.in"
diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in
new file mode 100644
index 0000000..16a7a9b
--- /dev/null
+++ b/package/glibmm/Config.in
@@ -0,0 +1,8 @@ 
+config BR2_PACKAGE_GLIBMM
+	bool "glibmm"
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBSIGC
+	help
+	  The GLibmm package is a set of C++ bindings for GLib. 
+	  	
+	  http://www.gtkmm.org/
diff --git a/package/glibmm/glibmm.mk b/package/glibmm/glibmm.mk
new file mode 100644
index 0000000..f7f49bd
--- /dev/null
+++ b/package/glibmm/glibmm.mk
@@ -0,0 +1,13 @@ 
+#############################################################
+#
+# Glibmm
+#
+#############################################################
+GLIBMM_VERSION = 2.30.1
+GLIBMM_LICENSE = LGPLv2.1
+GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
+GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30
+GLIBMM_INSTALL_STAGING = YES
+GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
+
+$(eval $(autotools-package))