From patchwork Tue Apr 23 00:31:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 238702 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F16292C0124 for ; Tue, 23 Apr 2013 10:31:40 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753084Ab3DWAbh (ORCPT ); Mon, 22 Apr 2013 20:31:37 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:47510 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752221Ab3DWAbg (ORCPT ); Mon, 22 Apr 2013 20:31:36 -0400 Received: by mail-ie0-f177.google.com with SMTP id 9so73573iec.22 for ; Mon, 22 Apr 2013 17:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:subject:from:to:cc:date:content-type:x-mailer :content-transfer-encoding:mime-version; bh=WxlzC8weDp2qa5NpHvtnpi3+eUBX1Pec6xLKcUS5as4=; b=b3iAmrj5wN7qOjoc9vXBpjP/pUepGYJG43LTGzruZRp6e6zA+Dw+GfvRwIGY5Zxh2k SzjPjpFS8U8SjZBEkON4WzD1Yt1o+TWyGJYYzFnvpJnt+kOpSzRsjDQDLEWzJBDheibJ VSvgAFXXRyXLxE11VMayo9KKxrvwjF2VyTT9Y/04zEwMVcrnLcka4feD+wXz9RCTXmui s6B3dxdbfjGRp9LvP1e9cFWiwYcXuWW9V0tv0yK5G3p6Zr7AIgJG+lb+R1y5o608YF8y FyqcgU6vUr/dW+1Ioia9HmY2afnNzc5lWIQnBeWY/s8EC+oAchivixy58AalgEW9lFEG WNng== X-Received: by 10.50.11.229 with SMTP id t5mr8207035igb.65.1366677096547; Mon, 22 Apr 2013 17:31:36 -0700 (PDT) Received: from ?IPv6:2620:0:1000:3304:39fd:ac09:6c8c:5da0? ([2620:0:1000:3304:39fd:ac09:6c8c:5da0]) by mx.google.com with ESMTPS id x16sm20024164igp.8.2013.04.22.17.31.35 (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 22 Apr 2013 17:31:36 -0700 (PDT) Message-ID: <1366677094.16391.97.camel@edumazet-glaptop> Subject: [PATCH net-next] net: remove redundant code in dev_hard_start_xmit() From: Eric Dumazet To: David Miller Cc: netdev , Krishna Kumar Date: Mon, 22 Apr 2013 17:31:34 -0700 X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet This reverts commit 068a2de57ddf4f4 (net: release dst entry while cache-hot for GSO case too) Before GSO packet segmentation, we already take care of skb->dst if it can be released. There is no point adding extra test for every segment in the gso loop. Signed-off-by: Eric Dumazet Cc: Krishna Kumar --- net/core/dev.c | 7 ------- 1 file changed, 7 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/core/dev.c b/net/core/dev.c index 8a3cb2c..6a82eed 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2543,13 +2543,6 @@ gso: skb->next = nskb->next; nskb->next = NULL; - /* - * If device doesn't need nskb->dst, release it right now while - * its hot in this cpu cache - */ - if (dev->priv_flags & IFF_XMIT_DST_RELEASE) - skb_dst_drop(nskb); - if (!list_empty(&ptype_all)) dev_queue_xmit_nit(nskb, dev);