Patchwork [net-next] net: remove redundant code in dev_hard_start_xmit()

login
register
mail settings
Submitter Eric Dumazet
Date April 23, 2013, 12:31 a.m.
Message ID <1366677094.16391.97.camel@edumazet-glaptop>
Download mbox | patch
Permalink /patch/238702/
State Accepted
Delegated to: David Miller
Headers show

Comments

Eric Dumazet - April 23, 2013, 12:31 a.m.
From: Eric Dumazet <edumazet@google.com>

This reverts commit 068a2de57ddf4f4 (net: release dst entry while
cache-hot for GSO case too)

Before GSO packet segmentation, we already take care of skb->dst if it
can be released.

There is no point adding extra test for every segment in the gso loop.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Krishna Kumar <krkumar2@in.ibm.com>
---
 net/core/dev.c |    7 -------
 1 file changed, 7 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - April 25, 2013, 5:39 a.m.
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 22 Apr 2013 17:31:34 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> This reverts commit 068a2de57ddf4f4 (net: release dst entry while
> cache-hot for GSO case too)
> 
> Before GSO packet segmentation, we already take care of skb->dst if it
> can be released.
> 
> There is no point adding extra test for every segment in the gso loop.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/core/dev.c b/net/core/dev.c
index 8a3cb2c..6a82eed 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2543,13 +2543,6 @@  gso:
 		skb->next = nskb->next;
 		nskb->next = NULL;
 
-		/*
-		 * If device doesn't need nskb->dst, release it right now while
-		 * its hot in this cpu cache
-		 */
-		if (dev->priv_flags & IFF_XMIT_DST_RELEASE)
-			skb_dst_drop(nskb);
-
 		if (!list_empty(&ptype_all))
 			dev_queue_xmit_nit(nskb, dev);