Patchwork [2/7] arc: Add option for ARC-specific download site

login
register
mail settings
Submitter Mischa Jonker
Date April 22, 2013, 11:37 a.m.
Message ID <1366630651-6857-3-git-send-email-mjonker@synopsys.com>
Download mbox | patch
Permalink /patch/238473/
State Changes Requested
Headers show

Comments

Mischa Jonker - April 22, 2013, 11:37 a.m.
As ARC support is not yet in all upstream packages, a different location is
required to download the packages from. This adds an option to specify a
site for ARC-specific versions of packages such as binutils, gcc.

When ARC support has been upstreamed for all packages, this option can be
removed again.

Signed-off-by: Mischa Jonker <mjonker@synopsys.com>
---
 Config.in |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
Thomas Petazzoni - April 22, 2013, 3:48 p.m.
Dear Mischa Jonker,

On Mon, 22 Apr 2013 13:37:26 +0200, Mischa Jonker wrote:

> +config BR2_ARC_SITE
> +	string "Download site for ARC specific packages"
> +	default "http://www.synopsys.com/apps/arc-developer/"
> +	depends on BR2_arc || BR2_arceb
> +	help
> +	  This download site is used for packages that require specific
> +	  support for ARC, while this support is not yet pushed to the
> +	  respective open source project.

Is there some realistic case for which this URL would need to be
changed by the user? I think I'd prefer to hardcode the URL in the
binutils/gcc/uClibc recipes, just like we do a special casing for
AVR32, unless of course there is some compelling reason for making this
configurable.

Best regards,

Thomas
Arnout Vandecappelle - April 22, 2013, 6:25 p.m.
On 22/04/13 17:48, Thomas Petazzoni wrote:
> Dear Mischa Jonker,
>
> On Mon, 22 Apr 2013 13:37:26 +0200, Mischa Jonker wrote:
>
>> >+config BR2_ARC_SITE
>> >+	string "Download site for ARC specific packages"
>> >+	default"http://www.synopsys.com/apps/arc-developer/"
>> >+	depends on BR2_arc || BR2_arceb
>> >+	help
>> >+	  This download site is used for packages that require specific
>> >+	  support for ARC, while this support is not yet pushed to the
>> >+	  respective open source project.
> Is there some realistic case for which this URL would need to be
> changed by the user? I think I'd prefer to hardcode the URL in the
> binutils/gcc/uClibc recipes, just like we do a special casing for
> AVR32, unless of course there is some compelling reason for making this
> configurable.

  +1 on that.

  But it may make sense to define the base URL once in some .mk file and 
use it in the other locations. You probably don't need to worry about the 
order of .mk file inclusion because the variable will only be expanded 
when a rule is executed, not when the .mk files are parsed. So it should 
be safe to define it in e.g. the toolchain/gcc/gcc.mk and use it in binutils.

  Regards,
  Arnout

Patch

diff --git a/Config.in b/Config.in
index bbb9885..c365b38 100644
--- a/Config.in
+++ b/Config.in
@@ -141,6 +141,15 @@  config BR2_PRIMARY_SITE
 	  NOTE: This works for all packages using the central package
 	  infrastructure (generic, autotools, cmake, ...)
 
+config BR2_ARC_SITE
+	string "Download site for ARC specific packages"
+	default "http://www.synopsys.com/apps/arc-developer/"
+	depends on BR2_arc || BR2_arceb
+	help
+	  This download site is used for packages that require specific
+	  support for ARC, while this support is not yet pushed to the
+	  respective open source project.
+
 config BR2_PRIMARY_SITE_ONLY
 	bool "Only allow downloads from primary download site"
 	depends on BR2_PRIMARY_SITE != ""