Patchwork [v3,22/24] build: Fix installation of target-dependant files

login
register
mail settings
Submitter Lluís Vilanova
Date April 21, 2013, 7:13 p.m.
Message ID <20130421191333.8947.34112.stgit@fimbulvetr.bsc.es>
Download mbox | patch
Permalink /patch/238240/
State New
Headers show

Comments

Lluís Vilanova - April 21, 2013, 7:13 p.m.
Pass all the relevant sub-directory make variables.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
Cc: Anthony Liguori <aliguori@us.ibm.com>
Cc: Paul Brook <paul@codesourcery.com>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Paolo Bonzini - April 26, 2013, 3:24 p.m.
Il 21/04/2013 21:13, Lluís Vilanova ha scritto:
> Pass all the relevant sub-directory make variables.
> 
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Cc: Paul Brook <paul@codesourcery.com>
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 7916152..ccf6760 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -346,7 +346,7 @@ endif
>  		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
>  	done
>  	for d in $(TARGET_DIRS); do \
> -	$(MAKE) -C $$d $@ || exit 1 ; \
> +	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
>          done
>  
>  # various test targets
> 
> 
> 

Please resubmit this separately too, it is a worthwhile cleanup.

Paolo
Peter Maydell - April 26, 2013, 3:27 p.m.
On 26 April 2013 16:24, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 21/04/2013 21:13, Lluís Vilanova ha scritto:
>> Pass all the relevant sub-directory make variables.
>>
>> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>

> Please resubmit this separately too, it is a worthwhile cleanup.

...if you're going to resubmit anyway, you might fix the
typo in the commit message: "dependent" ends -ent.

thanks
-- PMM

Patch

diff --git a/Makefile b/Makefile
index 7916152..ccf6760 100644
--- a/Makefile
+++ b/Makefile
@@ -346,7 +346,7 @@  endif
 		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
 	done
 	for d in $(TARGET_DIRS); do \
-	$(MAKE) -C $$d $@ || exit 1 ; \
+	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
         done
 
 # various test targets