From patchwork Sun Apr 21 11:03:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Clifton X-Patchwork-Id: 238212 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 42FC82C012B for ; Sun, 21 Apr 2013 21:08:46 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; q=dns; s=default; b=FlQxWpwh/m+HJB7Z/bYNYoJqTErMaBcYMe7aLLdPr2Z85Wfyqc Z9Xz6DHd4XK69uddtf2jVh4mtgd3YH4gtlq8Ci6vcWH1zhbEN7h8TJc3ZfU9W5bx XtWtexbC3HDmbnGRpK8xA4BXWbS7HtidL3CTmkTQfnQyIMjeLdacQjRRQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; s= default; bh=u3Qb0rrlyJXKungNv4g/41QuH/A=; b=E5UskoXeLCc82RfR1jkA S826sFUgzgB9/AmZYLLB/FpZhVy3ml1qd9MW5+6xUc/aVJRC+TV6M4/LtJokJQyi 92xCNmpKn+CKYhqZmVgU/HIdJFi7ygRR6um/krqPDB4VyksS9sjdiVJ8JbLdj/sj MZqcSCPrNYUdGs19JQUSTQ0= Received: (qmail 13116 invoked by alias); 21 Apr 2013 11:08:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 13103 invoked by uid 89); 21 Apr 2013 11:08:39 -0000 X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, RP_MATCHES_RCVD, SPF_HELO_PASS, TW_EG autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 21 Apr 2013 11:08:38 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3LB8b6T028124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 21 Apr 2013 07:08:37 -0400 Received: from Cadeux.redhat.com (vpn1-4-233.ams2.redhat.com [10.36.4.233]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3LB8V2m023054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 21 Apr 2013 07:08:34 -0400 From: Nick Clifton To: walt@tilera.com Cc: gcc-patches@gcc.gnu.org Subject: RFA: Fix use of extra_objs when configuring tilepro-linux and tilegx-linux Date: Sun, 21 Apr 2013 12:03:12 +0100 Message-ID: <87k3nw9mdr.fsf@redhat.com> MIME-Version: 1.0 Hi Walter, The tilepro-gnu-linux and tilegx-gnu-linux currently fail to build in the FSF mainline sources because of: libbackend.a(tilepro.o):(.data+0x2e4): undefined reference to `linux_android_has_ifunc_p()' This happens because the entries for tilegx-linux and tilepro-linux in config.gcc override the definition of extra_objs, rather than extending it, thus loosing the inclusion of linux_android.o into libbackend.a. I fixed the problem with the patch below and was able to build both toolchains. OK to apply ? Cheers Nick gcc/ChangeLog 2013-04-21 Nick Clifton * config.gcc (tilegx-linux): Extend extra_objs rather than overwriting it. (tilepro-linux): Likewise. Index: gcc/config.gcc =================================================================== --- gcc/config.gcc (revision 198115) +++ gcc/config.gcc (working copy) @@ -2573,7 +2573,7 @@ tilegx-*-linux*) tm_file="elfos.h gnu-user.h linux.h glibc-stdint.h tilegx/linux.h ${tm_file}" tmake_file="${tmake_file} tilegx/t-tilegx" - extra_objs="mul-tables.o" + extra_objs="${extra_objs} mul-tables.o" c_target_objs="${c_target_objs} tilegx-c.o" cxx_target_objs="${cxx_target_objs} tilegx-c.o" extra_headers="feedback.h" @@ -2581,7 +2581,7 @@ tilepro-*-linux*) tm_file="elfos.h gnu-user.h linux.h glibc-stdint.h tilepro/linux.h ${tm_file}" tmake_file="${tmake_file} tilepro/t-tilepro" - extra_objs="mul-tables.o" + extra_objs="${extra_objs} mul-tables.o" c_target_objs="${c_target_objs} tilepro-c.o" cxx_target_objs="${cxx_target_objs} tilepro-c.o" extra_headers="feedback.h"