[RFC] pci: use current bus # for pci_for_each_device

Submitted by Michael S. Tsirkin on April 21, 2013, 8:39 a.m.


Message ID 20130421083942.GA24418@redhat.com
State New
Headers show

Commit Message

Michael S. Tsirkin April 21, 2013, 8:39 a.m.
I see two types of users of pci_for_each_device: some pass in bus #
directly, some pass in 0.  I am guessing that those passing 0 really
want the root, so the right thing is likely to
use the bus number directly.
Could some Xen folks comment on whether the following
patch breaks anything?
If not I'll apply it, and will add another patch removing
bus_nr from pci_for_each_device completely, on top.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


Untested patch below.

Patch hide | download patch | download mbox

diff --git a/hw/xen/xen_platform.c b/hw/xen/xen_platform.c
index b6c6793..7d2ca63 100644
--- a/hw/xen/xen_platform.c
+++ b/hw/xen/xen_platform.c
@@ -94,7 +94,7 @@  static void unplug_nic(PCIBus *b, PCIDevice *d, void *o)
 static void pci_unplug_nics(PCIBus *bus)
-    pci_for_each_device(bus, 0, unplug_nic, NULL);
+    pci_for_each_device(bus, pci_bus_num(bus), unplug_nic, NULL);
 static void unplug_disks(PCIBus *b, PCIDevice *d, void *o)
@@ -109,7 +109,7 @@  static void unplug_disks(PCIBus *b, PCIDevice *d, void *o)
 static void pci_unplug_disks(PCIBus *bus)
-    pci_for_each_device(bus, 0, unplug_disks, NULL);
+    pci_for_each_device(bus, pci_bus_num(bus), unplug_disks, NULL);
 static void platform_fixed_ioport_writew(void *opaque, uint32_t addr, uint32_t val)