Patchwork [net] irda: irlmp_reasons[] can be static

login
register
mail settings
Submitter Wu Fengguang
Date April 20, 2013, 3:10 a.m.
Message ID <20130420031045.GC7366@localhost>
Download mbox | patch
Permalink /patch/238137/
State Accepted
Delegated to: David Miller
Headers show

Comments

Wu Fengguang - April 20, 2013, 3:10 a.m.
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 irlmp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dan Carpenter - April 20, 2013, 11:11 a.m.
On Sat, Apr 20, 2013 at 11:10:45AM +0800, Fengguang Wu wrote:
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  irlmp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/irda/irlmp.c b/net/irda/irlmp.c
> index 1064621..98ad6ec 100644
> --- a/net/irda/irlmp.c
> +++ b/net/irda/irlmp.c
> @@ -58,7 +58,7 @@ int  sysctl_discovery_slots   = 6; /* 6 slots by default */
>  int  sysctl_lap_keepalive_time = LM_IDLE_TIMEOUT * 1000 / HZ;
>  char sysctl_devname[65];
>  
> -const char *irlmp_reasons[] = {
> +static const char *irlmp_reasons[] = {

Oops.  Sorry for that.  I do run Sparse on my patches but I missed
that.

Acked-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - April 25, 2013, 5:43 a.m.
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sat, 20 Apr 2013 14:11:51 +0300

> On Sat, Apr 20, 2013 at 11:10:45AM +0800, Fengguang Wu wrote:
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>>  irlmp.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/net/irda/irlmp.c b/net/irda/irlmp.c
>> index 1064621..98ad6ec 100644
>> --- a/net/irda/irlmp.c
>> +++ b/net/irda/irlmp.c
>> @@ -58,7 +58,7 @@ int  sysctl_discovery_slots   = 6; /* 6 slots by default */
>>  int  sysctl_lap_keepalive_time = LM_IDLE_TIMEOUT * 1000 / HZ;
>>  char sysctl_devname[65];
>>  
>> -const char *irlmp_reasons[] = {
>> +static const char *irlmp_reasons[] = {
> 
> Oops.  Sorry for that.  I do run Sparse on my patches but I missed
> that.
> 
> Acked-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied to net-next, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/irda/irlmp.c b/net/irda/irlmp.c
index 1064621..98ad6ec 100644
--- a/net/irda/irlmp.c
+++ b/net/irda/irlmp.c
@@ -58,7 +58,7 @@  int  sysctl_discovery_slots   = 6; /* 6 slots by default */
 int  sysctl_lap_keepalive_time = LM_IDLE_TIMEOUT * 1000 / HZ;
 char sysctl_devname[65];
 
-const char *irlmp_reasons[] = {
+static const char *irlmp_reasons[] = {
 	"ERROR, NOT USED",
 	"LM_USER_REQUEST",
 	"LM_LAP_DISCONNECT",