Patchwork [U-Boot,v4,2/2] mx51evk: Do not force the rootfs type

login
register
mail settings
Submitter Fabio Estevam
Date April 19, 2013, 5:43 p.m.
Message ID <1366393422-19558-2-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/238075/
State Superseded
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - April 19, 2013, 5:43 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

Currently mmcrootfstype is set to ext3 type.

It is better not to force it in the env vars, because users may prefer a 
different file system type, so let's get rid of 'mmcrootfstype'.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v3:
- Newly introduced

 include/configs/mx51evk.h |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Otavio Salvador - April 19, 2013, 6:01 p.m.
On Fri, Apr 19, 2013 at 2:43 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Currently mmcrootfstype is set to ext3 type.
>
> It is better not to force it in the env vars, because users may prefer a
> different file system type, so let's get rid of 'mmcrootfstype'.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Otavio Salvador - April 19, 2013, 8:22 p.m.
On Fri, Apr 19, 2013 at 3:01 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Fri, Apr 19, 2013 at 2:43 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Currently mmcrootfstype is set to ext3 type.
>>
>> It is better not to force it in the env vars, because users may prefer a
>> different file system type, so let's get rid of 'mmcrootfstype'.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>

-               "root=${mmcroot} " \
-               "rootfstype=${mmcrootfstype}\0" \
+               "root=${mmcroot}\0" \

Please do this in this patch as well ;-)

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h
index 4545a80..0973a74 100644
--- a/include/configs/mx51evk.h
+++ b/include/configs/mx51evk.h
@@ -160,8 +160,7 @@ 
 	"ip_dyn=yes\0" \
 	"mmcdev=0\0" \
 	"mmcpart=2\0" \
-	"mmcroot=/dev/mmcblk0p3 rw\0" \
-	"mmcrootfstype=ext3 rootwait\0" \
+	"mmcroot=/dev/mmcblk0p3 rootwait rw\0" \
 	"mmcargs=setenv bootargs console=ttymxc0,${baudrate} " \
 		"root=${mmcroot} " \
 		"rootfstype=${mmcrootfstype}\0" \