Patchwork [Raring,SRU,PULL] fix XPS13-FHD backlight regression

login
register
mail settings
Submitter Kamal Mostafa
Date April 19, 2013, 4:41 p.m.
Message ID <1366389698.4705.14.camel@fourier>
Download mbox | patch
Permalink /patch/238052/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/kamal/ubuntu-raring.git lp1169376-xps13-fhd

Comments

Kamal Mostafa - April 19, 2013, 4:41 p.m.
Bug reference:

	https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1169376
	XPS13 backlight stopped working after update 3.8.0-18.28

[IMPACT]

My recent sauce patch for LP: #1162026 (Raring 9742db3) applied a quirk to
fix the backlight controls on two variants of the Dell XPS13, but it turns
out that the quirk is only appropriate for the original 768p model (there
was some misunderstanding about which models needed it).

The new Dell XPS13 "FHD" 1080p model is actually adversely affected by the
quirk, yielding dark screen on boot and no backlight controls.  This patch
removes the 1080p model from the dmi quirk table, restoring its backlight
behavior to normal functionality.

[TESTCASE]

The bug reporter in LP: #1169376 has confirmed that a test kernel with the
patch applied fixes it for his 1080p model.  I have confirmed that the
original quirk patch still works on my 768p model.

[Regression Potential]

Low regression potential: the change only affects the Dell XPS 13 "FHD" 1080p
model, returning its i915 backlight controls to the standard mainline
(pre 3.8.0-18.28) behavior.


Thanks,

 -Kamal

-------- >8 ----------------------------------------------------

The following changes since commit 10e251b7b13b2c727d58a7d3ed4451667366ad12:

  UBUNTU: SAUCE: (no-up) ACPI: Disable Windows 8 compatibility for some Lenovo ThinkPads (2013-04-19 07:29:30 -0700)

are available in the git repository at:

  git://kernel.ubuntu.com/kamal/ubuntu-raring.git lp1169376-xps13-fhd

for you to fetch changes up to ba44c190aafad79f11e6b5477de26f81b8fdb3ac:

  UBUNTU: SAUCE: (no-up) drm/i915: quirk no PCH_PWM_ENABLE only Dell XPS13 SandyBridge (2013-04-19 08:52:52 -0700)

----------------------------------------------------------------
Kamal Mostafa (1):
      UBUNTU: SAUCE: (no-up) drm/i915: quirk no PCH_PWM_ENABLE only Dell XPS13 SandyBridge

 drivers/gpu/drm/i915/intel_display.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Tim Gardner - April 19, 2013, 4:49 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

> Kamal Mostafa (1): UBUNTU: SAUCE: (no-up) drm/i915: quirk no
> PCH_PWM_ENABLE only Dell XPS13 SandyBridge
> 

I would like the commit subject to be grammatical. This one just makes
my head hurt.


- -- 
Tim Gardner tim.gardner@canonical.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQIcBAEBCgAGBQJRcXWtAAoJED12yEX6FEfKYw0P/20gzBMl1Tp9nCQuJcQp0bVF
0x8maOdb2gQJFsRvKedFdff5qCLLRnD9ZLqPuD0upJaf8cMpcEBcg0gX2iH2vng9
h0aYGmcryj9rQlvXEXaxZKolkVtNHs8rlAZVaGUG+cxEyEaxdkl5YDd912FfX0ut
6qm6QS81LVEkiDn2ZnMlklOjehzXV3YZfCKwtCqMlJn1x4/rlkszU9SXeY5aD4I/
5+7CClqxJf0GT0w5c6xrhQMkyopWZ4xGMf7IU1es4NlWwelQGonx/hMzCTCgFk9k
szC3OBdfUEJUUmMuKr08+3pxmEkKifS1y2Rpz3sB+6xSkw8YHwGcY3sf95cZe+91
8RAHpMXJPK4ulND+Deo904AZ5ezkHM0SM1+ofPURAmAzF6sbCP/FXOIkHj+hmJmH
aQSdDY4Bspv2pVbGJvxHLYoYZCI8loV/IE22W7YbqJQvDcH4/e4iSR/CMZ5BztbB
29FenoZmVIX8+NJM2yP14T/EZiosJAdka275ls/4VQmDUzRi5umchepeUqSDkoe4
MNt2YqZrriu8IQ6hlmR3ur7V1kLGqoGJASFCuDZnCe6VLWn+KEFWJZLC5f8Mse50
73hJUr/J+HrZKADdSwwp4EDlxweGKlMUAIT4u1+HtKQlGEgkIoh5/Au+IUUdpGTx
9RybAos5N0wb0LKhyqEH
=nlQO
-----END PGP SIGNATURE-----
Seth Forshee - April 19, 2013, 4:50 p.m.

Kamal Mostafa - April 19, 2013, 4:55 p.m.
On Fri, 2013-04-19 at 10:49 -0600, Tim Gardner wrote:
> > Kamal Mostafa (1): UBUNTU: SAUCE: (no-up) drm/i915: quirk no
> > PCH_PWM_ENABLE only Dell XPS13 SandyBridge
> > 
> 
> I would like the commit subject to be grammatical. This one just makes
> my head hurt.
> 
> 

Wow reading it again... what a mess, sorry!

I tried to encode the concept:  "Unapply the 'do not enable PCH_PWM'
quirk from the model that doesn't need it."

Thanks for fixing it for me, Tim.

 -Kamal
Tim Gardner - April 19, 2013, 5:04 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Changed commit subject to 'UBUNTU: SAUCE: (no-up) drm/i915: revert
PCH_PWM_ENABLE quirk for XPS13-FHD'


- -- 
Tim Gardner tim.gardner@canonical.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQIcBAEBCgAGBQJRcXkRAAoJED12yEX6FEfKgtwP/RWAfpe5OTNrcqVMfPkBLLxe
j3Aw7jsj4lqtXE7Q5EoBn+HA9nyN3p/Y92C5eQjJqz4ij2qSkcHCtyAHEzkxARpk
XpWoFBI2ujF9s8g9AtAfYmT0BJJrn7iM5htTe+Gg7XGyvICpVaf71cZLS0Ij/0Fb
FJYScnuoO1IhzjlBhAJM15eBWhL8ptO94T6gK+4F6o8M70XlNsnrBDIeONelwAMw
hmNZe9EDke5oy0D3CkQ3DoZGiYnNmUtJZ21jAzERV9WG4YtpO47H9kMD1FFw6bk+
rS4zZITZtmpXKjtHQyI2Xw7q16YEjbQ/UTcykPG8BAbgsbFqPH0PISNmHQ9VPK4Z
2xKN1bsQaEH5zmXWiaO8BsiGyl0z2qghZeEz9I70zSWPHiZvF1ilz5rljaWRKlRW
5o8QfaGcoQogN7sp5MGwja0B55rDf+OnFX1D6huwSbWvYQZoctEVtR7wnvmqraOg
CC19+zhLGBfss7Pp57tmhIr2XP5xGMABHa6GxETglP6CmrIB9hcMjHD52M6V4BEA
UZezLn6oRGKO1q5Akn75+EeGX6hVPa93TUZNI41IPfqpV7w+M7Pwj1tCM+zjE3kL
yrT72mSpdUQhSgtb8tEv2yHAH3nIK4CCnOjBz/HMCPhEILxWqt+M3E+6/RJf5t8B
vAV009obEqwnRCh5ECl0
=Eo3p
-----END PGP SIGNATURE-----

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index d7231cb..b56b846 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -8893,9 +8893,8 @@  static const struct intel_dmi_quirk intel_dmi_quirks[] = {
 };
 
 static struct intel_quirk intel_quirks[] = {
-	/* Dell XPS13 models */
+	/* Dell XPS13 SandyBridge */
 	{ 0x0116, 0x1028, 0x052e, quirk_no_pcm_pwm_enable },
-	{ 0x0166, 0x1028, 0x058b, quirk_no_pcm_pwm_enable },
 
 	/* HP Mini needs pipe A force quirk (LP: #322104) */
 	{ 0x27ae, 0x103c, 0x361a, quirk_pipea_force },