Patchwork [net-next,1/2] packet: reorder a member in packet_ring_buffer

login
register
mail settings
Submitter Daniel Borkmann
Date April 19, 2013, 4:12 p.m.
Message ID <1366387949-9161-1-git-send-email-dborkman@redhat.com>
Download mbox | patch
Permalink /patch/238047/
State Accepted
Delegated to: David Miller
Headers show

Comments

Daniel Borkmann - April 19, 2013, 4:12 p.m.
There's a 4 byte hole in packet_ring_buffer structure before
prb_bdqc, that can be filled with 'pending' member, thus we can
reduce the overall structure size from 224 bytes to 216 bytes.
This also has the side-effect, that in struct packet_sock 2*4 byte
holes after the embedded packet_ring_buffer members are removed,
and overall, packet_sock can be reduced by 1 cacheline:

Before: size: 1344, cachelines: 21, members: 24
After:  size: 1280, cachelines: 20, members: 24

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
---
 net/packet/internal.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
David Miller - April 25, 2013, 5:29 a.m.
From: Daniel Borkmann <dborkman@redhat.com>
Date: Fri, 19 Apr 2013 18:12:28 +0200

> There's a 4 byte hole in packet_ring_buffer structure before
> prb_bdqc, that can be filled with 'pending' member, thus we can
> reduce the overall structure size from 224 bytes to 216 bytes.
> This also has the side-effect, that in struct packet_sock 2*4 byte
> holes after the embedded packet_ring_buffer members are removed,
> and overall, packet_sock can be reduced by 1 cacheline:
> 
> Before: size: 1344, cachelines: 21, members: 24
> After:  size: 1280, cachelines: 20, members: 24
> 
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/packet/internal.h b/net/packet/internal.h
index e891f02..650751b 100644
--- a/net/packet/internal.h
+++ b/net/packet/internal.h
@@ -54,6 +54,7 @@  struct pgv {
 
 struct packet_ring_buffer {
 	struct pgv		*pg_vec;
+
 	unsigned int		head;
 	unsigned int		frames_per_block;
 	unsigned int		frame_size;
@@ -63,8 +64,9 @@  struct packet_ring_buffer {
 	unsigned int		pg_vec_pages;
 	unsigned int		pg_vec_len;
 
-	struct tpacket_kbdq_core	prb_bdqc;
 	atomic_t		pending;
+
+	struct tpacket_kbdq_core	prb_bdqc;
 };
 
 extern struct mutex fanout_mutex;